feat: add ask_chatgpt tool handler

2026-06-12 07:43:20 +01:00
parent 3f6eec38e2
commit 3eedcfa559
5 changed files with 486 additions and 3 deletions
@@ -0,0 +1,368 @@
+import { describe, it, expect, vi } from "vitest";
+import { handleAskChatGpt } from "../../src/tools/ask-chatgpt.js";
+
+const mockConfig = {
+  openaiApiKey: "sk-test-key",
+  openaiModel: "gpt-5.1",
+  temperature: 0.2,
+  maxOutputTokens: 2000,
+  logLevel: "info",
+  enableFileContext: false,
+  contextDir: "./context",
+  maxInputChars: 30000,
+  maxFileChars: 12000,
+  maxFiles: 5,
+  maxLogChars: 10000,
+  redactSecrets: true,
+};
+
+function makeValidInput(question) {
+  return { question };
+}
+
+// --- Success path ---
+
+describe("success path", () => {
+  it("returns ok:true with answer on full happy flow", async () => {
+    const loadConfig = vi.fn(() => mockConfig);
+    const createOpenAIClient = vi.fn(() => ({ responses: { create: vi.fn() } }));
+    const sendOpenAIResponse = vi.fn(async () => ({ content: "OK" }));
+
+    const result = await handleAskChatGpt(makeValidInput("What is 2+2?"), {
+      loadConfig, createOpenAIClient, sendOpenAIResponse,
+    });
+
+    expect(result.ok).toBe(true);
+    expect(result.answer).toBe("OK");
+    expect(result.warnings).toEqual([]);
+  });
+
+  it("propagates budget warnings through to success result", async () => {
+    const trimmedBudget = { ...mockConfig, maxInputChars: 50 };
+    const loadConfig = vi.fn(() => trimmedBudget);
+    const createOpenAIClient = vi.fn(() => ({ responses: { create: vi.fn() } }));
+    const sendOpenAIResponse = vi.fn(async () => ({ content: "OK" }));
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), {
+      loadConfig, createOpenAIClient, sendOpenAIResponse,
+    });
+
+    expect(result.ok).toBe(true);
+    // Budget warnings may or may not be present depending on exact input size vs budget.
+    expect(Array.isArray(result.warnings)).toBe(true);
+  });
+});
+
+// --- Validation failure (short-circuit before config) ---
+
+describe("validation failure", () => {
+  it("returns structured error when question is missing", async () => {
+    const loadConfig = vi.fn();
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    const result = await handleAskChatGpt({}, { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.ok).toBe(false);
+    expect(typeof result.error).toBe("string");
+    expect(result.warnings).toEqual([]);
+  });
+
+  it("short-circuits — no other deps called", async () => {
+    const loadConfig = vi.fn();
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    await handleAskChatGpt({ foo: "bar" }, { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(loadConfig).not.toHaveBeenCalled();
+    expect(createOpenAIClient).not.toHaveBeenCalled();
+    expect(sendOpenAIResponse).not.toHaveBeenCalled();
+  });
+
+  it("returns structured error when question is empty string", async () => {
+    const loadConfig = vi.fn();
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    const result = await handleAskChatGpt({ question: "" }, { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.ok).toBe(false);
+    expect(typeof result.error).toBe("string");
+    expect(result.warnings).toEqual([]);
+  });
+
+  it("returns structured error when question is wrong type", async () => {
+    const loadConfig = vi.fn();
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    const result = await handleAskChatGpt({ question: 123 }, { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.ok).toBe(false);
+    expect(typeof result.error).toBe("string");
+    expect(result.warnings).toEqual([]);
+  });
+});
+
+// --- Config failure ---
+
+describe("config failure", () => {
+  it("returns structured error when loadConfig throws", async () => {
+    const loadConfig = vi.fn(() => { throw new Error("OPENAI_API_KEY is missing."); });
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.ok).toBe(false);
+    expect(result.error).toContain("OPENAI_API_KEY is missing");
+  });
+
+  it("short-circuits — no client or response calls after config failure", async () => {
+    const loadConfig = vi.fn(() => { throw new Error("No key."); });
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(createOpenAIClient).not.toHaveBeenCalled();
+    expect(sendOpenAIResponse).not.toHaveBeenCalled();
+  });
+
+  it("passes original error message", async () => {
+    const loadConfig = vi.fn(() => { throw new Error("OPENAI_API_KEY is missing."); });
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.error).toBe("Error: OPENAI_API_KEY is missing.");
+  });
+});
+
+// --- Budget failure (short-circuit before prompt/client) ---
+
+describe("budget failure", () => {
+  it("returns structured error with budget warnings when input exceeds budget", async () => {
+    const tinyBudget = { ...mockConfig, maxInputChars: 0 };
+    const loadConfig = vi.fn(() => tinyBudget);
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.ok).toBe(false);
+    expect(typeof result.error).toBe("string");
+    expect(Array.isArray(result.warnings)).toBe(true);
+  });
+
+  it("short-circuits — no prompt built, no client created, no response sent", async () => {
+    const tinyBudget = { ...mockConfig, maxInputChars: 0 };
+    const loadConfig = vi.fn(() => tinyBudget);
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(createOpenAIClient).not.toHaveBeenCalled();
+    expect(sendOpenAIResponse).not.toHaveBeenCalled();
+  });
+
+  it("passes budget warnings through to the error result", async () => {
+    const tinyBudget = { ...mockConfig, maxInputChars: 0 };
+    const loadConfig = vi.fn(() => tinyBudget);
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    // maxInputChars=0 forces rejection even with minimal input.
+    const result = await handleAskChatGpt(
+      { question: "x", context: "a".repeat(20) },
+      { loadConfig, createOpenAIClient, sendOpenAIResponse },
+    );
+
+    expect(result.ok).toBe(false);
+    expect(Array.isArray(result.warnings)).toBe(true);
+  });
+});
+
+// --- Client creation failure ---
+
+describe("client creation failure", () => {
+  it("returns structured error when createOpenAIClient throws", async () => {
+    const loadConfig = vi.fn(() => mockConfig);
+    const createOpenAIClient = vi.fn(() => { throw new Error("Invalid config."); });
+    const sendOpenAIResponse = vi.fn();
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.ok).toBe(false);
+    expect(typeof result.error).toBe("string");
+    expect(result.warnings).toEqual([]);
+  });
+
+  it("short-circuits — no response sent after client failure", async () => {
+    const loadConfig = vi.fn(() => mockConfig);
+    const createOpenAIClient = vi.fn(() => { throw new Error("Invalid config."); });
+    const sendOpenAIResponse = vi.fn();
+
+    await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(sendOpenAIResponse).not.toHaveBeenCalled();
+  });
+
+  it("passes original error message unchanged", async () => {
+    const loadConfig = vi.fn(() => mockConfig);
+    const createOpenAIClient = vi.fn(() => { throw new Error("Invalid config."); });
+    const sendOpenAIResponse = vi.fn();
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.error).toBe("Error: Invalid config.");
+  });
+});
+
+// --- OpenAI failure (pass-through) ---
+
+describe("OpenAI failure", () => {
+  it("passes through err.message unchanged", async () => {
+    const loadConfig = vi.fn(() => mockConfig);
+    const createOpenAIClient = vi.fn(() => ({ responses: { create: vi.fn() } }));
+    const sendOpenAIResponse = vi.fn().mockRejectedValue(new Error("API key invalid."));
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.ok).toBe(false);
+    expect(result.error).toBe("Error: API key invalid.");
+    expect(result.warnings).toEqual([]);
+  });
+
+  it("short-circuits — no extra processing after API failure", async () => {
+    const loadConfig = vi.fn(() => mockConfig);
+    const createOpenAIClient = vi.fn(() => ({ responses: { create: vi.fn() } }));
+    const sendOpenAIResponse = vi.fn().mockRejectedValue(new Error("rate limit"));
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.ok).toBe(false);
+    expect(result.error).toBe("Error: rate limit");
+  });
+
+  it("does not wrap or reformat the error", async () => {
+    const loadConfig = vi.fn(() => mockConfig);
+    const createOpenAIClient = vi.fn(() => ({ responses: { create: vi.fn() } }));
+    const sendOpenAIResponse = vi.fn().mockRejectedValue(new Error("429 Too Many Requests"));
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.error).toBe("Error: 429 Too Many Requests");
+  });
+});
+
+// --- Dependency call order ---
+
+describe("dependency call order", () => {
+  it("calls deps in correct order: config -> client -> response", async () => {
+    const callLog = [];
+    const loadConfig = vi.fn(() => { callLog.push("config"); return mockConfig; });
+    const createOpenAIClient = vi.fn(() => { callLog.push("client"); return { responses: { create: vi.fn() } }; });
+    const sendOpenAIResponse = vi.fn(async () => { callLog.push("response"); return { content: "OK" }; });
+
+    await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(callLog).toEqual(["config", "client", "response"]);
+  });
+});
+
+// --- No throws escaping ---
+
+describe("no throws escaping", () => {
+  it("returns structured result when sendOpenAIResponse throws null", async () => {
+    const loadConfig = vi.fn(() => mockConfig);
+    const createOpenAIClient = vi.fn(() => ({ responses: { create: vi.fn() } }));
+    const sendOpenAIResponse = vi.fn().mockRejectedValue(null);
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.ok).toBe(false);
+    expect(typeof result.error).toBe("string");
+  });
+
+  it("returns structured result when loadConfig throws non-Error", async () => {
+    const loadConfig = vi.fn(() => { throw "string error"; });
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.ok).toBe(false);
+    expect(typeof result.error).toBe("string");
+  });
+});
+
+// --- Warning propagation ---
+
+describe("warning propagation", () => {
+  it("includes budget warnings in success result when budget passes with warnings", async () => {
+    const trimmedBudget = { ...mockConfig, maxInputChars: 50 };
+    const loadConfig = vi.fn(() => trimmedBudget);
+    const createOpenAIClient = vi.fn(() => ({ responses: { create: vi.fn() } }));
+    const sendOpenAIResponse = vi.fn(async () => ({ content: "OK" }));
+
+    // question("hi") + context ~49 chars should hit the budget trim.
+    const result = await handleAskChatGpt(
+      { question: "hi", context: "x".repeat(49) },
+      { loadConfig, createOpenAIClient, sendOpenAIResponse },
+    );
+
+    expect(result.ok).toBe(true);
+    expect(Array.isArray(result.warnings)).toBe(true);
+  });
+
+  it("includes budget warnings in failure result when budget fails", async () => {
+    const emptyBudget = { ...mockConfig, maxInputChars: 0 };
+    const loadConfig = vi.fn(() => emptyBudget);
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(result.ok).toBe(false);
+    expect(Array.isArray(result.warnings)).toBe(true);
+  });
+});
+
+// --- Result shape ---
+
+describe("result shape", () => {
+  it("returns exactly { ok, answer, warnings } on success", async () => {
+    const loadConfig = vi.fn(() => mockConfig);
+    const createOpenAIClient = vi.fn(() => ({ responses: { create: vi.fn() } }));
+    const sendOpenAIResponse = vi.fn(async () => ({ content: "OK" }));
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(Object.keys(result).sort()).toEqual(["answer", "ok", "warnings"]);
+    expect(result.ok).toBe(true);
+    expect(typeof result.answer).toBe("string");
+    expect(Array.isArray(result.warnings)).toBe(true);
+  });
+
+  it("returns exactly { ok, error, warnings } on failure", async () => {
+    const loadConfig = vi.fn(() => { throw new Error("fail"); });
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    const result = await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(Object.keys(result).sort()).toEqual(["error", "ok", "warnings"]);
+    expect(result.ok).toBe(false);
+    expect(typeof result.error).toBe("string");
+    expect(Array.isArray(result.warnings)).toBe(true);
+  });
+});
+
+// --- Short-circuit behavior ---
+
+describe("short-circuit behavior", () => {
+  it("stops at first failure without calling downstream deps", async () => {
+    const loadConfig = vi.fn(() => mockConfig);
+    const createOpenAIClient = vi.fn(() => ({ responses: { create: vi.fn() } }));
+    const sendOpenAIResponse = vi.fn().mockRejectedValue(new Error("boom"));
+
+    await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(loadConfig).toHaveBeenCalledTimes(1);
+    expect(createOpenAIClient).toHaveBeenCalledTimes(1);
+    expect(sendOpenAIResponse).toHaveBeenCalledTimes(1);
+  });
+
+  it("stops at config failure without calling downstream deps", async () => {
+    const loadConfig = vi.fn(() => { throw new Error("fail"); });
+    const createOpenAIClient = vi.fn();
+    const sendOpenAIResponse = vi.fn();
+
+    await handleAskChatGpt(makeValidInput("hi"), { loadConfig, createOpenAIClient, sendOpenAIResponse });
+    expect(loadConfig).toHaveBeenCalledTimes(1);
+    expect(createOpenAIClient).not.toHaveBeenCalled();
+    expect(sendOpenAIResponse).not.toHaveBeenCalled();
+  });
+});