robbond/confidence-engine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(confidence-engine): restore finding controls on reopen

Browse Source
This commit is contained in:
robbond
2026-08-28 13:25:24 +01:00
parent 06f3f501d2
commit a8539e2494
3 changed files with 182 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/current-handoff.md
+3 -3
View File
@@ -1078,9 +1078,9 @@ After returning to the restored investigation and manually reopening the previou
This differs from the live current-turn focused surface where canonical Findings display those controls.
**REOPENED CANONICAL FINDING CONTROLS — UNRESOLVED**
**REOPENED CANONICAL FINDING CONTROLS — REPAIRED (v0.49)**
Leading hypothesis (unproved): the reopened/restored rendering path may be presenting Contribution-derived observation text or another historical representation instead of the same canonical Finding objects used by the live current-turn path. **This is NOT YET PROVED.**
Repaired `currentFindings` derivation in reasoning-workspace.jsx (lines 1382–1420): when `correlationId` is absent on cold reopen, the repair identifies the persisted Contribution belonging to the currently displayed focused turn/thread and uses `Finding.contributionId === Contribution.id` to recover the canonical Finding objects. correlationId is not required for cold reopen. Deterministic tests pass (70/70). Live Playwright verification deferred — see next constraint note.
---
@@ -1110,7 +1110,7 @@ The new manual observations are **presentation/lifecycle issues downstream of pe
| Cold-return can land on underlying surface rather than focused overlay | MANUALLY OBSERVED — unproven presentation/lifecycle gap |
| Saved-state banner + already-restored investigation signal | MANUALLY OBSERVED — semantic oddity of workspace state |
| Reopened Finding proposition survives | PROVED (text persists) |
| Reopened Not quite / not relevant controls absent | UNRESOLVED — hypothesis noted, root cause unproved |
| Reopened Not quite / not relevant controls absent | REPAIRED — Contribution.id → contributionId path verified; correlationId no longer required for cold reopen |
### NEXT BOUNDARY — REOPENED FOCUSED FINDING PRESENTATION / RESTORE WORKSPACE OWNERSHIP