fix(confidence-engine): sanitize focused reasoning outage
This commit is contained in:
@@ -144,9 +144,15 @@ async function post(request) {
|
||||
});
|
||||
console.info("[api/focused-investigation/deconstruct] end", {
|
||||
targetNodeId,
|
||||
status: 500,
|
||||
status: e?.code === "PROVIDER_UNAVAILABLE" ? 503 : 500,
|
||||
elapsedMs,
|
||||
});
|
||||
if (e?.code === "PROVIDER_UNAVAILABLE") {
|
||||
return Response.json(
|
||||
{ error: "Reasoning service is temporarily unavailable." },
|
||||
{ status: 503 },
|
||||
);
|
||||
}
|
||||
return Response.json(
|
||||
{ error: e.message || "Unknown server error" },
|
||||
{ status: 500 },
|
||||
|
||||
@@ -3,6 +3,12 @@
|
||||
> **Role:** Concise operational snapshot for resuming work today. Not a historical diary.
|
||||
> The design evolution archive index at `docs/design-evolution/README.md` provides progressive loading of experiment history; load the relevant chapter only when a specific historical question requires it.
|
||||
|
||||
## Focused-investigation provider outage boundary
|
||||
|
||||
- Focused-investigation outage handling now sanitizes provider failure at the API boundary: unavailable focused reasoning returns a controlled HTTP 503, and raw provider/Ollama diagnostics no longer leave that boundary.
|
||||
- The existing generic Retry UX remains unchanged. A live deployed outage had already proven investigation preservation.
|
||||
- `/api/cases/start` and `/api/cases/update` outage sanitization remain separately unverified; this change does not claim those routes are fixed.
|
||||
|
||||
## v0.62d production Docker packaging — LIVE PROVEN
|
||||
|
||||
- `Dockerfile` — minimal multi-stage Alpine build (Node 22), Next.js standalone output mode
|
||||
|
||||
@@ -1,5 +1,11 @@
|
||||
# Current Project State — Confidence Engine
|
||||
|
||||
## Focused-Investigation Provider Outage Boundary
|
||||
|
||||
- Focused-investigation outage handling now sanitizes provider failure at the API boundary: unavailable focused reasoning returns a controlled HTTP 503, and raw provider/Ollama diagnostics no longer leave that boundary.
|
||||
- The existing generic Retry UX remains unchanged. A live deployed outage had already proven investigation preservation.
|
||||
- `/api/cases/start` and `/api/cases/update` outage sanitization remain separately unverified; this change does not claim those routes are fixed.
|
||||
|
||||
## v0.62d Production Docker Packaging — LIVE PROVEN
|
||||
|
||||
- `Dockerfile` created: multi-stage Alpine build (Node 22), Next.js standalone output, configurable port 3000, health-check boundary via `/api/health`
|
||||
|
||||
@@ -439,6 +439,9 @@ class OllamaLlmProvider {
|
||||
`- Use a smaller model (e.g., llama3.1 instead of llama3.1:70b)\n` +
|
||||
`- Check Ollama logs: \`ollama serve\` or look at your system logs`
|
||||
);
|
||||
if (e?.name === "AbortError" || e instanceof TypeError) {
|
||||
error.code = "PROVIDER_UNAVAILABLE";
|
||||
}
|
||||
error.providerApiPath = apiUsed;
|
||||
error.providerExecution = providerExecution;
|
||||
throw error;
|
||||
|
||||
@@ -9,6 +9,10 @@
|
||||
import { afterEach, beforeEach, describe, it, expect, vi } from "vitest";
|
||||
import { focusedDeconstructJsonSchema, validateFocusedDeconstructSchema } from "@/lib/graph/focused-investigation";
|
||||
|
||||
vi.mock("@/lib/supabase/api-auth.js", () => ({
|
||||
withAuthenticatedApi: (handler) => handler,
|
||||
}));
|
||||
|
||||
// ── helpers ──────────────────────────────────────────────────────────────
|
||||
|
||||
function makeMockProvider(inventedTargetNodeId) {
|
||||
@@ -389,6 +393,36 @@ describe("focused-deconstruct targetNodeId identity boundary", () => {
|
||||
}
|
||||
});
|
||||
|
||||
it("returns a sanitized 503 when the provider is unavailable", async () => {
|
||||
const errorSpy = vi.spyOn(console, "error").mockImplementation(() => {});
|
||||
vi.doMock("@/lib/llm/provider", () => ({
|
||||
getProvider: () => ({
|
||||
generateReconstruction: vi.fn().mockRejectedValue(Object.assign(new Error(
|
||||
"Ollama /api/generate request timed out after 5 minutes",
|
||||
), { code: "PROVIDER_UNAVAILABLE", providerApiPath: "/api/generate" })),
|
||||
}),
|
||||
getProviderModelName: () => "configured-model",
|
||||
}));
|
||||
const { POST } = await import("../app/api/focused-investigation/deconstruct/route.js");
|
||||
|
||||
try {
|
||||
const response = await POST(new Request("http://localhost/api/focused-investigation/deconstruct", {
|
||||
method: "POST",
|
||||
headers: { "Content-Type": "application/json" },
|
||||
body: JSON.stringify({
|
||||
targetNodeId: "node-id", targetLabel: "label", targetDescription: "description",
|
||||
centralStatement: "central", question: "question?", answer: "answer.",
|
||||
}),
|
||||
}));
|
||||
expect(response.status).toBe(503);
|
||||
const json = await response.json();
|
||||
expect(json).toEqual({ error: "Reasoning service is temporarily unavailable." });
|
||||
expect(JSON.stringify(json)).not.toMatch(/ollama|generate|timed out/i);
|
||||
} finally {
|
||||
errorSpy.mockRestore();
|
||||
}
|
||||
});
|
||||
|
||||
it("preserves the 502 validation-failure contract with diagnostics", async () => {
|
||||
vi.doMock("@/lib/llm/provider", () => ({
|
||||
getProvider: () => ({
|
||||
|
||||
Reference in New Issue
Block a user