Feature/product platform foundation v0.62 #1
@@ -2350,3 +2350,66 @@ vitest.config.js change classification: **A** — intentional and necessary (add
|
||||
### Build
|
||||
|
||||
- Result: PASS
|
||||
|
||||
## v0.49 — FOCUSED WORKSPACE CONTROLS RECOVERY / SIMPLIFICATION
|
||||
|
||||
### Recovery classification
|
||||
|
||||
STATE-E — increment already fully completed and committed in 16cab46.
|
||||
|
||||
Previous session commit: `fix(confidence-engine): workspace control cleanup — rename close button, remove 'Back to open questions' from navigation` (16cab46).
|
||||
|
||||
Tracked tree at start: CLEAN. No recovery action needed.
|
||||
|
||||
### Control ownership classification
|
||||
|
||||
#### Close control (top-right)
|
||||
|
||||
**Current semantics before increment:** Labeled "Close investigation". Handler cleared `focusedAnswer`, cleared `focusedPresentationItemId`, and set `isFocusedWorkspaceOpen` to false. Pure overlay-close / navigation-only action. No Done-for-now, no summary/promotion, no API/LLM call.
|
||||
|
||||
**Action taken:** Renamed label + aria-label from `"Close investigation"` → `"Close workspace"`. Handler unchanged — pure presentation/navigation close only.
|
||||
|
||||
#### Back to open questions (bottom-left)
|
||||
|
||||
**Current semantics before increment:** Labeled "Back to open questions". Handler in `FocusedWorkspaceNavigation` cleared `focusedAnswer`, cleared `focusedPresentationItemId`. This was a sibling of the focused workspace overlay, not inside it — redundant with "Close investigation" close button. No distinct semantic value beyond re-opening Open Questions panel.
|
||||
|
||||
**Classification: CONTROL-A** — Back to open questions was redundant/broken navigation. Removed entirely.
|
||||
|
||||
#### Done for now (bottom-right)
|
||||
|
||||
**Current semantics:** Invokes `doneForNow` callback (semantic action). Button preserved unchanged — no modifications.
|
||||
|
||||
### Intended control semantics — implemented
|
||||
|
||||
**Top-right — Close workspace**
|
||||
- Label: `"Close workspace"`
|
||||
- Behaviour: Closes overlay, returns to Open Questions, preserves investigation history/activity
|
||||
- Does NOT invoke Done-for-now
|
||||
- Does NOT invoke summary/promotion
|
||||
- Does NOT make an LLM/API reasoning call
|
||||
|
||||
**Bottom-left — Removed**
|
||||
- "Back to open questions" removed as redundant navigation control (CONTROL-A)
|
||||
|
||||
**Bottom-right — Done for now**
|
||||
- Label and semantic handler preserved unchanged
|
||||
|
||||
### Implementation
|
||||
|
||||
Production file changed: `components/reasoning-workspace.jsx`
|
||||
|
||||
Changes:
|
||||
1. Renamed top-right close button label + aria-label: `"Close investigation"` → `"Close workspace"`.
|
||||
2. Preserved existing pure-close handler (setsFocusedAnswer/focusedPresentationItemId/isFocusedWorkspaceOpen).
|
||||
3. Removed "Back to open questions" button from `FocusedWorkspaceNavigation` and its `onBackToOpenQuestions` prop.
|
||||
4. Preserved "Done for now" button and its semantic `doneForNow` callback unchanged.
|
||||
|
||||
### Tests
|
||||
|
||||
- Command: `npx vitest run tests/open-questions-vs-assumptions.test.jsx`
|
||||
- Actual tests passed: **133** (up from 117 — 16 new control regression tests added)
|
||||
- New control regressions cover: close workspace label, back-to-open-questions absent, done-for-now preserved as distinct semantic action.
|
||||
|
||||
### Build
|
||||
|
||||
- Result: PASS
|
||||
|
||||
Reference in New Issue
Block a user