Refactor breadcrumbs to use factory-based route renderers

tests/phase22/breadcrumbs-route-map-structure.test.cjs

@@ -5,58 +5,75 @@ const path = require("path");
 const tests = [];
 const test = (name, fn) => tests.push({ name, fn });
 
-const loadBreadcrumbSource = () => {
-    const filePath = path.join(
-        __dirname,
-        "..",
-        "..",
-        "components",
-        "breadcrumbs.js"
-    );
+const loadSource = (...parts) => {
+    const filePath = path.join(__dirname, "..", "..", ...parts);
     return fs.readFileSync(filePath, "utf8");
 };
 
-test("breadcrumbs/simple-link-text map includes address and advanced search result routes", async () => {
-    const source = loadBreadcrumbSource();
+const loadBreadcrumbSource = () => loadSource("components", "breadcrumbs.js");
+
+const loadFactorySource = () =>
+    loadSource("lib", "routing", "breadcrumbRendererFactories.js");
+
+test("breadcrumbs/factory module includes expected mapped route definitions", async () => {
+    const source = loadFactorySource();
+
+    assert.strictEqual(
+        source.includes("export const createSimpleRouteRenderers ="),
+        true,
+        "Expected simple route renderer factory export"
+    );
+
+    assert.strictEqual(
+        source.includes("export const createSimpleLinkTextPairRenderers ="),
+        true,
+        "Expected link-text pair renderer factory export"
+    );
+
+    assert.strictEqual(
+        source.includes("export const createSimpleMyPortalRouteRenderers ="),
+        true,
+        "Expected my-portal route renderer factory export"
+    );
 
     assert.strictEqual(
         source.includes('"/addresssearchresults": () => ('),
         true,
-        "Expected /addresssearchresults to be mapped in getSimpleLinkTextPairRenderer"
+        "Expected /addresssearchresults to be mapped in createSimpleLinkTextPairRenderers"
     );
 
     assert.strictEqual(
         source.includes('"/advancedsearchresults": () => ('),
         true,
-        "Expected /advancedsearchresults to be mapped in getSimpleLinkTextPairRenderer"
+        "Expected /advancedsearchresults to be mapped in createSimpleLinkTextPairRenderers"
     );
 
     assert.strictEqual(
         source.includes('"/myportal/searchresults": () => ('),
         true,
-        "Expected /myportal/searchresults to be mapped in getSimpleMyPortalRouteRenderer"
+        "Expected /myportal/searchresults to be mapped in createSimpleMyPortalRouteRenderers"
     );
 
     assert.strictEqual(
         source.includes('"/myportal/viewall": () =>'),
         true,
-        "Expected /myportal/viewall to be mapped in getSimpleMyPortalRouteRenderer"
+        "Expected /myportal/viewall to be mapped in createSimpleMyPortalRouteRenderers"
     );
 
     assert.strictEqual(
         source.includes('"/myportal/advancedsearchresults": () => ('),
         true,
-        "Expected /myportal/advancedsearchresults to be mapped in getSimpleMyPortalRouteRenderer"
+        "Expected /myportal/advancedsearchresults to be mapped in createSimpleMyPortalRouteRenderers"
     );
 
     assert.strictEqual(
         source.includes('"/myportal/addresssearchresults": () => ('),
         true,
-        "Expected /myportal/addresssearchresults to be mapped in getSimpleMyPortalRouteRenderer"
+        "Expected /myportal/addresssearchresults to be mapped in createSimpleMyPortalRouteRenderers"
     );
 });
 
-test("breadcrumbs/merged resolver renders mapped routes through single helper invocation", async () => {
+test("breadcrumbs/component composes mapped routes via imported factories and shared resolver", async () => {
     const source = loadBreadcrumbSource();
 
     assert.strictEqual(
@@ -66,30 +83,80 @@ test("breadcrumbs/merged resolver renders mapped routes through single helper in
     );
 
     assert.strictEqual(
-        source.includes(
-            "const mappedRouteRendererMaps = buildBreadcrumbRendererMaps({"
+        source.includes('from "../lib/routing/breadcrumbRendererFactories"'),
+        true,
+        "Expected breadcrumbs to import breadcrumb renderer factories"
+    );
+
+    assert.strictEqual(
+        /createSimpleRouteRenderers/.test(source),
+        true,
+        "Expected breadcrumbs to reference createSimpleRouteRenderers"
+    );
+
+    assert.strictEqual(
+        /createSimpleLinkTextPairRenderers/.test(source),
+        true,
+        "Expected breadcrumbs to reference createSimpleLinkTextPairRenderers"
+    );
+
+    assert.strictEqual(
+        /createSimpleMyPortalRouteRenderers/.test(source),
+        true,
+        "Expected breadcrumbs to reference createSimpleMyPortalRouteRenderers"
+    );
+
+    assert.strictEqual(
+        /const\s+simpleRouteRenderersByPath\s*=\s*createSimpleRouteRenderers\s*\(/.test(
+            source
+        ),
+        true,
+        "Expected breadcrumbs to build simple route renderers from factory"
+    );
+
+    assert.strictEqual(
+        /const\s+simpleLinkTextPairRenderersByPath\s*=\s*createSimpleLinkTextPairRenderers\s*\(/.test(
+            source
+        ),
+        true,
+        "Expected breadcrumbs to build link-text pair renderers from factory"
+    );
+
+    assert.strictEqual(
+        /const\s+simpleMyPortalRouteRenderersByPath\s*=\s*createSimpleMyPortalRouteRenderers\s*\(/.test(
+            source
+        ),
+        true,
+        "Expected breadcrumbs to build my-portal route renderers from factory"
+    );
+
+    assert.strictEqual(
+        /const\s+mappedRouteRendererMaps\s*=\s*buildBreadcrumbRendererMaps\s*\(/.test(
+            source
         ),
         true,
         "Expected grouped mapped route renderer map composition to use helper builder"
     );
 
     assert.strictEqual(
-        source.includes(
-            "return resolveMappedRouteRendererByMaps(path, mappedRouteRendererMaps);"
+        /return\s+resolveMappedRouteRendererByMaps\s*\(\s*path\s*,\s*mappedRouteRendererMaps\s*\)/.test(
+            source
         ),
         true,
         "Expected resolver to delegate to shared route-map resolver helper"
     );
 
     assert.strictEqual(
-        source.includes("const resolveMappedRouteRenderer = (path) =>"),
+        /const\s+resolveMappedRouteRenderer\s*=\s*\(\s*path\s*\)\s*=>/.test(
+            source
+        ),
         true,
         "Expected unified mapped route resolver helper to exist"
     );
 
     assert.strictEqual(
-        source.includes(
-            "const renderMappedRoute = (path, resolver = resolveMappedRouteRenderer) =>"
+        /const\s+renderMappedRoute\s*=\s*\(\s*path\s*,\s*resolver\s*=\s*resolveMappedRouteRenderer\s*\)\s*=>/.test(
+            source
         ),
         true,
         "Expected reusable renderMappedRoute helper to exist"
@@ -112,13 +179,24 @@ test("breadcrumbs/merged resolver renders mapped routes through single helper in
         false,
         "Expected /myportal/addresssearchresults explicit branch to be removed after mapping"
     );
+});
+
+test("breadcrumbs/map builder preserves route map ordering", async () => {
+    const source = loadBreadcrumbSource();
 
     const mapBuilderCallIndex = source.indexOf(
         "const mappedRouteRendererMaps = buildBreadcrumbRendererMaps({"
     );
+
+    assert.notStrictEqual(
+        mapBuilderCallIndex,
+        -1,
+        "Expected grouped map builder call to exist"
+    );
+
     const mapBuilderSlice = source.slice(
         mapBuilderCallIndex,
-        mapBuilderCallIndex + 300
+        mapBuilderCallIndex + 500
     );
 
     const simpleRouteOrderIndex = mapBuilderSlice.indexOf(