Stage 3: enforce blob deletion ownership and add admin representation deletion

Also repairs two stale Phase 21 fixtures:
- Supplies a valid PDF to exercise the upload dependency-failure path.
- Injects getPersonalAccount into the representation-involvement VM fixture.
This commit is contained in:
2026-10-26 14:39:22 +00:00
parent 848728584e
commit 0daeb783b9
6 changed files with 458 additions and 14 deletions
+302 -2
View File
@@ -1,4 +1,6 @@
const assert = require("assert");
const fs = require("fs");
const path = require("path");
const {
loadModule,
createRes,
@@ -171,6 +173,7 @@ test("deleteblobcase handler accepts encoded hash variant", async () => {
const mod = loadModule("pages/api/file/deleteblobcase.js", {
nextConnect: createNextConnectMock(),
middleware: () => {},
getSession: async () => ({ user: { id: "c1" } }),
hashAPIPath: (queryPath) =>
queryPath.includes("casefolderID=CASE%2FSUB")
? "&hash=expected"
@@ -201,6 +204,7 @@ test("deleteblobcase handler dependency failure returns DELETE_BLOB_CASE_FAILED"
const mod = loadModule("pages/api/file/deleteblobcase.js", {
nextConnect: createNextConnectMock(),
middleware: () => {},
getSession: async () => ({ user: { id: "c1" } }),
hashAPIPath: () => "&hash=expected",
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
@@ -231,6 +235,7 @@ test("deleteblobrep handler accepts encoded hash variant", async () => {
const mod = loadModule("pages/api/file/deleteblobrep.js", {
nextConnect: createNextConnectMock(),
middleware: () => {},
getSession: async () => ({ user: { id: "c1" } }),
hashAPIPath: (queryPath) =>
queryPath.includes("repfile=Rep%20Name")
? "&hash=expected"
@@ -262,6 +267,7 @@ test("deleteblobrep handler dependency failure returns DELETE_BLOB_REP_FAILED",
const mod = loadModule("pages/api/file/deleteblobrep.js", {
nextConnect: createNextConnectMock(),
middleware: () => {},
getSession: async () => ({ user: { id: "c1" } }),
hashAPIPath: () => "&hash=expected",
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
@@ -285,6 +291,288 @@ test("deleteblobrep handler dependency failure returns DELETE_BLOB_REP_FAILED",
assert.strictEqual(res.state.jsonBody.error.code, "DELETE_BLOB_REP_FAILED");
});
const ordinaryDeletionCases = [
{
name: "deleteblobcase",
route: "pages/api/file/deleteblobcase.js",
query: {
container: "user-container",
casefolderID: "CASE-1",
hash: "expected"
},
dependency: "deleteBlobCase"
},
{
name: "deleteblobrep",
route: "pages/api/file/deleteblobrep.js",
query: {
container: "user-container",
casefolderID: "CASE-1",
repfile: "representation.json",
hash: "expected"
},
dependency: "deleteBlobRep"
}
];
for (const deletionCase of ordinaryDeletionCases) {
test(`${deletionCase.name} forbids a missing NextAuth session before deletion`, async () => {
let deletionCalls = 0;
const mod = loadModule(deletionCase.route, {
nextConnect: createNextConnectMock(),
middleware: () => {},
getSession: async () => null,
hashAPIPath: () => "&hash=expected",
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
[deletionCase.dependency]: async () => {
deletionCalls += 1;
}
});
const res = createRes();
await mod.default.handler({ query: deletionCase.query }, res);
assert.strictEqual(res.state.statusCode, 403);
assert.strictEqual(res.state.jsonBody.error.code, "FORBIDDEN");
assert.strictEqual(deletionCalls, 0);
});
test(`${deletionCase.name} forbids a session without user id before deletion`, async () => {
let deletionCalls = 0;
const mod = loadModule(deletionCase.route, {
nextConnect: createNextConnectMock(),
middleware: () => {},
getSession: async () => ({ user: {} }),
hashAPIPath: () => "&hash=expected",
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
[deletionCase.dependency]: async () => {
deletionCalls += 1;
}
});
const res = createRes();
await mod.default.handler({ query: deletionCase.query }, res);
assert.strictEqual(res.state.statusCode, 403);
assert.strictEqual(deletionCalls, 0);
});
test(`${deletionCase.name} forbids cross-container deletion before HMAC or Azure deletion`, async () => {
let hashCalls = 0;
let deletionCalls = 0;
const mod = loadModule(deletionCase.route, {
nextConnect: createNextConnectMock(),
middleware: () => {},
getSession: async () => ({ user: { id: "different-user" } }),
hashAPIPath: () => {
hashCalls += 1;
return "&hash=expected";
},
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
[deletionCase.dependency]: async () => {
deletionCalls += 1;
}
});
const res = createRes();
await mod.default.handler({ query: deletionCase.query }, res);
assert.strictEqual(res.state.statusCode, 403);
assert.strictEqual(hashCalls, 0);
assert.strictEqual(deletionCalls, 0);
});
test(`${deletionCase.name} rejects invalid HMAC for the owning user without deletion`, async () => {
let deletionCalls = 0;
const mod = loadModule(deletionCase.route, {
nextConnect: createNextConnectMock(),
middleware: () => {},
getSession: async () => ({ user: { id: "user-container" } }),
hashAPIPath: () => "&hash=different",
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
[deletionCase.dependency]: async () => {
deletionCalls += 1;
}
});
const res = createRes();
await mod.default.handler({ query: deletionCase.query }, res);
assert.strictEqual(res.state.statusCode, 400);
assert.strictEqual(res.state.jsonBody.error.code, "INVALID_HASH");
assert.strictEqual(deletionCalls, 0);
});
test(`${deletionCase.name} preserves valid same-user deletion`, async () => {
const deletionCalls = [];
const mod = loadModule(deletionCase.route, {
nextConnect: createNextConnectMock(),
middleware: () => {},
getSession: async () => ({ user: { id: "user-container" } }),
hashAPIPath: () => "&hash=expected",
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
[deletionCase.dependency]: async (...args) => {
deletionCalls.push(args);
return { deleted: true };
}
});
const res = createRes();
await mod.default.handler({ query: deletionCase.query }, res);
assert.strictEqual(res.state.statusCode, 200);
assert.strictEqual(deletionCalls.length, 1);
assert.strictEqual(deletionCalls[0][0], "user-container");
});
}
const loadAdminDeletion = (overrides = {}) => {
let deletionCalls = 0;
const mod = loadModule("pages/api/admin/deleteblobrep.js", {
deleteBlobRep: async () => {
deletionCalls += 1;
return { deleted: true };
},
readAdminSessionCookie: () => "admin-token",
validateAdminSession: () => true,
hasTrustedSameOrigin: () => true,
setAdminAuthNoStore: () => {},
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
...overrides
});
return { mod, getDeletionCalls: () => deletionCalls };
};
const validAdminDeletionRequest = () => ({
method: "POST",
headers: { origin: "https://portal.example.test" },
body: {
container: "ck-user-container",
casefolderID: "CASE-1",
repfile: "representation.json"
}
});
test("admin representation deletion forbids a missing administrative session", async () => {
const loaded = loadAdminDeletion({
readAdminSessionCookie: () => null,
validateAdminSession: () => false
});
const res = createRes();
await loaded.mod.default(validAdminDeletionRequest(), res);
assert.strictEqual(res.state.statusCode, 403);
assert.strictEqual(res.state.jsonBody.error.code, "FORBIDDEN");
assert.strictEqual(loaded.getDeletionCalls(), 0);
});
test("admin representation deletion forbids an invalid or expired administrative session", async () => {
const loaded = loadAdminDeletion({ validateAdminSession: () => false });
const res = createRes();
await loaded.mod.default(validAdminDeletionRequest(), res);
assert.strictEqual(res.state.statusCode, 403);
assert.strictEqual(loaded.getDeletionCalls(), 0);
});
for (const originCase of ["missing", "cross-origin"]) {
test(`admin representation deletion forbids ${originCase} Origin`, async () => {
const loaded = loadAdminDeletion({ hasTrustedSameOrigin: () => false });
const req = validAdminDeletionRequest();
if (originCase === "missing") delete req.headers.origin;
if (originCase === "cross-origin") {
req.headers.origin = "https://attacker.example";
}
const res = createRes();
await loaded.mod.default(req, res);
assert.strictEqual(res.state.statusCode, 403);
assert.strictEqual(loaded.getDeletionCalls(), 0);
});
}
test("ordinary user HMAC cannot authorize administrative representation deletion", async () => {
const loaded = loadAdminDeletion({
readAdminSessionCookie: () => null,
validateAdminSession: () => false
});
const req = validAdminDeletionRequest();
req.body.hash = "ordinary-user-hmac";
const res = createRes();
await loaded.mod.default(req, res);
assert.strictEqual(res.state.statusCode, 403);
assert.strictEqual(loaded.getDeletionCalls(), 0);
});
test("admin representation deletion rejects malformed paths without deletion", async () => {
for (const malformedBody of [
{ casefolderID: "../CASE-1" },
{ repfile: "folder/representation.json" },
{ repfile: ".." }
]) {
const loaded = loadAdminDeletion();
const req = validAdminDeletionRequest();
req.body = { ...req.body, ...malformedBody };
const res = createRes();
await loaded.mod.default(req, res);
assert.strictEqual(res.state.statusCode, 400);
assert.strictEqual(res.state.jsonBody.error.code, "INVALID_REQUEST");
assert.strictEqual(loaded.getDeletionCalls(), 0);
}
});
test("valid administrative session and origin authorize cross-container representation deletion", async () => {
const deletionCalls = [];
const loaded = loadAdminDeletion({
deleteBlobRep: async (...args) => {
deletionCalls.push(args);
return { deleted: args[1] };
}
});
const res = createRes();
await loaded.mod.default(validAdminDeletionRequest(), res);
assert.strictEqual(res.state.statusCode, 200);
assert.deepStrictEqual(JSON.parse(JSON.stringify(deletionCalls)), [
["ck-user-container", "CASE-1/representation.json"]
]);
});
test("admin storage caller uses dedicated POST deletion while ordinary caller remains signed GET", () => {
const rootDir = path.resolve(__dirname, "..", "..");
const adminSource = fs.readFileSync(
path.join(rootDir, "components/admin/tabs/storage.js"),
"utf8"
);
const ordinarySource = fs.readFileSync(
path.join(rootDir, "actions/services/documentDirectService.js"),
"utf8"
);
assert.match(adminSource, /fetch\("\/api\/admin\/deleteblobrep"/);
assert.match(adminSource, /method:\s*"POST"/);
assert.doesNotMatch(adminSource, /deleteMyRepresentationsFromBlob/);
assert.match(
ordinarySource,
/buildFileQuery\("\/api\/file\/deleteblobrep"[\s\S]*getSignedFileJson\(queryUrl\)/
);
});
test("deleteawaitingsubmissionfromblob accepts legacy deleteblob hash variant", async () => {
let deletedPath = null;
const mod = loadModule(
@@ -467,13 +755,24 @@ test("uploadsinglefile handler dependency failure returns UPLOAD_SINGLE_FILE_FAI
throw new Error("upload failed");
},
fileTypeFromBuffer: async () => ({ mime: "application/pdf" }),
fs: { readFileSync: () => Buffer.from("x") }
fs: { readFileSync: () => Buffer.from("x") },
path: { basename: (value) => value }
});
const req = {
query: { hash: "expected" },
body: { containerID: ["c1"], casefolderID: ["f1"] },
files: {}
files: {
document: [
{
fieldName: "document.pdf",
originalFilename: "document.pdf",
path: "/tmp/document.pdf",
size: 1,
headers: { "content-type": "application/pdf" }
}
]
}
};
const res = createRes();
await mod.default.handler(req, res);
@@ -820,6 +1119,7 @@ test("createrepinvolvement dependency failure returns CREATE_REP_INVOLVEMENT_FAI
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
getToken: async () => ({ access_token: "tok" }),
getPersonalAccount: async () => ({}),
hashAPIPath: () => "?hash=abc",
consoleLogger: () => {},
process: {