Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change)

## Summary

This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.

This refactor was executed in controlled slices with regression validation at each step.

## Scope

Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)

## Behaviour

No intended behavioural changes.

The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity

## Validation

Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity

Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)

## Risk

Low:
- changes are structural only
- no business logic changes
- no contract changes

## Rollback

Safe rollback via reverting this merge commit.

## Notes

This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.

Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590

lib/newappeal/journeyEffects.js

@@ -0,0 +1,61 @@
+import { uploadFiles } from "../../actions/services/documentService";
+import { sendEmail } from "../../actions/services/notifyService";
+import { sendCaseCompleteMessage } from "../../actions/services/portalService";
+import { generateAppealPDF } from "../../actions/services/documentService";
+
+export const uploadAppealFilesEffect = (
+    dataObj,
+    fileListObj,
+    containerID,
+    caseReference
+) => {
+    return uploadFiles(dataObj, fileListObj, containerID, caseReference);
+};
+
+export const sendPartialSaveEmailEffect = (
+    templateId,
+    emailAddress,
+    personalisation,
+    reference
+) => {
+    return sendEmail(templateId, emailAddress, personalisation, reference);
+};
+
+export const sendCompletionEmailEffect = (
+    templateId,
+    emailAddress,
+    personalisation,
+    reference
+) => {
+    return sendEmail(templateId, emailAddress, personalisation, reference);
+};
+
+export const generateAppealPDFEffect = (
+    pdfObj,
+    containerID,
+    caseReference,
+    appealType,
+    filesList,
+    options
+) => {
+    return generateAppealPDF(
+        pdfObj,
+        containerID,
+        caseReference,
+        appealType,
+        filesList,
+        options
+    );
+};
+
+export const sendCaseCompleteMessageEffect = (
+    containerID,
+    caseReference,
+    typeOfInvolvement
+) => {
+    return sendCaseCompleteMessage(
+        containerID,
+        caseReference,
+        typeOfInvolvement
+    );
+};