test(portal): add phase22 behavioural closure and route harmonization

2026-03-25 12:04:11 +00:00
parent 6b66ad6d8f
commit 10f221af38
4 changed files with 204 additions and 3 deletions
@@ -2,12 +2,14 @@ const runCoreTokenTests = require("./core-token-behaviour.test.cjs");
 const runClientUtilsTests = require("./client-utils-behaviour.test.cjs");
 const runFileClientTests = require("./file-client-behaviour.test.cjs");
 const runCaseServiceTests = require("./case-service-behaviour.test.cjs");
+const runPortalServiceTests = require("./portal-service-behaviour.test.cjs");

 const run = async () => {
    await runCoreTokenTests();
    await runClientUtilsTests();
    await runFileClientTests();
    await runCaseServiceTests();
+    await runPortalServiceTests();
    console.log("Phase 22 combined suite passed.");
 };

@@ -0,0 +1,157 @@
+const assert = require("assert");
+const {
+    createAxiosMock,
+    createLoggerMock,
+    createAxiosError,
+    loadServiceModule,
+    normalize
+} = require("../serviceHarness.cjs");
+
+const tests = [];
+const test = (name, fn) => tests.push({ name, fn });
+
+test("portal/sendCaseCompleteMessage appends signed hash suffix to inv query", async () => {
+    const axios = createAxiosMock();
+    const logger = createLoggerMock();
+
+    const requestCalls = [];
+    const requestJson = async (config) => {
+        requestCalls.push(config);
+        return { status: "ok" };
+    };
+
+    const portal = loadServiceModule("portalDirectService.js", {
+        axios,
+        BASE_URL: "",
+        consoleLogger: logger.consoleLogger,
+        buildHashedQueryUrl: async (queryUrl) => `${queryUrl}&hash=abc123`,
+        requestJson
+    });
+
+    const result = await portal.sendCaseCompleteMessage(
+        "container1",
+        "CASE-1",
+        "yes"
+    );
+
+    assert.deepStrictEqual(normalize(result), { status: "ok" });
+    assert.strictEqual(requestCalls.length, 1);
+    assert.strictEqual(requestCalls[0].method, "get");
+    assert.strictEqual(
+        requestCalls[0].url,
+        "/api/file/createappealcompletemessage_api?container=container1&tempcaseref=CASE-1&inv=yes&hash=abc123"
+    );
+});
+
+test("portal/deleteMyRepresentations uses signed delete request with headers", async () => {
+    const axios = createAxiosMock();
+    const logger = createLoggerMock();
+
+    const requestCalls = [];
+    const requestJson = async (config) => {
+        requestCalls.push(config);
+        return { deleted: true };
+    };
+
+    const portal = loadServiceModule("portalDirectService.js", {
+        axios,
+        BASE_URL: "",
+        consoleLogger: logger.consoleLogger,
+        buildHashedQueryUrl: async (queryUrl) => `${queryUrl}&hash=xyz`,
+        requestJson
+    });
+
+    const result = await portal.deleteMyRepresentations("rep-1");
+
+    assert.deepStrictEqual(normalize(result), { deleted: true });
+    assert.strictEqual(requestCalls.length, 1);
+    assert.strictEqual(requestCalls[0].method, "delete");
+    assert.strictEqual(
+        requestCalls[0].url,
+        "/api/endpoint/deletemyrepresentations_api?myRepresentationsID=rep-1&hash=xyz"
+    );
+    assert.strictEqual(
+        requestCalls[0].headers["Content-Type"],
+        "application/json"
+    );
+});
+
+test("portal/createWatchedCases posts to harmonized route helper URL", async () => {
+    const axios = createAxiosMock();
+    const logger = createLoggerMock();
+
+    const requestCalls = [];
+    const requestJson = async (config) => {
+        requestCalls.push(config);
+        return { created: true };
+    };
+
+    const portal = loadServiceModule("portalDirectService.js", {
+        axios,
+        BASE_URL: "",
+        consoleLogger: logger.consoleLogger,
+        requestJson
+    });
+
+    const payload = { foo: "bar" };
+    const result = await portal.createWatchedCases(payload);
+
+    assert.deepStrictEqual(normalize(result), { created: true });
+    assert.strictEqual(requestCalls.length, 1);
+    assert.strictEqual(requestCalls[0].method, "post");
+    assert.strictEqual(
+        requestCalls[0].url,
+        "/api/endpoint/createwatchedcases_api"
+    );
+    assert.deepStrictEqual(normalize(requestCalls[0].data), payload);
+});
+
+test("portal/sendRepCompleteMessage rejects when hash signing fails before request stage", async () => {
+    const axios = createAxiosMock();
+    const logger = createLoggerMock();
+    const error = createAxiosError(500, "Failed");
+
+    const portal = loadServiceModule("portalDirectService.js", {
+        axios,
+        BASE_URL: "",
+        consoleLogger: logger.consoleLogger,
+        buildHashedQueryUrl: async () => {
+            throw error;
+        },
+        requestJson: async () => {
+            throw new Error("should not be called");
+        }
+    });
+
+    await assert.rejects(
+        () => portal.sendRepCompleteMessage("c", "r", "f"),
+        (caught) => {
+            assert.strictEqual(caught, error);
+            return true;
+        }
+    );
+
+    assert.strictEqual(logger.calls.length, 0);
+});
+
+const run = async () => {
+    let passed = 0;
+
+    for (const currentTest of tests) {
+        await currentTest.fn();
+        passed += 1;
+    }
+
+    console.log(
+        `Phase 22 portal-service tests passed (${passed}/${tests.length}).`
+    );
+};
+
+module.exports = run;
+
+if (require.main === module) {
+    run().catch((error) => {
+        console.error(error);
+        process.exit(1);
+    });
+}