TASK22168 bundle C endpoint login/account consistency extension

pages/api/endpoint/getportallogin_api.js

@@ -17,50 +17,65 @@
  */
 
 import axios from "axios";
-import CryptoJS from "crypto-js";
 import { azureHeadersPaged } from "../../../actions/core/headers";
 import { consoleLogger } from "../../../actions/core/logger";
 import { getToken } from "../../../actions/core/token";
 import { hashAPIPath } from "../../../actions/core/hash";
+import { respondError, respondSuccess } from "../middleware/apiResponse";
 
 const WEBAPI_URL =
     process.env.RELAY_ROOT ||
     "https://dev-pedw-ns.servicebus.windows.net/dev-pedw-hc/";
 
 export default async function ApiProxy(req, res) {
-    var emailAddress = req.query.emailAddress;
-    var checkHash = req.query.hash;
+    const emailAddress = req.query.emailAddress;
+    const checkHash = req.query.hash;
 
-    if (typeof emailAddress == "undefined" || emailAddress.length === 0) {
-        return res.status(400).json();
+    if (typeof emailAddress !== "string" || emailAddress.trim().length === 0) {
+        return respondError(res, {
+            status: 400,
+            code: "EMAIL_ADDRESS_REQUIRED",
+            message: "emailAddress is required"
+        });
     }
 
-    var checkquerypath =
+    if (typeof checkHash !== "string" || checkHash.length === 0) {
+        return respondError(res, {
+            status: 400,
+            code: "HASH_REQUIRED",
+            message: "hash is required"
+        });
+    }
+
+    const checkquerypath =
         "/api/endpoint/getportallogin_api?emailAddress=" + emailAddress;
 
     if (hashAPIPath(checkquerypath) != "&hash=" + checkHash) {
-        return res.status(400).json();
+        return respondError(res, {
+            status: 400,
+            code: "INVALID_HASH",
+            message: "Invalid hash"
+        });
     }
 
-    var token = await getToken();
-
-    var queryUrl =
-        "contacts?$filter=emailaddress1 eq '" +
-        emailAddress +
-        "' and statuscode eq 1&$count=true&$select=emailaddress1,contactid,yomifullname,firstname,lastname";
-
-    var apiResponse = axios
-        .get(
+    try {
+        const token = await getToken();
+        const queryUrl =
+            "contacts?$filter=emailaddress1 eq '" +
+            emailAddress +
+            "' and statuscode eq 1&$count=true&$select=emailaddress1,contactid,yomifullname,firstname,lastname";
+        const { data } = await axios.get(
             WEBAPI_URL + queryUrl + hashAPIPath(queryUrl),
             azureHeadersPaged(token.access_token)
-        )
-        .then(({ data }) => {
-            res.status(200).json(data);
-        })
-        .catch((error) => {
-            consoleLogger(error);
-            res.status(400).json(error);
-        });
+        );
 
-    return apiResponse;
+        return respondSuccess(res, data);
+    } catch (error) {
+        consoleLogger(error);
+        return respondError(res, {
+            status: 400,
+            code: "PORTAL_LOGIN_FETCH_FAILED",
+            message: "Failed to fetch portal login"
+        });
+    }
 }