fix(security): enforce ownership across appeal completion

This commit is contained in:
2026-11-04 14:20:11 +00:00
parent f8245861b7
commit 4829c49c7b
4 changed files with 791 additions and 13 deletions
+68 -2
View File
@@ -1,12 +1,25 @@
import { hashAPIPath } from "../../../actions/core/hash";
import nextConnect from "next-connect";
import { getSession } from "next-auth/react";
import { getServerSession } from "next-auth/next";
import { authOptions } from "../auth/[...nextauth]";
import { respondError, respondSuccess } from "../middleware/apiResponse";
const ApiProxy = nextConnect();
const isValidContainer = (value) =>
typeof value === "string" &&
value.length >= 3 &&
value.length <= 63 &&
/^[a-z0-9](?:[a-z0-9-]*[a-z0-9])?$/.test(value);
const isValidTempCaseRef = (value) =>
typeof value === "string" &&
value.length <= 100 &&
!value.includes("..") &&
/^[A-Za-z0-9](?:[A-Za-z0-9/-]*[A-Za-z0-9])?$/.test(value);
ApiProxy.get(async (req, res) => {
const session = await getSession({ req });
const session = await getServerSession(req, res, authOptions(req, res));
if (!session) {
return respondError(res, {
@@ -51,6 +64,59 @@ ApiProxy.get(async (req, res) => {
});
}
if (
queryPath.startsWith("/api/file/createappealcompletemessage_api") &&
queryPath !== "/api/file/createappealcompletemessage_api"
) {
return respondError(res, {
status: 400,
code: "INVALID_HASH_PATH",
message: "Invalid path for hash generation"
});
}
if (queryPath === "/api/file/createappealcompletemessage_api") {
let completionPath;
try {
completionPath = new URL(rawQueryPath, "http://localhost");
} catch (_error) {
return respondError(res, {
status: 400,
code: "INVALID_HASH_PATH",
message: "Invalid path for hash generation"
});
}
const containerName = completionPath.searchParams.get("container");
const tempCaseRef = completionPath.searchParams.get("tempcaseref");
if (
!isValidContainer(containerName) ||
!isValidTempCaseRef(tempCaseRef) ||
completionPath.searchParams.getAll("container").length !== 1 ||
completionPath.searchParams.getAll("tempcaseref").length !== 1
) {
return respondError(res, {
status: 400,
code: "INVALID_HASH_PATH",
message: "Invalid path for hash generation"
});
}
if (
typeof session?.user?.id !== "string" ||
session.user.id.length === 0 ||
session.user.id !== containerName
) {
return respondError(res, {
status: 403,
code: "FORBIDDEN",
message: "Request not permitted"
});
}
}
return respondSuccess(res, { hash: hashAPIPath(rawQueryPath) });
});