fix(storage): constrain recursive blob deletion to resource folders
This commit is contained in:
@@ -338,7 +338,7 @@ test("deleteblob handler dependency failure returns DELETE_BLOB_FAILED", async (
|
||||
assert.strictEqual(res.state.jsonBody.error.code, "DELETE_BLOB_FAILED");
|
||||
});
|
||||
|
||||
test("deleteblobcase handler accepts encoded hash variant", async () => {
|
||||
test("deleteblobcase handler accepts a valid case folder", async () => {
|
||||
let deletedCaseFolder = null;
|
||||
const mod = loadModule("pages/api/file/deleteblobcase.js", {
|
||||
nextConnect: createNextConnectMock(),
|
||||
@@ -346,7 +346,7 @@ test("deleteblobcase handler accepts encoded hash variant", async () => {
|
||||
getServerSession: async () => ({ user: { id: "c1" } }),
|
||||
authOptions: () => ({}),
|
||||
hashAPIPath: (queryPath) =>
|
||||
queryPath.includes("casefolderID=CASE%2FSUB")
|
||||
queryPath.includes("casefolderID=CASE-SUB")
|
||||
? "&hash=expected"
|
||||
: "&hash=other",
|
||||
respondError: respondErrorMock,
|
||||
@@ -360,7 +360,7 @@ test("deleteblobcase handler accepts encoded hash variant", async () => {
|
||||
const req = {
|
||||
query: {
|
||||
container: "c1",
|
||||
casefolderID: "CASE/SUB",
|
||||
casefolderID: "CASE-SUB",
|
||||
hash: "expected"
|
||||
}
|
||||
};
|
||||
@@ -368,7 +368,41 @@ test("deleteblobcase handler accepts encoded hash variant", async () => {
|
||||
await mod.default.handler(req, res);
|
||||
|
||||
assert.strictEqual(res.state.statusCode, 200);
|
||||
assert.strictEqual(deletedCaseFolder, "CASE/SUB");
|
||||
assert.strictEqual(deletedCaseFolder, "CASE-SUB");
|
||||
});
|
||||
|
||||
test("deleteblobcase rejects unsafe normalized folder identifiers before deletion", async () => {
|
||||
for (const casefolderID of [" ", "CASE-1/REP-1", "..", "CASE\\REP"]) {
|
||||
let deletionCalls = 0;
|
||||
const mod = loadModule("pages/api/file/deleteblobcase.js", {
|
||||
nextConnect: createNextConnectMock(),
|
||||
middleware: () => {},
|
||||
getServerSession: async () => ({ user: { id: "c1" } }),
|
||||
authOptions: () => ({}),
|
||||
hashAPIPath: () => "&hash=expected",
|
||||
respondError: respondErrorMock,
|
||||
respondSuccess: respondSuccessMock,
|
||||
deleteBlobCase: async () => {
|
||||
deletionCalls += 1;
|
||||
}
|
||||
});
|
||||
const res = createRes();
|
||||
|
||||
await mod.default.handler(
|
||||
{
|
||||
query: {
|
||||
container: "c1",
|
||||
casefolderID,
|
||||
hash: "expected"
|
||||
}
|
||||
},
|
||||
res
|
||||
);
|
||||
|
||||
assert.strictEqual(res.state.statusCode, 400);
|
||||
assert.strictEqual(res.state.jsonBody.error.code, "INVALID_REQUEST");
|
||||
assert.strictEqual(deletionCalls, 0);
|
||||
}
|
||||
});
|
||||
|
||||
test("deleteblobcase handler dependency failure returns DELETE_BLOB_CASE_FAILED", async () => {
|
||||
@@ -436,6 +470,46 @@ test("deleteblobrep handler accepts encoded hash variant", async () => {
|
||||
assert.strictEqual(deletedRepPath, "CASE-1/Rep Name");
|
||||
});
|
||||
|
||||
test("deleteblobrep rejects missing or unsafe folder segments before deletion", async () => {
|
||||
for (const invalidQuery of [
|
||||
{ casefolderID: " ", repfile: "REP-1" },
|
||||
{ casefolderID: "CASE-1", repfile: " " },
|
||||
{ casefolderID: "CASE-1/REP-1", repfile: "REP-1" },
|
||||
{ casefolderID: "CASE-1", repfile: "REP-1/FILES" },
|
||||
{ casefolderID: "CASE-1", repfile: ".." }
|
||||
]) {
|
||||
let deletionCalls = 0;
|
||||
const mod = loadModule("pages/api/file/deleteblobrep.js", {
|
||||
nextConnect: createNextConnectMock(),
|
||||
middleware: () => {},
|
||||
getServerSession: async () => ({ user: { id: "c1" } }),
|
||||
authOptions: () => ({}),
|
||||
hashAPIPath: () => "&hash=expected",
|
||||
respondError: respondErrorMock,
|
||||
respondSuccess: respondSuccessMock,
|
||||
deleteBlobRep: async () => {
|
||||
deletionCalls += 1;
|
||||
}
|
||||
});
|
||||
const res = createRes();
|
||||
|
||||
await mod.default.handler(
|
||||
{
|
||||
query: {
|
||||
container: "c1",
|
||||
hash: "expected",
|
||||
...invalidQuery
|
||||
}
|
||||
},
|
||||
res
|
||||
);
|
||||
|
||||
assert.strictEqual(res.state.statusCode, 400);
|
||||
assert.strictEqual(res.state.jsonBody.error.code, "INVALID_REQUEST");
|
||||
assert.strictEqual(deletionCalls, 0);
|
||||
}
|
||||
});
|
||||
|
||||
test("deleteblobrep handler dependency failure returns DELETE_BLOB_REP_FAILED", async () => {
|
||||
const mod = loadModule("pages/api/file/deleteblobrep.js", {
|
||||
nextConnect: createNextConnectMock(),
|
||||
|
||||
Reference in New Issue
Block a user