22541 extract breadcrumb route-map helpers and add precedence guard tests

tests/phase22/breadcrumb-route-maps-helper.test.cjs

@@ -0,0 +1,69 @@
+const assert = require("assert");
+
+const {
+    buildBreadcrumbRendererMaps,
+    getMappedRendererByPath,
+    resolveMappedRouteRenderer
+} = require("../../lib/routing/breadcrumbRouteMaps");
+
+const tests = [];
+const test = (name, fn) => tests.push({ name, fn });
+
+test("breadcrumbRouteMaps/buildBreadcrumbRendererMaps preserves explicit map order", async () => {
+    const mapA = { "/a": () => "A" };
+    const mapB = { "/b": () => "B" };
+    const mapC = { "/c": () => "C" };
+
+    const result = buildBreadcrumbRendererMaps({
+        simpleRouteRenderersByPath: mapA,
+        simpleLinkTextPairRenderersByPath: mapB,
+        simpleMyPortalRouteRenderersByPath: mapC
+    });
+
+    assert.strictEqual(result[0], mapA);
+    assert.strictEqual(result[1], mapB);
+    assert.strictEqual(result[2], mapC);
+});
+
+test("breadcrumbRouteMaps/getMappedRendererByPath returns mapped renderer or null", async () => {
+    const renderer = () => "ok";
+    const map = { "/x": renderer };
+
+    assert.strictEqual(getMappedRendererByPath("/x", map), renderer);
+    assert.strictEqual(getMappedRendererByPath("/missing", map), null);
+});
+
+test("breadcrumbRouteMaps/resolveMappedRouteRenderer honors map precedence", async () => {
+    const firstRenderer = () => "first";
+    const secondRenderer = () => "second";
+
+    const result = resolveMappedRouteRenderer("/same", [
+        { "/same": firstRenderer },
+        { "/same": secondRenderer }
+    ]);
+
+    assert.strictEqual(result, firstRenderer);
+    assert.strictEqual(resolveMappedRouteRenderer("/none", []), null);
+});
+
+const run = async () => {
+    let passed = 0;
+
+    for (const currentTest of tests) {
+        await currentTest.fn();
+        passed += 1;
+    }
+
+    console.log(
+        `Phase 22 breadcrumb-route-maps-helper tests passed (${passed}/${tests.length}).`
+    );
+};
+
+module.exports = run;
+
+if (require.main === module) {
+    run().catch((error) => {
+        console.error(error);
+        process.exit(1);
+    });
+}

tests/phase22/breadcrumbs-route-map-structure.test.cjs

@@ -60,17 +60,25 @@ test("breadcrumbs/merged resolver renders mapped routes through single helper in
     const source = loadBreadcrumbSource();
 
     assert.strictEqual(
-        source.includes("const mappedRouteRendererMaps = ["),
+        source.includes('from "../lib/routing/breadcrumbRouteMaps"'),
         true,
-        "Expected grouped mapped route renderer map composition to exist"
+        "Expected breadcrumbs to import shared breadcrumb route-map helper module"
     );
 
     assert.strictEqual(
         source.includes(
-            "const getMappedRendererByPath = (path, routeRendererMap) =>"
+            "const mappedRouteRendererMaps = buildBreadcrumbRendererMaps({"
         ),
         true,
-        "Expected shared mapped renderer lookup helper to exist"
+        "Expected grouped mapped route renderer map composition to use helper builder"
+    );
+
+    assert.strictEqual(
+        source.includes(
+            "return resolveMappedRouteRendererByMaps(path, mappedRouteRendererMaps);"
+        ),
+        true,
+        "Expected resolver to delegate to shared route-map resolver helper"
     );
 
     assert.strictEqual(
@@ -104,6 +112,32 @@ test("breadcrumbs/merged resolver renders mapped routes through single helper in
         false,
         "Expected /myportal/addresssearchresults explicit branch to be removed after mapping"
     );
+
+    const mapBuilderCallIndex = source.indexOf(
+        "const mappedRouteRendererMaps = buildBreadcrumbRendererMaps({"
+    );
+    const mapBuilderSlice = source.slice(
+        mapBuilderCallIndex,
+        mapBuilderCallIndex + 300
+    );
+
+    const simpleRouteOrderIndex = mapBuilderSlice.indexOf(
+        "simpleRouteRenderersByPath"
+    );
+    const simpleLinkTextPairOrderIndex = mapBuilderSlice.indexOf(
+        "simpleLinkTextPairRenderersByPath"
+    );
+    const simpleMyPortalOrderIndex = mapBuilderSlice.indexOf(
+        "simpleMyPortalRouteRenderersByPath"
+    );
+
+    assert.strictEqual(
+        simpleRouteOrderIndex >= 0 &&
+            simpleLinkTextPairOrderIndex > simpleRouteOrderIndex &&
+            simpleMyPortalOrderIndex > simpleLinkTextPairOrderIndex,
+        true,
+        "Expected map builder call to preserve explicit route-map ordering (simple -> link-text -> myportal)"
+    );
 });
 
 test("breadcrumbs/dynamic callback branch remains explicit for myportal case incident route", async () => {

tests/phase22/index.test.cjs

@@ -7,6 +7,7 @@ const runAuthRedirectSafetyTests = require("./auth-redirect-safety.test.cjs");
 const runI18nRouteParityTests = require("./i18n-route-parity.test.cjs");
 const runAzurestorageHelperTests = require("./azurestorage-helper-behaviour.test.cjs");
 const runRouteStateHelperTests = require("./route-state-helper.test.cjs");
+const runBreadcrumbRouteMapsHelperTests = require("./breadcrumb-route-maps-helper.test.cjs");
 const runBreadcrumbsRouteMapStructureTests = require("./breadcrumbs-route-map-structure.test.cjs");
 
 const run = async () => {
@@ -19,6 +20,7 @@ const run = async () => {
     await runI18nRouteParityTests();
     await runAzurestorageHelperTests();
     await runRouteStateHelperTests();
+    await runBreadcrumbRouteMapsHelperTests();
     await runBreadcrumbsRouteMapStructureTests();
     console.log("Phase 22 combined suite passed.");
 };