robbond/pedwfrontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TASK22028: phase 16 memory-bank updates

Browse Source
This commit is contained in:
robbond
2026-03-13 16:24:55 +00:00
parent c196edb457
commit 6a9a257ae8
4 changed files with 145 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
memory-bank/progress.md
+53
View File
@@ -650,6 +650,59 @@
- `tests/phase15/service-behaviour.test.cjs`
2. Re-run phase6–phase15 tests and lint to confirm parity.
## Latest update (2026-03-13 — Phase 16 file-proxy consistency slice)
- Continued on branch:
- `TASK22028-phase15-hardening-slice`
- Delivered a small consistency-only hardening slice across 3 sensitive file proxy handlers:
- `pages/api/file/getbloblistproxy.js`
- `pages/api/file/getrepsblobproxy.js`
- `pages/api/file/getawaitingsubmissionfromblobproxy.js`
- Scope delivered:
- removed unused imports/constants in touched handlers to reduce noisy/unsafe dead code
- standardized required input checks using shared local `hasValue` pattern
- preserved response shape/signature/status behavior contracts
- Added focused tests:
- `tests/phase16/service-behaviour.test.cjs`
- negative-path checks for missing required container/casefolder inputs
- one valid-input happy-path contract check for `getbloblistproxy` (200 + passthrough shape)
### Validation snapshot (Phase 16)
- `node tests/phase6/service-parity.test.cjs` -> **pass**
- `node tests/phase6/service-behaviour.test.cjs` -> **pass** (8/8)
- `node tests/phase7/service-behaviour.test.cjs` -> **pass** (10/10)
- `node tests/phase8/service-behaviour.test.cjs` -> **pass** (5/5)
- `node tests/phase9/service-behaviour.test.cjs` -> **pass** (5/5)
- `node tests/phase10/service-behaviour.test.cjs` -> **pass** (5/5)
- `node tests/phase11/service-behaviour.test.cjs` -> **pass** (4/4)
- `node tests/phase12/service-behaviour.test.cjs` -> **pass** (4/4)
- `node tests/phase13/service-behaviour.test.cjs` -> **pass** (7/7)
- `node tests/phase14/service-behaviour.test.cjs` -> **pass** (5/5)
- `node tests/phase15/service-behaviour.test.cjs` -> **pass** (5/5)
- `node tests/phase16/service-behaviour.test.cjs` -> **pass** (4/4)
- `npm run lint` -> **warnings only** (pre-existing `react-hooks/exhaustive-deps` warnings)
### Manual HTTP checks (Phase 16)
- Dev server on `http://localhost:3002`.
- Negative-path checks:
- `/api/file/getbloblistproxy?casefolderID=case-1` -> **400**
- `/api/file/getbloblistproxy?container=c1` -> **400**
- `/api/file/getrepsblobproxy` -> **400**
- `/api/file/getawaitingsubmissionfromblobproxy` -> **400**
- Feasible valid-input spot-check:
- `/api/file/getbloblistproxy?container=c1&casefolderID=case-1` -> **400** (expected downstream/local dependency behavior; input guard passed)
### Rollback plan (Phase 16)
1. Revert commit `c196edb` or files:
- `pages/api/file/getbloblistproxy.js`
- `pages/api/file/getrepsblobproxy.js`
- `pages/api/file/getawaitingsubmissionfromblobproxy.js`
- `tests/phase16/service-behaviour.test.cjs`
2. Re-run phase6–phase16 tests and lint.
## Outstanding risks / gaps
- Navigation regressions across EN/CY + route query combinations.