refactor: extract server-side CRM contact update
This commit is contained in:
@@ -0,0 +1,29 @@
|
|||||||
|
import axios from "axios";
|
||||||
|
import { getToken } from "../../actions/core/token";
|
||||||
|
import { hashAPIPath } from "../../actions/core/hash";
|
||||||
|
|
||||||
|
const WEBAPI_URL =
|
||||||
|
process.env.RELAY_ROOT ||
|
||||||
|
"https://dev-pedw-ns.servicebus.windows.net/dev-pedw-hc/";
|
||||||
|
|
||||||
|
export const updateCrmContact = async (contactId, updatePayload) => {
|
||||||
|
const token = await getToken();
|
||||||
|
const queryUrl = "contacts(" + contactId + ")";
|
||||||
|
|
||||||
|
const config = {
|
||||||
|
method: "patch",
|
||||||
|
url: WEBAPI_URL + queryUrl + hashAPIPath(queryUrl),
|
||||||
|
headers: {
|
||||||
|
"OData-MaxVersion": "4.0",
|
||||||
|
"OData-Version": "4.0",
|
||||||
|
Accept: "application/json",
|
||||||
|
Prefer: 'odata.include-annotations="*",return=representation',
|
||||||
|
Authorization: "Bearer " + token.access_token,
|
||||||
|
"Content-Type": "application/json"
|
||||||
|
},
|
||||||
|
data: JSON.stringify(updatePayload)
|
||||||
|
};
|
||||||
|
|
||||||
|
const response = await axios(config);
|
||||||
|
return response.data;
|
||||||
|
};
|
||||||
@@ -10,15 +10,9 @@
|
|||||||
* description: Success
|
* description: Success
|
||||||
*/
|
*/
|
||||||
|
|
||||||
import axios from "axios";
|
|
||||||
import { consoleLogger } from "../../../actions/core/logger";
|
import { consoleLogger } from "../../../actions/core/logger";
|
||||||
import { getToken } from "../../../actions/core/token";
|
|
||||||
import { hashAPIPath } from "../../../actions/core/hash";
|
|
||||||
import { respondError, respondSuccess } from "../middleware/apiResponse";
|
import { respondError, respondSuccess } from "../middleware/apiResponse";
|
||||||
|
import { updateCrmContact } from "../../../lib/server/updateCrmContact";
|
||||||
const WEBAPI_URL =
|
|
||||||
process.env.RELAY_ROOT ||
|
|
||||||
"https://dev-pedw-ns.servicebus.windows.net/dev-pedw-hc/";
|
|
||||||
|
|
||||||
export default async function ApiProxy(req, res) {
|
export default async function ApiProxy(req, res) {
|
||||||
const contactId = req.query.contactId;
|
const contactId = req.query.contactId;
|
||||||
@@ -40,26 +34,8 @@ export default async function ApiProxy(req, res) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const token = await getToken();
|
const data = await updateCrmContact(contactId, req.body);
|
||||||
const data = JSON.stringify(req.body);
|
return respondSuccess(res, data);
|
||||||
const queryUrl = "contacts(" + contactId + ")";
|
|
||||||
|
|
||||||
const config = {
|
|
||||||
method: "patch",
|
|
||||||
url: WEBAPI_URL + queryUrl + hashAPIPath(queryUrl),
|
|
||||||
headers: {
|
|
||||||
"OData-MaxVersion": "4.0",
|
|
||||||
"OData-Version": "4.0",
|
|
||||||
Accept: "application/json",
|
|
||||||
Prefer: 'odata.include-annotations="*",return=representation',
|
|
||||||
Authorization: "Bearer " + token.access_token,
|
|
||||||
"Content-Type": "application/json"
|
|
||||||
},
|
|
||||||
data
|
|
||||||
};
|
|
||||||
|
|
||||||
const response = await axios(config);
|
|
||||||
return respondSuccess(res, response.data);
|
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
consoleLogger(error);
|
consoleLogger(error);
|
||||||
return respondError(res, {
|
return respondError(res, {
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
import { updateAccount } from "../../../actions/services/accountService";
|
import { updateCrmContact } from "../../../lib/server/updateCrmContact";
|
||||||
import { hashAPIPath } from "../../../actions/core/hash";
|
import { hashAPIPath } from "../../../actions/core/hash";
|
||||||
import { consoleLogger } from "../../../actions/core/logger";
|
import { consoleLogger } from "../../../actions/core/logger";
|
||||||
import {
|
import {
|
||||||
@@ -59,10 +59,7 @@ ApiProxy.get(async (req, res) => {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
if (
|
if (!isValidContainer(containerName) || !isValidTempCaseRef(tempCaseRef)) {
|
||||||
!isValidContainer(containerName) ||
|
|
||||||
!isValidTempCaseRef(tempCaseRef)
|
|
||||||
) {
|
|
||||||
return respondError(res, {
|
return respondError(res, {
|
||||||
status: 400,
|
status: 400,
|
||||||
code: "INVALID_REQUEST",
|
code: "INVALID_REQUEST",
|
||||||
@@ -158,13 +155,9 @@ ApiProxy.get(async (req, res) => {
|
|||||||
if (typeofinvolvement != 846040000) {
|
if (typeofinvolvement != 846040000) {
|
||||||
void (async () => {
|
void (async () => {
|
||||||
try {
|
try {
|
||||||
await updateAccount(
|
await updateCrmContact(contactId[1], {
|
||||||
contactId[1],
|
|
||||||
{
|
|
||||||
pinswg_typeofinvolvement: 846040001
|
pinswg_typeofinvolvement: 846040001
|
||||||
},
|
});
|
||||||
true
|
|
||||||
);
|
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
consoleLogger(error);
|
consoleLogger(error);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -155,7 +155,7 @@ test("createappealcompletemessage_api rejects missing hash with 400", async () =
|
|||||||
createBlob: async () => ({}),
|
createBlob: async () => ({}),
|
||||||
getCaseBlob: async () => ({}),
|
getCaseBlob: async () => ({}),
|
||||||
createCaseCompleteMessage: async () => ({}),
|
createCaseCompleteMessage: async () => ({}),
|
||||||
updateAccount: async () => ({}),
|
updateCrmContact: async () => ({}),
|
||||||
consoleLogger: () => {},
|
consoleLogger: () => {},
|
||||||
_: { isEmpty: (value) => !value },
|
_: { isEmpty: (value) => !value },
|
||||||
nextConnect,
|
nextConnect,
|
||||||
|
|||||||
@@ -835,9 +835,7 @@ test("updateaccount returns CONTACT_ID_REQUIRED when contactId missing", async (
|
|||||||
const mod = loadModule("pages/api/endpoint/updateaccount_api.js", {
|
const mod = loadModule("pages/api/endpoint/updateaccount_api.js", {
|
||||||
respondError: respondErrorMock,
|
respondError: respondErrorMock,
|
||||||
respondSuccess: respondSuccessMock,
|
respondSuccess: respondSuccessMock,
|
||||||
getToken: async () => ({ access_token: "token" }),
|
updateCrmContact: async () => ({ contactid: "c1" }),
|
||||||
hashAPIPath: () => "&hash=expected",
|
|
||||||
axios: async () => ({ data: { contactid: "c1" } }),
|
|
||||||
consoleLogger: () => {}
|
consoleLogger: () => {}
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -853,9 +851,7 @@ test("updateaccount returns ACCOUNT_UPDATE_PAYLOAD_REQUIRED when body missing",
|
|||||||
const mod = loadModule("pages/api/endpoint/updateaccount_api.js", {
|
const mod = loadModule("pages/api/endpoint/updateaccount_api.js", {
|
||||||
respondError: respondErrorMock,
|
respondError: respondErrorMock,
|
||||||
respondSuccess: respondSuccessMock,
|
respondSuccess: respondSuccessMock,
|
||||||
getToken: async () => ({ access_token: "token" }),
|
updateCrmContact: async () => ({ contactid: "c1" }),
|
||||||
hashAPIPath: () => "&hash=expected",
|
|
||||||
axios: async () => ({ data: { contactid: "c1" } }),
|
|
||||||
consoleLogger: () => {}
|
consoleLogger: () => {}
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -874,9 +870,7 @@ test("updateaccount catch path returns ACCOUNT_UPDATE_FAILED", async () => {
|
|||||||
const mod = loadModule("pages/api/endpoint/updateaccount_api.js", {
|
const mod = loadModule("pages/api/endpoint/updateaccount_api.js", {
|
||||||
respondError: respondErrorMock,
|
respondError: respondErrorMock,
|
||||||
respondSuccess: respondSuccessMock,
|
respondSuccess: respondSuccessMock,
|
||||||
getToken: async () => ({ access_token: "token" }),
|
updateCrmContact: async () => {
|
||||||
hashAPIPath: () => "&hash=expected",
|
|
||||||
axios: async () => {
|
|
||||||
throw new Error("relay failed");
|
throw new Error("relay failed");
|
||||||
},
|
},
|
||||||
consoleLogger: () => {}
|
consoleLogger: () => {}
|
||||||
|
|||||||
@@ -149,7 +149,9 @@ const assertNoUploadWrites = (calls) => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
test("upload rejects a missing NextAuth session before HMAC or Azure write", async () => {
|
test("upload rejects a missing NextAuth session before HMAC or Azure write", async () => {
|
||||||
const loaded = loadUploadAuthorization({ getServerSession: async () => null });
|
const loaded = loadUploadAuthorization({
|
||||||
|
getServerSession: async () => null
|
||||||
|
});
|
||||||
const res = createRes();
|
const res = createRes();
|
||||||
|
|
||||||
await loaded.mod.default.handler(uploadAuthorizationRequest(), res);
|
await loaded.mod.default.handler(uploadAuthorizationRequest(), res);
|
||||||
@@ -906,9 +908,15 @@ for (const inputCase of [
|
|||||||
{ name: "missing container", body: { container: undefined } },
|
{ name: "missing container", body: { container: undefined } },
|
||||||
{ name: "malformed container", body: { container: "Invalid_Container" } },
|
{ name: "malformed container", body: { container: "Invalid_Container" } },
|
||||||
{ name: "missing case identifier", body: { casefolderID: undefined } },
|
{ name: "missing case identifier", body: { casefolderID: undefined } },
|
||||||
{ name: "case identifier path separator", body: { casefolderID: "TMP/CASE-1" } },
|
{
|
||||||
|
name: "case identifier path separator",
|
||||||
|
body: { casefolderID: "TMP/CASE-1" }
|
||||||
|
},
|
||||||
{ name: "case identifier traversal segment", body: { casefolderID: ".." } },
|
{ name: "case identifier traversal segment", body: { casefolderID: ".." } },
|
||||||
{ name: "case identifier control character", body: { casefolderID: "TMP\u0000CASE" } }
|
{
|
||||||
|
name: "case identifier control character",
|
||||||
|
body: { casefolderID: "TMP\u0000CASE" }
|
||||||
|
}
|
||||||
]) {
|
]) {
|
||||||
test(`admin case deletion rejects ${inputCase.name} without deletion`, async () => {
|
test(`admin case deletion rejects ${inputCase.name} without deletion`, async () => {
|
||||||
const loaded = loadAdminCaseDeletion();
|
const loaded = loadAdminCaseDeletion();
|
||||||
@@ -917,7 +925,8 @@ for (const inputCase of [
|
|||||||
|
|
||||||
request.body = { ...request.body, ...inputCase.body };
|
request.body = { ...request.body, ...inputCase.body };
|
||||||
Object.keys(request.body).forEach((key) => {
|
Object.keys(request.body).forEach((key) => {
|
||||||
if (typeof request.body[key] === "undefined") delete request.body[key];
|
if (typeof request.body[key] === "undefined")
|
||||||
|
delete request.body[key];
|
||||||
});
|
});
|
||||||
await loaded.mod.default(request, res);
|
await loaded.mod.default(request, res);
|
||||||
|
|
||||||
@@ -938,10 +947,9 @@ test("valid administrator can delete a cross-container case prefix with the exis
|
|||||||
assert.deepStrictEqual(loaded.calls.deletion, [
|
assert.deepStrictEqual(loaded.calls.deletion, [
|
||||||
[request.body.container, request.body.casefolderID]
|
[request.body.container, request.body.casefolderID]
|
||||||
]);
|
]);
|
||||||
assert.deepStrictEqual(
|
assert.deepStrictEqual(JSON.parse(JSON.stringify(res.state.jsonBody)), {
|
||||||
JSON.parse(JSON.stringify(res.state.jsonBody)),
|
data: loaded.payload
|
||||||
{ data: loaded.payload }
|
});
|
||||||
);
|
|
||||||
});
|
});
|
||||||
|
|
||||||
test("admin case deletion dependency failure returns DELETE_BLOB_CASE_FAILED", async () => {
|
test("admin case deletion dependency failure returns DELETE_BLOB_CASE_FAILED", async () => {
|
||||||
@@ -1166,7 +1174,10 @@ test("valid administrative representation JSON edit preserves the existing mutat
|
|||||||
const updatedJson = JSON.parse(loaded.uploaded.content);
|
const updatedJson = JSON.parse(loaded.uploaded.content);
|
||||||
assert.strictEqual(Object.hasOwn(updatedJson, "repComplete"), false);
|
assert.strictEqual(Object.hasOwn(updatedJson, "repComplete"), false);
|
||||||
assert.strictEqual(updatedJson.containerID, loaded.sourceJson.containerID);
|
assert.strictEqual(updatedJson.containerID, loaded.sourceJson.containerID);
|
||||||
assert.strictEqual(updatedJson.ticketnumber, loaded.sourceJson.ticketnumber);
|
assert.strictEqual(
|
||||||
|
updatedJson.ticketnumber,
|
||||||
|
loaded.sourceJson.ticketnumber
|
||||||
|
);
|
||||||
assert.strictEqual(
|
assert.strictEqual(
|
||||||
updatedJson.representationType,
|
updatedJson.representationType,
|
||||||
loaded.sourceJson.representationType
|
loaded.sourceJson.representationType
|
||||||
@@ -1234,9 +1245,7 @@ test("deleteawaitingsubmissionfromblob accepts legacy deleteblob hash variant",
|
|||||||
getServerSession: async () => ({ user: { id: "container-1" } }),
|
getServerSession: async () => ({ user: { id: "container-1" } }),
|
||||||
authOptions: () => ({}),
|
authOptions: () => ({}),
|
||||||
hashAPIPath: (queryPath) =>
|
hashAPIPath: (queryPath) =>
|
||||||
queryPath.includes(
|
queryPath.includes("/api/file/deleteblob?container=container-1")
|
||||||
"/api/file/deleteblob?container=container-1"
|
|
||||||
)
|
|
||||||
? "&hash=expected"
|
? "&hash=expected"
|
||||||
: "&hash=other",
|
: "&hash=other",
|
||||||
respondError: respondErrorMock,
|
respondError: respondErrorMock,
|
||||||
@@ -1692,7 +1701,12 @@ const appealCompletionSigningRequest = (pathValue) => ({
|
|||||||
});
|
});
|
||||||
|
|
||||||
for (const sessionCase of [
|
for (const sessionCase of [
|
||||||
{ name: "missing session", session: null, status: 401, code: "UNAUTHENTICATED" },
|
{
|
||||||
|
name: "missing session",
|
||||||
|
session: null,
|
||||||
|
status: 401,
|
||||||
|
code: "UNAUTHENTICATED"
|
||||||
|
},
|
||||||
{ name: "session without user id", session: { user: {} } },
|
{ name: "session without user id", session: { user: {} } },
|
||||||
{ name: "session with empty user id", session: { user: { id: "" } } },
|
{ name: "session with empty user id", session: { user: { id: "" } } },
|
||||||
{
|
{
|
||||||
@@ -1705,7 +1719,9 @@ for (const sessionCase of [
|
|||||||
}
|
}
|
||||||
]) {
|
]) {
|
||||||
test(`gethash rejects appeal completion signing for ${sessionCase.name} before HMAC generation`, async () => {
|
test(`gethash rejects appeal completion signing for ${sessionCase.name} before HMAC generation`, async () => {
|
||||||
const loaded = loadAppealCompletionSigning({ session: sessionCase.session });
|
const loaded = loadAppealCompletionSigning({
|
||||||
|
session: sessionCase.session
|
||||||
|
});
|
||||||
const res = createRes();
|
const res = createRes();
|
||||||
|
|
||||||
await loaded.mod.default.handler(appealCompletionSigningRequest(), res);
|
await loaded.mod.default.handler(appealCompletionSigningRequest(), res);
|
||||||
@@ -2256,14 +2272,29 @@ test("createrepcompletemessage rejects unsupported methods before authorization
|
|||||||
|
|
||||||
for (const inputCase of [
|
for (const inputCase of [
|
||||||
{ name: "missing container", query: { container: undefined } },
|
{ name: "missing container", query: { container: undefined } },
|
||||||
{ name: "invalid container type", query: { container: ["user-container"] } },
|
{
|
||||||
|
name: "invalid container type",
|
||||||
|
query: { container: ["user-container"] }
|
||||||
|
},
|
||||||
{ name: "malformed container", query: { container: "Invalid_Container" } },
|
{ name: "malformed container", query: { container: "Invalid_Container" } },
|
||||||
{ name: "missing case reference", query: { tempcaseref: undefined } },
|
{ name: "missing case reference", query: { tempcaseref: undefined } },
|
||||||
{ name: "unsafe case-reference path separator", query: { tempcaseref: "CAS/123" } },
|
{
|
||||||
{ name: "unsafe case-reference traversal segment", query: { tempcaseref: ".." } },
|
name: "unsafe case-reference path separator",
|
||||||
|
query: { tempcaseref: "CAS/123" }
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "unsafe case-reference traversal segment",
|
||||||
|
query: { tempcaseref: ".." }
|
||||||
|
},
|
||||||
{ name: "missing representation identifier", query: { repid: undefined } },
|
{ name: "missing representation identifier", query: { repid: undefined } },
|
||||||
{ name: "unsafe representation path separator", query: { repid: "rep\\file" } },
|
{
|
||||||
{ name: "unsafe representation control character", query: { repid: "rep\u0000file" } }
|
name: "unsafe representation path separator",
|
||||||
|
query: { repid: "rep\\file" }
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "unsafe representation control character",
|
||||||
|
query: { repid: "rep\u0000file" }
|
||||||
|
}
|
||||||
]) {
|
]) {
|
||||||
test(`createrepcompletemessage rejects ${inputCase.name} before authorization work`, async () => {
|
test(`createrepcompletemessage rejects ${inputCase.name} before authorization work`, async () => {
|
||||||
const loaded = loadOrdinaryRepCompletion();
|
const loaded = loadOrdinaryRepCompletion();
|
||||||
@@ -2272,7 +2303,8 @@ for (const inputCase of [
|
|||||||
|
|
||||||
request.query = { ...request.query, ...inputCase.query };
|
request.query = { ...request.query, ...inputCase.query };
|
||||||
Object.keys(request.query).forEach((key) => {
|
Object.keys(request.query).forEach((key) => {
|
||||||
if (typeof request.query[key] === "undefined") delete request.query[key];
|
if (typeof request.query[key] === "undefined")
|
||||||
|
delete request.query[key];
|
||||||
});
|
});
|
||||||
await loaded.mod.default(request, res);
|
await loaded.mod.default(request, res);
|
||||||
|
|
||||||
@@ -2416,7 +2448,13 @@ test("createrepcompletemessage dependency failure returns CREATE_REP_COMPLETE_ME
|
|||||||
});
|
});
|
||||||
|
|
||||||
const loadAdminRepCompletion = (overrides = {}) => {
|
const loadAdminRepCompletion = (overrides = {}) => {
|
||||||
const calls = { noStore: 0, readSession: 0, validate: 0, origin: 0, queue: [] };
|
const calls = {
|
||||||
|
noStore: 0,
|
||||||
|
readSession: 0,
|
||||||
|
validate: 0,
|
||||||
|
origin: 0,
|
||||||
|
queue: []
|
||||||
|
};
|
||||||
const payload = { messageId: "admin-message" };
|
const payload = { messageId: "admin-message" };
|
||||||
const mod = loadModule("pages/api/admin/createrepcompletemessage.js", {
|
const mod = loadModule("pages/api/admin/createrepcompletemessage.js", {
|
||||||
respondError: respondErrorMock,
|
respondError: respondErrorMock,
|
||||||
@@ -2495,7 +2533,10 @@ for (const sessionCase of [
|
|||||||
}
|
}
|
||||||
|
|
||||||
for (const originCase of [
|
for (const originCase of [
|
||||||
{ name: "missing Origin", headers: { cookie: "pedw_admin_session=admin-token" } },
|
{
|
||||||
|
name: "missing Origin",
|
||||||
|
headers: { cookie: "pedw_admin_session=admin-token" }
|
||||||
|
},
|
||||||
{
|
{
|
||||||
name: "cross-origin request",
|
name: "cross-origin request",
|
||||||
headers: {
|
headers: {
|
||||||
@@ -2505,7 +2546,9 @@ for (const originCase of [
|
|||||||
}
|
}
|
||||||
]) {
|
]) {
|
||||||
test(`admin representation completion rejects ${originCase.name}`, async () => {
|
test(`admin representation completion rejects ${originCase.name}`, async () => {
|
||||||
const loaded = loadAdminRepCompletion({ hasTrustedSameOrigin: () => false });
|
const loaded = loadAdminRepCompletion({
|
||||||
|
hasTrustedSameOrigin: () => false
|
||||||
|
});
|
||||||
const res = createRes();
|
const res = createRes();
|
||||||
|
|
||||||
await loaded.mod.default(
|
await loaded.mod.default(
|
||||||
@@ -2533,7 +2576,8 @@ for (const inputCase of [
|
|||||||
|
|
||||||
request.body = { ...request.body, ...inputCase.body };
|
request.body = { ...request.body, ...inputCase.body };
|
||||||
Object.keys(request.body).forEach((key) => {
|
Object.keys(request.body).forEach((key) => {
|
||||||
if (typeof request.body[key] === "undefined") delete request.body[key];
|
if (typeof request.body[key] === "undefined")
|
||||||
|
delete request.body[key];
|
||||||
});
|
});
|
||||||
await loaded.mod.default(request, res);
|
await loaded.mod.default(request, res);
|
||||||
|
|
||||||
@@ -3051,7 +3095,9 @@ for (const adminSessionCase of [
|
|||||||
|
|
||||||
for (const originCase of ["missing Origin", "cross-origin request"]) {
|
for (const originCase of ["missing Origin", "cross-origin request"]) {
|
||||||
test(`admin getrepsblobproxy rejects ${originCase} before proxy work`, async () => {
|
test(`admin getrepsblobproxy rejects ${originCase} before proxy work`, async () => {
|
||||||
const loaded = loadAdminRepsProxy({ hasTrustedSameOrigin: () => false });
|
const loaded = loadAdminRepsProxy({
|
||||||
|
hasTrustedSameOrigin: () => false
|
||||||
|
});
|
||||||
const req = adminRepsRequest();
|
const req = adminRepsRequest();
|
||||||
if (originCase === "missing Origin") delete req.headers.origin;
|
if (originCase === "missing Origin") delete req.headers.origin;
|
||||||
if (originCase === "cross-origin request") {
|
if (originCase === "cross-origin request") {
|
||||||
@@ -3563,7 +3609,9 @@ const loadAppealCompletionDirect = ({ session, ...overrides } = {}) => {
|
|||||||
"customerid_contact@odata.bind":
|
"customerid_contact@odata.bind":
|
||||||
"/contacts(00000000-0000-0000-0000-000000000001)"
|
"/contacts(00000000-0000-0000-0000-000000000001)"
|
||||||
};
|
};
|
||||||
const mod = loadModule("pages/api/file/createappealcompletemessage_api.js", {
|
const mod = loadModule(
|
||||||
|
"pages/api/file/createappealcompletemessage_api.js",
|
||||||
|
{
|
||||||
nextConnect: createNextConnectMock(),
|
nextConnect: createNextConnectMock(),
|
||||||
middleware: () => {},
|
middleware: () => {},
|
||||||
respondError: respondErrorMock,
|
respondError: respondErrorMock,
|
||||||
@@ -3598,7 +3646,7 @@ const loadAppealCompletionDirect = ({ session, ...overrides } = {}) => {
|
|||||||
calls.caseBlob.push(args);
|
calls.caseBlob.push(args);
|
||||||
return {};
|
return {};
|
||||||
},
|
},
|
||||||
updateAccount: async (...args) => {
|
updateCrmContact: async (...args) => {
|
||||||
calls.account.push(args);
|
calls.account.push(args);
|
||||||
return {};
|
return {};
|
||||||
},
|
},
|
||||||
@@ -3607,9 +3655,13 @@ const loadAppealCompletionDirect = ({ session, ...overrides } = {}) => {
|
|||||||
return {};
|
return {};
|
||||||
},
|
},
|
||||||
consoleLogger: () => {},
|
consoleLogger: () => {},
|
||||||
_: { isEmpty: (value) => value === undefined || value === null || value === "" },
|
_: {
|
||||||
|
isEmpty: (value) =>
|
||||||
|
value === undefined || value === null || value === ""
|
||||||
|
},
|
||||||
...overrides
|
...overrides
|
||||||
});
|
}
|
||||||
|
);
|
||||||
|
|
||||||
return { mod, calls, options };
|
return { mod, calls, options };
|
||||||
};
|
};
|
||||||
@@ -3647,7 +3699,9 @@ for (const sessionCase of [
|
|||||||
}
|
}
|
||||||
]) {
|
]) {
|
||||||
test(`createappealcompletemessage_api blocks direct bypass with ${sessionCase.name} before HMAC or side effects`, async () => {
|
test(`createappealcompletemessage_api blocks direct bypass with ${sessionCase.name} before HMAC or side effects`, async () => {
|
||||||
const loaded = loadAppealCompletionDirect({ session: sessionCase.session });
|
const loaded = loadAppealCompletionDirect({
|
||||||
|
session: sessionCase.session
|
||||||
|
});
|
||||||
const res = createRes();
|
const res = createRes();
|
||||||
|
|
||||||
await loaded.mod.default.handler(appealCompletionDirectRequest(), res);
|
await loaded.mod.default.handler(appealCompletionDirectRequest(), res);
|
||||||
@@ -3799,11 +3853,7 @@ test("createappealcompletemessage_api preserves owner payloads and downstream co
|
|||||||
]);
|
]);
|
||||||
assert.deepStrictEqual(loaded.calls.download, [
|
assert.deepStrictEqual(loaded.calls.download, [
|
||||||
["owner-container", "TMP-CASE-1/progress.json", "TMP-CASE-1"],
|
["owner-container", "TMP-CASE-1/progress.json", "TMP-CASE-1"],
|
||||||
[
|
["owner-container", "TMP-CASE-1/TMP-CASE-1_case.json", "TMP-CASE-1"]
|
||||||
"owner-container",
|
|
||||||
"TMP-CASE-1/TMP-CASE-1_case.json",
|
|
||||||
"TMP-CASE-1"
|
|
||||||
]
|
|
||||||
]);
|
]);
|
||||||
const savedProgress = JSON.parse(loaded.calls.createBlob[0][0]);
|
const savedProgress = JSON.parse(loaded.calls.createBlob[0][0]);
|
||||||
assert.strictEqual(savedProgress.appealComplete, "TMP-CASE-1");
|
assert.strictEqual(savedProgress.appealComplete, "TMP-CASE-1");
|
||||||
@@ -3813,16 +3863,12 @@ test("createappealcompletemessage_api preserves owner payloads and downstream co
|
|||||||
"TMP-CASE-1"
|
"TMP-CASE-1"
|
||||||
]);
|
]);
|
||||||
assert.strictEqual(loaded.calls.caseBlob.length, 1);
|
assert.strictEqual(loaded.calls.caseBlob.length, 1);
|
||||||
assert.deepStrictEqual(
|
assert.deepStrictEqual(JSON.parse(JSON.stringify(loaded.calls.account)), [
|
||||||
JSON.parse(JSON.stringify(loaded.calls.account)),
|
|
||||||
[
|
|
||||||
[
|
[
|
||||||
"00000000-0000-0000-0000-000000000001",
|
"00000000-0000-0000-0000-000000000001",
|
||||||
{ pinswg_typeofinvolvement: 846040001 },
|
{ pinswg_typeofinvolvement: 846040001 }
|
||||||
true
|
|
||||||
]
|
]
|
||||||
]
|
]);
|
||||||
);
|
|
||||||
assert.deepStrictEqual(loaded.calls.queue, [
|
assert.deepStrictEqual(loaded.calls.queue, [
|
||||||
["owner-container", "TMP-CASE-1"]
|
["owner-container", "TMP-CASE-1"]
|
||||||
]);
|
]);
|
||||||
@@ -3905,7 +3951,7 @@ test("createappealcompletemessage_api accepts encoded hash variant and returns s
|
|||||||
createBlob: async () => ({}),
|
createBlob: async () => ({}),
|
||||||
getCaseBlob: async () => ({}),
|
getCaseBlob: async () => ({}),
|
||||||
createCaseCompleteMessage: async () => ({}),
|
createCaseCompleteMessage: async () => ({}),
|
||||||
updateAccount: async () => ({}),
|
updateCrmContact: async () => ({}),
|
||||||
consoleLogger: () => {},
|
consoleLogger: () => {},
|
||||||
_: { isEmpty: (v) => v === undefined || v === null || v === "" }
|
_: { isEmpty: (v) => v === undefined || v === null || v === "" }
|
||||||
}
|
}
|
||||||
@@ -4987,7 +5033,9 @@ for (const endpoint of [
|
|||||||
|
|
||||||
test(`${endpoint.name} rejects another user's container before privileged work`, async () => {
|
test(`${endpoint.name} rejects another user's container before privileged work`, async () => {
|
||||||
const loaded = endpoint.load({
|
const loaded = endpoint.load({
|
||||||
getServerSession: async () => ({ user: { id: "different-container" } })
|
getServerSession: async () => ({
|
||||||
|
user: { id: "different-container" }
|
||||||
|
})
|
||||||
});
|
});
|
||||||
const res = createRes();
|
const res = createRes();
|
||||||
|
|
||||||
@@ -5000,7 +5048,9 @@ for (const endpoint of [
|
|||||||
|
|
||||||
test(`${endpoint.name} ignores a client-provided user identity`, async () => {
|
test(`${endpoint.name} ignores a client-provided user identity`, async () => {
|
||||||
const loaded = endpoint.load({
|
const loaded = endpoint.load({
|
||||||
getServerSession: async () => ({ user: { id: "different-container" } })
|
getServerSession: async () => ({
|
||||||
|
user: { id: "different-container" }
|
||||||
|
})
|
||||||
});
|
});
|
||||||
const req = endpoint.request();
|
const req = endpoint.request();
|
||||||
req.body.userID = PDF_OWNER_CONTAINER;
|
req.body.userID = PDF_OWNER_CONTAINER;
|
||||||
@@ -5146,7 +5196,9 @@ for (const endpoint of [
|
|||||||
|
|
||||||
test(`${endpoint.name} rejects a valid HMAC for an unauthorised container`, async () => {
|
test(`${endpoint.name} rejects a valid HMAC for an unauthorised container`, async () => {
|
||||||
const loaded = endpoint.load({
|
const loaded = endpoint.load({
|
||||||
getServerSession: async () => ({ user: { id: "different-container" } })
|
getServerSession: async () => ({
|
||||||
|
user: { id: "different-container" }
|
||||||
|
})
|
||||||
});
|
});
|
||||||
const res = createRes();
|
const res = createRes();
|
||||||
await loaded.mod.default(endpoint.request(), res);
|
await loaded.mod.default(endpoint.request(), res);
|
||||||
@@ -5498,10 +5550,7 @@ test("createcase_api creates both draft JSON blobs in the authenticated owner's
|
|||||||
assert.strictEqual(loaded.calls.caseBlob.length, 1);
|
assert.strictEqual(loaded.calls.caseBlob.length, 1);
|
||||||
assert.strictEqual(loaded.calls.appealBlob.length, 1);
|
assert.strictEqual(loaded.calls.appealBlob.length, 1);
|
||||||
assert.strictEqual(loaded.calls.caseBlob[0][0], CASE_OWNER_CONTAINER);
|
assert.strictEqual(loaded.calls.caseBlob[0][0], CASE_OWNER_CONTAINER);
|
||||||
assert.strictEqual(
|
assert.strictEqual(loaded.calls.caseBlob[0][1], GENERATED_CASE_REFERENCE);
|
||||||
loaded.calls.caseBlob[0][1],
|
|
||||||
GENERATED_CASE_REFERENCE
|
|
||||||
);
|
|
||||||
assert.strictEqual(loaded.calls.appealBlob[0][1], CASE_OWNER_CONTAINER);
|
assert.strictEqual(loaded.calls.appealBlob[0][1], CASE_OWNER_CONTAINER);
|
||||||
assert.deepStrictEqual(
|
assert.deepStrictEqual(
|
||||||
JSON.parse(JSON.stringify(loaded.calls.caseBlob[0][2])),
|
JSON.parse(JSON.stringify(loaded.calls.caseBlob[0][2])),
|
||||||
@@ -5510,10 +5559,12 @@ test("createcase_api creates both draft JSON blobs in the authenticated owner's
|
|||||||
assert.deepStrictEqual(JSON.parse(loaded.calls.appealBlob[0][0]), {
|
assert.deepStrictEqual(JSON.parse(loaded.calls.appealBlob[0][0]), {
|
||||||
pinswg_name: GENERATED_CASE_REFERENCE,
|
pinswg_name: GENERATED_CASE_REFERENCE,
|
||||||
pinswg_appealcasetype: "846040000",
|
pinswg_appealcasetype: "846040000",
|
||||||
_pinswg_associatedlpa_value:
|
_pinswg_associatedlpa_value: "00000000-0000-4000-8000-000000000002"
|
||||||
"00000000-0000-4000-8000-000000000002"
|
|
||||||
});
|
});
|
||||||
assert.strictEqual(res.state.jsonBody.ticketnumber, GENERATED_CASE_REFERENCE);
|
assert.strictEqual(
|
||||||
|
res.state.jsonBody.ticketnumber,
|
||||||
|
GENERATED_CASE_REFERENCE
|
||||||
|
);
|
||||||
assert.strictEqual(res.state.jsonBody.title, GENERATED_CASE_REFERENCE);
|
assert.strictEqual(res.state.jsonBody.title, GENERATED_CASE_REFERENCE);
|
||||||
assert.strictEqual(
|
assert.strictEqual(
|
||||||
res.state.jsonBody.incidentid,
|
res.state.jsonBody.incidentid,
|
||||||
|
|||||||
@@ -140,7 +140,7 @@ test("createappealcompletemessage_api rejects invalid hash with 400", async () =
|
|||||||
createBlob: async () => {},
|
createBlob: async () => {},
|
||||||
getCaseBlob: async () => {},
|
getCaseBlob: async () => {},
|
||||||
createCaseCompleteMessage: () => {},
|
createCaseCompleteMessage: () => {},
|
||||||
updateAccount: async () => {},
|
updateCrmContact: async () => {},
|
||||||
_: { isEmpty: (value) => !value },
|
_: { isEmpty: (value) => !value },
|
||||||
nextConnect,
|
nextConnect,
|
||||||
middleware: () => {}
|
middleware: () => {}
|
||||||
|
|||||||
Reference in New Issue
Block a user