refactor(breadcrumbs): remove stale /newappeal inline no-op branch
This commit is contained in:
@@ -298,8 +298,6 @@ const Breadcrumbs = (props) => {
|
|||||||
|
|
||||||
{renderMappedRoute(pathname)}
|
{renderMappedRoute(pathname)}
|
||||||
|
|
||||||
{isPath("/newappeal") && <></>}
|
|
||||||
|
|
||||||
{staticTextCrumbLabel &&
|
{staticTextCrumbLabel &&
|
||||||
renderTextCrumb(staticTextCrumbLabel)}
|
renderTextCrumb(staticTextCrumbLabel)}
|
||||||
</ol>
|
</ol>
|
||||||
|
|||||||
@@ -887,6 +887,31 @@ Follow-ups:
|
|||||||
|
|
||||||
- Closure slice 3: resolve and guard remaining `/newappeal` inline edge branch treatment.
|
- Closure slice 3: resolve and guard remaining `/newappeal` inline edge branch treatment.
|
||||||
|
|
||||||
|
### CL-22541-Z3: breadcrumbs closure slice 3 — remove lingering `/newappeal` no-op inline branch
|
||||||
|
|
||||||
|
date: 2026-04-09
|
||||||
|
author: Cline
|
||||||
|
scope: `components/breadcrumbs.js`, `tests/phase22/breadcrumbs-route-map-structure.test.cjs`
|
||||||
|
type: change
|
||||||
|
rationale: Execute closure slice 3 by resolving the remaining inline `/newappeal` edge branch (a no-op render guard) and locking its removal with explicit structure coverage.
|
||||||
|
impact: Refactor/test hardening only; no runtime route/auth/session/API/EN-CY/a11y behavior change.
|
||||||
|
status: completed
|
||||||
|
|
||||||
|
Summary:
|
||||||
|
|
||||||
|
- Removed lingering no-op branch from breadcrumbs JSX:
|
||||||
|
- deleted `{isPath("/newappeal") && <></>}`
|
||||||
|
- Added structure guard assertion that `/newappeal` inline branch is absent.
|
||||||
|
|
||||||
|
Validation:
|
||||||
|
|
||||||
|
- `node tests/phase22/breadcrumbs-route-map-structure.test.cjs` -> pass (4/4).
|
||||||
|
- `node tests/phase22/index.test.cjs` -> pass (combined suite).
|
||||||
|
|
||||||
|
Follow-ups:
|
||||||
|
|
||||||
|
- Breadcrumb route-state extraction closure slices (1/2/3) complete.
|
||||||
|
|
||||||
### CL-00X: 22500 `components/elements/index.js` Phase 1 helper extraction
|
### CL-00X: 22500 `components/elements/index.js` Phase 1 helper extraction
|
||||||
|
|
||||||
date: 2026-04-07
|
date: 2026-04-07
|
||||||
|
|||||||
@@ -320,6 +320,12 @@ test("breadcrumbs/component composes mapped routes via imported factories and sh
|
|||||||
"Expected /newappeal/selectappeal explicit branch to be removed after mapping"
|
"Expected /newappeal/selectappeal explicit branch to be removed after mapping"
|
||||||
);
|
);
|
||||||
|
|
||||||
|
assert.strictEqual(
|
||||||
|
source.includes('isPath("/newappeal")'),
|
||||||
|
false,
|
||||||
|
"Expected /newappeal no-op explicit branch to be removed"
|
||||||
|
);
|
||||||
|
|
||||||
assert.strictEqual(
|
assert.strictEqual(
|
||||||
source.includes('isPath("/newappeal/[appealtypes]")'),
|
source.includes('isPath("/newappeal/[appealtypes]")'),
|
||||||
false,
|
false,
|
||||||
|
|||||||
Reference in New Issue
Block a user