TASK22224: align delete file route hash guards and contracts

2026-03-23 17:31:25 +00:00
parent bc483c5097
commit 8e0131d1ce
5 changed files with 354 additions and 44 deletions
@@ -71,6 +71,188 @@ test("deleteblob handler returns MISSING_REQUIRED_QUERY when blobname missing",
    assert.strictEqual(res.state.jsonBody.error.code, "MISSING_REQUIRED_QUERY");
 });

+test("deleteblob handler accepts encoded hash variant and normalizes prefixed path", async () => {
+    let deletedPath = null;
+    const mod = loadModule("pages/api/file/deleteblob.js", {
+        nextConnect: createNextConnectMock(),
+        middleware: () => {},
+        hashAPIPath: (queryPath) =>
+            queryPath.includes("/api/file/deleteblob?container=c1")
+                ? "&hash=expected"
+                : "&hash=other",
+        respondError: respondErrorMock,
+        respondSuccess: respondSuccessMock,
+        deleteBlob: async (_container, blobPath) => {
+            deletedPath = blobPath;
+            return { deleted: true };
+        }
+    });
+
+    const req = {
+        query: {
+            container: "c1",
+            casefolderID: "TMP-LFE1C",
+            blobname:
+                "TMP-LFE1C/files/2026-03-18_-_Site_Location_Plan_-_test document 021.xlsx",
+            hash: "expected"
+        }
+    };
+    const res = createRes();
+    await mod.default.handler(req, res);
+
+    assert.strictEqual(res.state.statusCode, 200);
+    assert.strictEqual(
+        deletedPath,
+        "TMP-LFE1C/files/2026-03-18_-_Site_Location_Plan_-_test document 021.xlsx"
+    );
+});
+
+test("deleteblob handler dependency failure returns DELETE_BLOB_FAILED", async () => {
+    const mod = loadModule("pages/api/file/deleteblob.js", {
+        nextConnect: createNextConnectMock(),
+        middleware: () => {},
+        hashAPIPath: () => "&hash=expected",
+        respondError: respondErrorMock,
+        respondSuccess: respondSuccessMock,
+        deleteBlob: async () => {
+            throw new Error("delete failed");
+        }
+    });
+
+    const req = {
+        query: {
+            container: "c1",
+            casefolderID: "f1",
+            blobname: "doc.pdf",
+            hash: "expected"
+        }
+    };
+    const res = createRes();
+    await mod.default.handler(req, res);
+
+    assert.strictEqual(res.state.statusCode, 400);
+    assert.strictEqual(res.state.jsonBody.error.code, "DELETE_BLOB_FAILED");
+});
+
+test("deleteblobcase handler accepts encoded hash variant", async () => {
+    let deletedCaseFolder = null;
+    const mod = loadModule("pages/api/file/deleteblobcase.js", {
+        nextConnect: createNextConnectMock(),
+        middleware: () => {},
+        hashAPIPath: (queryPath) =>
+            queryPath.includes("casefolderID=CASE%2FSUB")
+                ? "&hash=expected"
+                : "&hash=other",
+        respondError: respondErrorMock,
+        respondSuccess: respondSuccessMock,
+        deleteBlobCase: async (_container, casefolder) => {
+            deletedCaseFolder = casefolder;
+            return { deleted: true };
+        }
+    });
+
+    const req = {
+        query: {
+            container: "c1",
+            casefolderID: "CASE/SUB",
+            hash: "expected"
+        }
+    };
+    const res = createRes();
+    await mod.default.handler(req, res);
+
+    assert.strictEqual(res.state.statusCode, 200);
+    assert.strictEqual(deletedCaseFolder, "CASE/SUB");
+});
+
+test("deleteblobcase handler dependency failure returns DELETE_BLOB_CASE_FAILED", async () => {
+    const mod = loadModule("pages/api/file/deleteblobcase.js", {
+        nextConnect: createNextConnectMock(),
+        middleware: () => {},
+        hashAPIPath: () => "&hash=expected",
+        respondError: respondErrorMock,
+        respondSuccess: respondSuccessMock,
+        deleteBlobCase: async () => {
+            throw new Error("delete case failed");
+        }
+    });
+
+    const req = {
+        query: {
+            container: "c1",
+            casefolderID: "f1",
+            hash: "expected"
+        }
+    };
+    const res = createRes();
+    await mod.default.handler(req, res);
+
+    assert.strictEqual(res.state.statusCode, 400);
+    assert.strictEqual(
+        res.state.jsonBody.error.code,
+        "DELETE_BLOB_CASE_FAILED"
+    );
+});
+
+test("deleteblobrep handler accepts encoded hash variant", async () => {
+    let deletedRepPath = null;
+    const mod = loadModule("pages/api/file/deleteblobrep.js", {
+        nextConnect: createNextConnectMock(),
+        middleware: () => {},
+        hashAPIPath: (queryPath) =>
+            queryPath.includes("repfile=Rep%20Name")
+                ? "&hash=expected"
+                : "&hash=other",
+        respondError: respondErrorMock,
+        respondSuccess: respondSuccessMock,
+        deleteBlobRep: async (_container, repPath) => {
+            deletedRepPath = repPath;
+            return { deleted: true };
+        }
+    });
+
+    const req = {
+        query: {
+            container: "c1",
+            casefolderID: "CASE-1",
+            repfile: "Rep Name",
+            hash: "expected"
+        }
+    };
+    const res = createRes();
+    await mod.default.handler(req, res);
+
+    assert.strictEqual(res.state.statusCode, 200);
+    assert.strictEqual(deletedRepPath, "CASE-1/Rep Name");
+});
+
+test("deleteblobrep handler dependency failure returns DELETE_BLOB_REP_FAILED", async () => {
+    const mod = loadModule("pages/api/file/deleteblobrep.js", {
+        nextConnect: createNextConnectMock(),
+        middleware: () => {},
+        hashAPIPath: () => "&hash=expected",
+        respondError: respondErrorMock,
+        respondSuccess: respondSuccessMock,
+        deleteBlobRep: async () => {
+            throw new Error("delete rep failed");
+        }
+    });
+
+    const req = {
+        query: {
+            container: "c1",
+            casefolderID: "f1",
+            repfile: "rep1",
+            hash: "expected"
+        }
+    };
+    const res = createRes();
+    await mod.default.handler(req, res);
+
+    assert.strictEqual(res.state.statusCode, 400);
+    assert.strictEqual(res.state.jsonBody.error.code, "DELETE_BLOB_REP_FAILED");
+});
+
 test("getbloblist handler returns INVALID_HASH for mismatch", async () => {
    const mod = loadModule("pages/api/file/getbloblist.js", {
        nextConnect: createNextConnectMock(),