Merged PR 2254: refactor(representations): normalise shared type-selector and action-row frag...

refactor(representations): normalise shared type-selector and action-row fragments in main representation variants (Slice R5, behaviour-preserving)

Related work items: #22441
This commit is contained in:
Robert Bond
2026-04-17 09:22:36 +00:00
parent d05e54c020
commit 8e21ec1dd7
6 changed files with 272 additions and 353 deletions
+24 -2
View File
@@ -6,8 +6,8 @@ Base branch: `refactor`
## Status
Current slice: Slice R3Journey Step Resolution Extraction
Status: IMPLEMENTED (manual validation pending)
Current slice: Slice R5Representation Elements Normalisation
Status: COMPLETE
---
@@ -146,6 +146,28 @@ Clean up shared UI helpers and duplicated patterns.
- file upload handling (structure only, not behaviour)
- shared UI logic extraction
**Completion notes (this slice):**
- Implemented on feature branch created from `refactor`: `rep-slice-r5-elements-normalisation`.
- Added render-only shared fragments under `components/case/representation/elements/`:
- `RepresentationTypeSelectorBlock.js`
- `RepresentationActionButtons.js`
- Integrated these fragments into main representation variants only:
- `representationAppellant.js`
- `representationAgent.js`
- `representationInterestedPartyPerson.js`
- Preserved scope constraints for Slice R5:
- kept parent components as logic owners
- no submission/update side-effect refactor
- no upload service behaviour changes
- no payload/route/query/Redux/validation business-rule changes
- consultation variants intentionally not normalised in this slice
- Validation evidence:
- `npm run lint` completed (warnings only, no new errors).
- `npm run test:reps` completed: **7 passed**.
- Manual APP/IP/Agent/LPA checks: **passed**.
- Manual EN/CY parity checks: **passed**.
---
### Slice R6 — Async Data / Service Layer Cleanup