fix(security): retire obsolete CRM representation deletion endpoint
This commit is contained in:
@@ -65,75 +65,6 @@ test("document/getAwaitingSubmissionFromBlob logs and returns undefined on failu
|
||||
assert.strictEqual(logger.calls.length, 1);
|
||||
});
|
||||
|
||||
test("portal/deleteMyRepresentations appends hash and returns data", async () => {
|
||||
const axios = createAxiosMock();
|
||||
const logger = createLoggerMock();
|
||||
const signCalls = [];
|
||||
|
||||
axios.getHandler = async (url) => {
|
||||
if (url.startsWith("/api/endpoint/gethash_api?path=")) {
|
||||
signCalls.push(url);
|
||||
return { data: { hash: "&hash=portal123" } };
|
||||
}
|
||||
|
||||
throw new Error("Unexpected get url: " + url);
|
||||
};
|
||||
|
||||
axios.requestHandler = async () => ({ data: { removed: true } });
|
||||
|
||||
const portal = loadServiceModule("portalDirectService.js", {
|
||||
axios,
|
||||
BASE_URL: "",
|
||||
consoleLogger: logger.consoleLogger,
|
||||
hashAPIPath: () => "&hash=fallback"
|
||||
});
|
||||
|
||||
const result = await portal.deleteMyRepresentations("rep-1");
|
||||
|
||||
assert.deepStrictEqual(normalize(result), { removed: true });
|
||||
assert.strictEqual(
|
||||
signCalls[0],
|
||||
"/api/endpoint/gethash_api?path=%2Fapi%2Fendpoint%2Fdeletemyrepresentations_api%3FmyRepresentationsID%3Drep-1"
|
||||
);
|
||||
assert.strictEqual(
|
||||
axios.calls[0].url,
|
||||
"/api/endpoint/gethash_api?path=%2Fapi%2Fendpoint%2Fdeletemyrepresentations_api%3FmyRepresentationsID%3Drep-1"
|
||||
);
|
||||
assert.strictEqual(
|
||||
axios.calls[1].config.url,
|
||||
"/api/endpoint/deletemyrepresentations_api?myRepresentationsID=rep-1&hash=portal123"
|
||||
);
|
||||
assert.strictEqual(axios.calls[1].config.method, "delete");
|
||||
});
|
||||
|
||||
test("portal/deleteMyRepresentations logs and returns undefined on failure", async () => {
|
||||
const axios = createAxiosMock();
|
||||
const logger = createLoggerMock();
|
||||
|
||||
axios.getHandler = async (url) => {
|
||||
if (url.startsWith("/api/endpoint/gethash_api?path=")) {
|
||||
return { data: { hash: "&hash=portal-fail" } };
|
||||
}
|
||||
|
||||
throw new Error("Unexpected get url: " + url);
|
||||
};
|
||||
|
||||
axios.requestHandler = async () =>
|
||||
Promise.reject(createAxiosError(401, "Unauthorized"));
|
||||
|
||||
const portal = loadServiceModule("portalDirectService.js", {
|
||||
axios,
|
||||
BASE_URL: "",
|
||||
consoleLogger: logger.consoleLogger,
|
||||
hashAPIPath: () => "&hash=fallback"
|
||||
});
|
||||
|
||||
const result = await portal.deleteMyRepresentations("rep-2");
|
||||
|
||||
assert.strictEqual(result, undefined);
|
||||
assert.strictEqual(logger.calls.length, 1);
|
||||
});
|
||||
|
||||
test("portal/deleteWatchedCases uses signer hash and returns data", async () => {
|
||||
const axios = createAxiosMock();
|
||||
const logger = createLoggerMock();
|
||||
@@ -162,11 +93,11 @@ test("portal/deleteWatchedCases uses signer hash and returns data", async () =>
|
||||
assert.deepStrictEqual(normalize(result), { removed: true });
|
||||
assert.strictEqual(
|
||||
signCalls[0],
|
||||
"/api/endpoint/gethash_api?path=%2Fapi%2Fendpoint%2Fdeletewatchedcases_api%3FwatchedCaseID%3Dwatch-1"
|
||||
"/api/endpoint/gethash_api?path=%2Fapi%2Fsubscriptions%2Fdelete-watched-case%3FwatchedCaseID%3Dwatch-1"
|
||||
);
|
||||
assert.strictEqual(
|
||||
axios.calls[1].config.url,
|
||||
"/api/endpoint/deletewatchedcases_api?watchedCaseID=watch-1&hash=watch123"
|
||||
"/api/subscriptions/delete-watched-case?watchedCaseID=watch-1&hash=watch123"
|
||||
);
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user