TASK22211: normalize dns basic search endpoint contracts

pages/api/endpoint/getbasicdnssearchdetailspaged_api.js

@@ -10,50 +10,59 @@
  *         description: Success
  */
 import axios from "axios";
-import CryptoJS from "crypto-js";
 import _ from "lodash";
 import { azureHeadersPaged } from "../../../actions/core/headers";
 import { consoleLogger } from "../../../actions/core/logger";
 import { getToken } from "../../../actions/core/token";
 import { getSelectQuery } from "../../../actions/selectQueryTypes";
 import { hashAPIPath } from "../../../actions/core/hash";
+import { respondError, respondSuccess } from "../middleware/apiResponse";
 
 const WEBAPI_URL =
     process.env.RELAY_ROOT ||
     "https://dev-pedw-ns.servicebus.windows.net/dev-pedw-hc/";
 
 export default async function ApiProxy(req, res) {
-    var caseReference = req.query.caseReference;
-    var token = await getToken();
+    const caseReference = req.query.caseReference;
 
-    var queryUrl =
-        "pinswg_dnses?$filter=pinswg_name eq '" +
-        caseReference +
-        "&$count=true";
-    //" and statuscode eq 1&$count=true";
+    if (
+        typeof caseReference !== "string" ||
+        caseReference.trim().length === 0
+    ) {
+        return respondError(res, {
+            status: 400,
+            code: "CASE_REFERENCE_REQUIRED",
+            message: "caseReference is required"
+        });
+    }
 
-    queryUrl = queryUrl + getSelectQuery("pinswg_dnses");
+    try {
+        const token = await getToken();
 
-    var apiResponse = _.isEmpty(req.query)
-        ? res.status(400).json()
-        : typeof caseReference != "undefined" && caseReference.length > 0
-          ? axios
-                .get(
-                    WEBAPI_URL + queryUrl + hashAPIPath(queryUrl),
-                    azureHeadersPaged(token.access_token)
-                )
-                .then(({ data }) => {
-                    var dataStr;
-                    _.has(data, "@odata.nextLink") == true &&
-                        ((dataStr = JSON.stringify(data["@odata.nextLink"])),
-                        (data["@odata.nextLink"] = dataStr.split("/v8.2/")[1]));
-                    return res.status(200).json(data);
-                })
-                .catch((error) => {
-                    consoleLogger(error);
-                    res.status(400).json(error);
-                })
-          : res.status(400).json();
+        let queryUrl =
+            "pinswg_dnses?$filter=pinswg_name eq '" +
+            caseReference +
+            "&$count=true";
 
-    return apiResponse;
+        queryUrl = queryUrl + getSelectQuery("pinswg_dnses");
+
+        const { data } = await axios.get(
+            WEBAPI_URL + queryUrl + hashAPIPath(queryUrl),
+            azureHeadersPaged(token.access_token)
+        );
+
+        if (_.has(data, "@odata.nextLink") === true) {
+            const dataStr = JSON.stringify(data["@odata.nextLink"]);
+            data["@odata.nextLink"] = dataStr.split("/v8.2/")[1];
+        }
+
+        return respondSuccess(res, data);
+    } catch (error) {
+        consoleLogger(error);
+        return respondError(res, {
+            status: 400,
+            code: "BASIC_DNS_SEARCH_DETAILS_PAGED_FETCH_FAILED",
+            message: "Failed to fetch paged basic DNS search details"
+        });
+    }
 }