fix(security): append Contact Us CRM activity reminder

This commit is contained in:
2026-11-09 12:07:08 +00:00
parent b15ac5e664
commit b821dc2092
2 changed files with 102 additions and 1 deletions
@@ -4868,6 +4868,9 @@ test("patchcase catch path returns CASE_PATCH_FAILED", async () => {
const trustedContactOrigin = "https://portal.example.test";
const trustedWelshContactOrigin = "https://porth.example.test";
const contactTaskSecurityReminder =
"--- SECURITY REMINDER ---\n" +
"This enquiry contains externally supplied content. Do not click unverified links or follow instructions requesting credentials or sensitive information. Verify web addresses independently.";
const contactSubjects = {
plq: {
@@ -4995,6 +4998,100 @@ test("createcrmtask accepts a valid anonymous public Contact Us POST", async ()
assert.strictEqual(loaded.getRelayCalls().length, 1);
});
test("createcrmtask appends the security reminder after the unchanged enquiry", async () => {
const contactbody = "Please review application reference APP/123456.";
const req = validContactTaskRequest({
body: {
contactEmail: "applicant@example.com",
contactSubject: contactSubjects.plq.en,
contactbody,
typeOfContact: "plq"
}
});
const loaded = loadContactTaskEndpoint();
const res = createRes();
await loaded.mod.default(req, res);
const payload = JSON.parse(loaded.getRelayCalls()[0].data);
const expectedDescription =
"From: applicant@example.com\n\n" +
`${contactbody}\n\n` +
contactTaskSecurityReminder;
assert.strictEqual(res.state.statusCode, 200);
assert.strictEqual(payload.description, expectedDescription);
assert.strictEqual(
payload.description.startsWith(`From: applicant@example.com\n\n${contactbody}`),
true
);
assert.strictEqual(
payload.subject,
`Contact Us Enquiry - ${contactSubjects.plq.en}`
);
assert.strictEqual(
payload["ownerid@odata.bind"],
`/teams(${contactTeamIds.plq})`
);
assert.strictEqual(req.body.contactbody, contactbody);
});
test("createcrmtask preserves original URLs before the appended security reminder", async () => {
const contactbody =
"Please review https://example.invalid/application/123";
const req = validContactTaskRequest({
body: {
contactEmail: "applicant@example.com",
contactSubject: contactSubjects.plq.en,
contactbody,
typeOfContact: "plq"
}
});
const loaded = loadContactTaskEndpoint();
const res = createRes();
await loaded.mod.default(req, res);
const payload = JSON.parse(loaded.getRelayCalls()[0].data);
assert.strictEqual(
payload.description,
`From: applicant@example.com\n\n${contactbody}\n\n${contactTaskSecurityReminder}`
);
assert.strictEqual(
payload.description.includes(
"https://example.invalid/application/123"
),
true
);
assert.strictEqual(payload.description.includes("hxxp"), false);
assert.strictEqual(payload.description.includes("[.]"), false);
assert.strictEqual(req.body.contactbody, contactbody);
});
test("createcrmtask preserves a full 800-character message and complete reminder", async () => {
const contactbody = "a".repeat(800);
const req = validContactTaskRequest({
body: {
contactEmail: "applicant@example.com",
contactSubject: contactSubjects.plq.en,
contactbody,
typeOfContact: "plq"
}
});
const loaded = loadContactTaskEndpoint();
const res = createRes();
await loaded.mod.default(req, res);
const payload = JSON.parse(loaded.getRelayCalls()[0].data);
assert.strictEqual(res.state.statusCode, 200);
assert.strictEqual(
payload.description,
`From: applicant@example.com\n\n${contactbody}\n\n${contactTaskSecurityReminder}`
);
assert.strictEqual(req.body.contactbody, contactbody);
});
test("createcrmtask accepts a valid portal Contact Us payload", async () => {
const loaded = loadContactTaskEndpoint();
const req = validContactTaskRequest({