security: enforce CRM contact ownership and account field allowlist

This commit is contained in:
2026-11-06 10:55:47 +00:00
parent 71de8a2d14
commit b9be188d27
2 changed files with 422 additions and 28 deletions
@@ -831,20 +831,40 @@ test("createaccount catch path returns ACCOUNT_CREATE_FAILED", async () => {
assert.strictEqual(res.state.jsonBody.error.code, "ACCOUNT_CREATE_FAILED");
});
test("updateaccount returns CONTACT_ID_REQUIRED when contactId missing", async () => {
test("updateaccount returns INVALID_CONTACT_ID when contactId missing", async () => {
const mod = loadModule("pages/api/endpoint/updateaccount_api.js", {
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
updateCrmContact: async () => ({ contactid: "c1" }),
consoleLogger: () => {}
consoleLogger: () => {},
getServerSession: async () => ({
user: { email: "owner@example.com" }
}),
authOptions: () => ({}),
getToken: async () => ({
access_token: "test-token"
}),
escapeODataString: (value) => value,
azureHeaders: (token) => ({
headers: { Authorization: `Bearer ${token}` }
}),
relayGetData: async () => ({
data: {
value: [
{
contactid: "00000000-0000-0000-0000-000000000001"
}
]
}
})
});
const req = { query: {}, body: { firstname: "A" } };
const req = { method: "POST", query: {}, body: { firstname: "A" } };
const res = createRes();
await mod.default(req, res);
assert.strictEqual(res.state.statusCode, 400);
assert.strictEqual(res.state.jsonBody.error.code, "CONTACT_ID_REQUIRED");
assert.strictEqual(res.state.jsonBody.error.code, "INVALID_CONTACT_ID");
});
test("updateaccount returns ACCOUNT_UPDATE_PAYLOAD_REQUIRED when body missing", async () => {
@@ -852,10 +872,34 @@ test("updateaccount returns ACCOUNT_UPDATE_PAYLOAD_REQUIRED when body missing",
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
updateCrmContact: async () => ({ contactid: "c1" }),
consoleLogger: () => {}
consoleLogger: () => {},
getServerSession: async () => ({
user: { email: "owner@example.com" }
}),
authOptions: () => ({}),
getToken: async () => ({
access_token: "test-token"
}),
escapeODataString: (value) => value,
azureHeaders: (token) => ({
headers: { Authorization: `Bearer ${token}` }
}),
relayGetData: async () => ({
data: {
value: [
{
contactid: "00000000-0000-0000-0000-000000000001"
}
]
}
})
});
const req = { query: { contactId: "c1" }, body: undefined };
const req = {
method: "POST",
query: { contactId: "00000000-0000-0000-0000-000000000001" },
body: undefined
};
const res = createRes();
await mod.default(req, res);
@@ -873,10 +917,34 @@ test("updateaccount catch path returns ACCOUNT_UPDATE_FAILED", async () => {
updateCrmContact: async () => {
throw new Error("relay failed");
},
consoleLogger: () => {}
consoleLogger: () => {},
getServerSession: async () => ({
user: { email: "owner@example.com" }
}),
authOptions: () => ({}),
getToken: async () => ({
access_token: "test-token"
}),
escapeODataString: (value) => value,
azureHeaders: (token) => ({
headers: { Authorization: `Bearer ${token}` }
}),
relayGetData: async () => ({
data: {
value: [
{
contactid: "00000000-0000-0000-0000-000000000001"
}
]
}
})
});
const req = { query: { contactId: "c1" }, body: { firstname: "A" } };
const req = {
method: "POST",
query: { contactId: "00000000-0000-0000-0000-000000000001" },
body: { firstname: "A" }
};
const res = createRes();
await mod.default(req, res);
@@ -884,6 +952,240 @@ test("updateaccount catch path returns ACCOUNT_UPDATE_FAILED", async () => {
assert.strictEqual(res.state.jsonBody.error.code, "ACCOUNT_UPDATE_FAILED");
});
test("updateaccount rejects a different CRM contact before updating", async () => {
let updateCalls = 0;
const mod = loadModule("pages/api/endpoint/updateaccount_api.js", {
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
consoleLogger: () => {},
getServerSession: async () => ({
user: { email: "owner@example.com" }
}),
authOptions: () => ({}),
getToken: async () => ({
access_token: "test-token"
}),
escapeODataString: (value) => value,
azureHeaders: (token) => ({
headers: { Authorization: `Bearer ${token}` }
}),
relayGetData: async () => ({
data: {
value: [
{
contactid: "00000000-0000-0000-0000-000000000001"
}
]
}
}),
updateCrmContact: async () => {
updateCalls++;
return {};
}
});
const req = {
method: "POST",
query: {
contactId: "00000000-0000-0000-0000-000000000002"
},
body: {
firstname: "Unauthorised Update"
}
};
const res = createRes();
await mod.default(req, res);
assert.strictEqual(res.state.statusCode, 403);
assert.strictEqual(
res.state.jsonBody.error.code,
"CONTACT_OWNERSHIP_MISMATCH"
);
assert.strictEqual(updateCalls, 0);
});
test("updateaccount rejects unresolved CRM identity before updating", async () => {
let updateCalls = 0;
const mod = loadModule("pages/api/endpoint/updateaccount_api.js", {
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
consoleLogger: () => {},
getServerSession: async () => ({
user: { email: "owner@example.com" }
}),
authOptions: () => ({}),
getToken: async () => ({
access_token: "test-token"
}),
escapeODataString: (value) => value,
azureHeaders: (token) => ({
headers: { Authorization: `Bearer ${token}` }
}),
relayGetData: async () => ({
data: {
value: []
}
}),
updateCrmContact: async () => {
updateCalls++;
return {};
}
});
const req = {
method: "POST",
query: {
contactId: "00000000-0000-0000-0000-000000000001"
},
body: {
firstname: "Unauthorised Update"
}
};
const res = createRes();
await mod.default(req, res);
assert.strictEqual(res.state.statusCode, 403);
assert.strictEqual(
res.state.jsonBody.error.code,
"CONTACT_IDENTITY_NOT_RESOLVED"
);
assert.strictEqual(updateCalls, 0);
});
test("updateaccount strips prohibited CRM fields before updating", async () => {
const contactId = "00000000-0000-0000-0000-000000000001";
let capturedContactId;
let capturedPayload;
let updateCalls = 0;
const mod = loadModule("pages/api/endpoint/updateaccount_api.js", {
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
consoleLogger: () => {},
getServerSession: async () => ({
user: { email: "owner@example.com" }
}),
authOptions: () => ({}),
getToken: async () => ({
access_token: "test-token"
}),
escapeODataString: (value) => value,
azureHeaders: (token) => ({
headers: { Authorization: `Bearer ${token}` }
}),
relayGetData: async () => ({
data: {
value: [{ contactid: contactId }]
}
}),
updateCrmContact: async (id, payload) => {
updateCalls++;
capturedContactId = id;
capturedPayload = payload;
return { contactid: id };
}
});
const req = {
method: "POST",
query: { contactId },
body: {
firstname: "Robert",
telephone1: "01234567890",
emailaddress1: "attacker@example.com",
statuscode: 2,
contactid: "00000000-0000-0000-0000-000000000002"
}
};
const res = createRes();
await mod.default(req, res);
assert.strictEqual(res.state.statusCode, 200);
assert.strictEqual(updateCalls, 1);
assert.strictEqual(capturedContactId, contactId);
assert.deepStrictEqual(JSON.parse(JSON.stringify(capturedPayload)), {
firstname: "Robert",
telephone1: "01234567890"
});
});
test("updateaccount rejects payload containing only prohibited fields", async () => {
const contactId = "00000000-0000-0000-0000-000000000001";
let updateCalls = 0;
const mod = loadModule("pages/api/endpoint/updateaccount_api.js", {
respondError: respondErrorMock,
respondSuccess: respondSuccessMock,
consoleLogger: () => {},
getServerSession: async () => ({
user: { email: "owner@example.com" }
}),
authOptions: () => ({}),
getToken: async () => ({
access_token: "test-token"
}),
escapeODataString: (value) => value,
azureHeaders: (token) => ({
headers: { Authorization: `Bearer ${token}` }
}),
relayGetData: async () => ({
data: {
value: [{ contactid: contactId }]
}
}),
updateCrmContact: async () => {
updateCalls++;
return {};
}
});
const req = {
method: "POST",
query: { contactId },
body: {
emailaddress1: "attacker@example.com",
statuscode: 2,
contactid: "00000000-0000-0000-0000-000000000002"
}
};
const res = createRes();
await mod.default(req, res);
assert.strictEqual(res.state.statusCode, 400);
assert.strictEqual(
res.state.jsonBody.error.code,
"NO_ALLOWED_ACCOUNT_FIELDS"
);
assert.strictEqual(updateCalls, 0);
});
test("getbasicsearch returns SEARCH_STRING_REQUIRED when searchString missing", async () => {
const mod = loadModule("pages/api/endpoint/getbasicsearch_api.js", {
respondError: respondErrorMock,