refactor(actions): include residual axios-risk slices in branch

2026-03-25 09:43:40 +00:00
parent 94e2ed5831
commit ba7d94d83d
4 changed files with 251 additions and 202 deletions
@@ -1892,3 +1892,69 @@ Validation:
 Follow-ups:

 - Optional next bounded slice: assess whether signed-delete helpers in `portalDirectService` should remain explicit axios calls (for clarity on headers/hash semantics) or move to a dedicated signed-request client helper.
+
+---
+
+### CL-053: Architecture documentation update — current-state assessment + prioritised roadmap
+
+date: 2026-03-25
+author: Cline
+scope: `context/architecture.md`
+type: change
+rationale: User requested the architectural assessment be documented in-project so current state, residual risks, and recommended sequencing are explicitly captured for team planning.
+impact: Improves documentation clarity and planning alignment; no runtime behavior changes.
+status: completed
+
+Summary:
+
+- Added a new section to `context/architecture.md`:
+    - **Current State Assessment and Prioritised Next Steps (2026-03-25)**
+- Documented:
+    - strengths (governance maturity, API/relay hardening progress, façade decomposition progress)
+    - residual risks/gaps (remaining direct-service inconsistency, coverage concentration, logging variance, i18n parity automation gap)
+    - prioritised next steps with rationale
+    - recommended execution sequencing (immediate/next/after)
+
+Validation:
+
+- Manual coherence check against existing guardrails/runbook/integration-map and memory-bank context.
+
+Follow-ups:
+
+- Optional: convert the prioritised steps into a sprint-ready plan (tasks, acceptance criteria, validation matrix, rollback notes).
+
+---
+
+### CL-054: Branch correction — include residual duplication/axios risk slices (search + signed-delete portal flows)
+
+date: 2026-03-25
+author: Cline
+scope: `actions/services/{portalDirectService,searchDirectService}.js`, `context/architecture.md`
+type: change
+rationale: User requested the previously identified primary remaining technical risk slices be explicitly included on this branch, specifically residual axios/duplication in search direct service and signed-delete portal helper flows.
+impact: Further reduces direct-service axios boilerplate/duplication and aligns additional high-use service paths to shared endpoint client patterns while preserving existing behavior contracts.
+status: completed
+
+Summary:
+
+- Implemented the requested risk slices on branch:
+    1. **Portal signed-delete flow parity** (`portalDirectService`)
+        - migrated signed delete helpers from direct `axios({...}).then(res.data)` to `requestJson({...})`:
+            - `deleteMyRepresentations`
+            - `deleteWatchedCases`
+        - removed now-unused `axios` import from module
+        - preserved hash-signing flow and custom headers semantics
+    2. **Search direct service axios reduction** (`searchDirectService`)
+        - migrated service GET helpers from direct `axios.get(...).then(res.data)` and `axios(config)` to `getJson(...)`
+        - preserved existing catch semantics (`logAndReturnResponse`, `logAndReturnEmptyValueErrorResponse`, and explicit throw path in `getSearchDocumentDetails`)
+        - removed direct `axios` import from module
+- Documentation alignment:
+    - retained architecture assessment section in `context/architecture.md` that calls out these residual-risk slices and prioritisation.
+
+Validation:
+
+- `npm run lint` -> warnings only (pre-existing `react-hooks/exhaustive-deps`; no new lint errors)
+
+Follow-ups:
+
+- Optional next bounded slice: assess whether a dedicated signed-request client helper should encapsulate hash + headers + method conventions to prevent future drift in remaining signed flows.