refactor(api): migrate batch 11 advancedsearchpaged to relayGet

This commit is contained in:
2026-03-24 10:15:25 +00:00
parent 0f4b8005ba
commit bf1ba9bc1e
3 changed files with 55 additions and 98 deletions
+34
View File
@@ -1037,3 +1037,37 @@ Validation:
Follow-ups:
- Continue P2-S2 with the remaining legacy relay GET candidates (`createwatchedcases_api`, `deletewatchedcasesproxy_api`, `getadvancedsearch_api`, `getadvancedsearchpaged_api`, `getbasicsearch_by_address_api`, `getbasicsearch_by_lparref_api`, `getdnscoords_api`).
---
### CL-028: TASK22229 P2-S2 Batch 11 (advanced-search-paged relay GET)
date: 2026-03-24
author: Cline
scope: `pages/api/endpoint/getadvancedsearchpaged_api.js`, `tests/phase21/endpoint-handler-contract.test.cjs`
type: change
rationale: Continue bounded relay migration by moving the remaining advanced-search paged GET handler to shared `relayGet` while preserving query validation and response contracts.
impact: Reduced duplicated relay plumbing and aligned advanced paged search route with shared forwarding; no intended API contract changes.
status: completed
Summary:
- Migrated `getadvancedsearchpaged_api.js` to shared `relayGet`.
- Preserved existing guard behavior and error contracts:
- `SEARCH_STRING_REQUIRED`
- `ORDER_BY_REQUIRED`
- `FIELD_SORT_REQUIRED`
- `SHOW_NUMBER_OF_RECORDS_REQUIRED`
- `INVALID_SEARCH_STRING`
- `ADVANCED_SEARCH_PAGED_FETCH_FAILED`
- Preserved endpoint-specific transform behavior (`@odata.nextLink` normalization via `transformData`).
- Updated phase21 endpoint contract tests to inject `relayGet` mocks for `getadvancedsearchpaged_api` guard/catch assertions.
Validation:
- `node tests/phase21/endpoint-handler-contract.test.cjs` -> pass (152/152)
- `npm run lint` -> warnings only (pre-existing `react-hooks/exhaustive-deps`; no new lint errors)
Follow-ups:
- Continue P2-S2 with remaining legacy relay GET candidates (`createwatchedcases_api`, `deletewatchedcasesproxy_api`, `getadvancedsearch_api`, `getbasicsearch_by_address_api`, `getbasicsearch_by_lparref_api`, `getdnscoords_api`).