From c2e14cab31d02dc1eb981e2cd3a5bc4194bc48b9 Mon Sep 17 00:00:00 2001 From: robbond Date: Fri, 13 Mar 2026 17:57:25 +0000 Subject: [PATCH] TASK22028: update memory-bank for myportal and i18n follow-up --- memory-bank/activeContext.md | 8 ++++++ memory-bank/change-log.md | 30 ++++++++++++++++++++++ memory-bank/progress.md | 27 +++++++++++++++++++ memory-bank/refactor-plan-actions-index.md | 12 +++++++++ 4 files changed, 77 insertions(+) diff --git a/memory-bank/activeContext.md b/memory-bank/activeContext.md index 09b6101a..7776b830 100644 --- a/memory-bank/activeContext.md +++ b/memory-bank/activeContext.md @@ -541,6 +541,14 @@ - `documentDirectService.deleteAwaitingSubmissionsFromBlob` - `documentDirectService.deleteMyRepresentationsFromBlob` +## Follow-up status (2026-03-13 — myportal + i18n alignment) + +- Updated myportal representation delete call sites to pass `caseRef`: + - `components/myportal/topthree_reps.js` + - `components/myportal/viewall.js` +- Applied small view-all presentation cleanup and watched-case refresh filtering adjustment. +- Added missing `myportal` namespace mapping in `i18n.js` for `/newappeal/[appealtypes]`. + ## Likely next steps 1. Stabilize and simplify breadcrumb/back-link decision logic with focused regression checks. diff --git a/memory-bank/change-log.md b/memory-bank/change-log.md index dbc43589..2aafa659 100644 --- a/memory-bank/change-log.md +++ b/memory-bank/change-log.md @@ -1082,3 +1082,33 @@ Validation: Follow-ups: - Keep allow-list expansion path-scoped and driven by concrete browser-call requirements only. + +--- + +### CL-030: Follow-up fix — myportal delete caseRef alignment + i18n namespace + +date: 2026-03-13 +author: Cline +scope: `components/myportal/{viewall,topthree_reps}.js`, `i18n.js`, `memory-bank/*` +type: change +rationale: Align representation delete calls to stable case reference identifier and resolve missing locale namespace mapping for new-appeal route context. +impact: Prevents delete-call identifier mismatches in myportal representation flows and restores expected translation namespace availability for `/newappeal/[appealtypes]`. +status: completed + +Summary: + +- Updated delete-representation callers to pass `caseRef` instead of display/ticket values in: + - `components/myportal/topthree_reps.js` + - `components/myportal/viewall.js` +- Included related view-all styling/class tidy updates and watched-case list refresh filtering adjustment. +- Added missing `myportal` namespace for route key: + - `i18n.js` -> `/newappeal/[appealtypes]` + +Validation: + +- `node tests/phase7/service-behaviour.test.cjs` -> pass (12/12) +- `npm run lint` -> warnings only (pre-existing) + +Follow-ups: + +- Keep delete calls consistently keyed on case reference across portal/view-all/top-three variants. diff --git a/memory-bank/progress.md b/memory-bank/progress.md index 5461ff83..6075ffef 100644 --- a/memory-bank/progress.md +++ b/memory-bank/progress.md @@ -717,6 +717,33 @@ - `node tests/phase7/service-behaviour.test.cjs` -> **pass** (10/10) - `npm run lint` -> **warnings only** (pre-existing) +## Latest update (2026-03-13 — signer delete-flow follow-up) + +- Branch: `TASK22028-phase15-hardening-slice` +- Extended signer allow-list and browser signer usage for additional delete flows: + - `deleteWatchedCases` + - `deleteMyRepresentations` + - `deleteAwaitingSubmissionsFromBlob` + - `deleteMyRepresentationsFromBlob` + +### Validation snapshot (delete-flow follow-up) + +- `node tests/phase7/service-behaviour.test.cjs` -> **pass** (12/12) +- `node tests/phase14/service-behaviour.test.cjs` -> **pass** (9/9) +- `npm run lint` -> **warnings only** (pre-existing) + +## Latest update (2026-03-13 — myportal + i18n follow-up) + +- Branch: `TASK22028-phase15-hardening-slice` +- Delivered follow-up fixes: + - myportal representation delete calls now use `caseRef` in top-three and view-all flows + - missing `myportal` namespace added for `/newappeal/[appealtypes]` in `i18n.js` + +### Validation snapshot (myportal + i18n follow-up) + +- `node tests/phase7/service-behaviour.test.cjs` -> **pass** (12/12) +- `npm run lint` -> **warnings only** (pre-existing) + ## Outstanding risks / gaps - Navigation regressions across EN/CY + route query combinations. diff --git a/memory-bank/refactor-plan-actions-index.md b/memory-bank/refactor-plan-actions-index.md index cbca2cb2..31881604 100644 --- a/memory-bank/refactor-plan-actions-index.md +++ b/memory-bank/refactor-plan-actions-index.md @@ -565,6 +565,18 @@ Status key: `[x] done`, `[ ] pending` - Revert the follow-up commit for this slice to restore prior hashing behavior. +### Follow-up completion snapshot (2026-03-13 — myportal + i18n alignment) + +1. `[x]` Align myportal delete-representation calls to use `caseRef` +2. `[x]` Add missing i18n namespace mapping for `/newappeal/[appealtypes]` +3. `[x]` Validate + - phase7 behaviour tests pass (12/12) + - lint warnings only (pre-existing) + +### Follow-up rollback notes (myportal + i18n alignment) + +- Revert commit `d32d7d0` to restore prior myportal/i18n state. + ## Safe execution mode for migration chunks (required) To reduce terminal hangs during bulk migration work, run refactor chunks in **safe stepwise mode** instead of long chained commands.