Merged PR 2315: Auth stabilistatiion and hardening

Related work items: #23020

lib/newappeal/fileListHelpers.js

@@ -1,5 +1,5 @@
 export const mergeWithExistingFilesList = (buildAppealFilesArray, values) => {
-    return values.hasOwnProperty("filesList")
+    return Object.prototype.hasOwnProperty.call(values, "filesList")
         ? (buildAppealFilesArray.concat(values.filesList),
           buildAppealFilesArray.filter(function (item, idx) {
               return item.name;

lib/newappeal/loadNewAppealPage.js

@@ -7,7 +7,7 @@ import {
 } from "../../actions/services/referenceDataService";
 import { getProgressFromBlob } from "../../actions/services/documentService";
 import { getPersonalAccount } from "../../actions/services/accountService";
-import { getIP } from "../../actions/core/logger";
+import { consoleLogger, getIP } from "../../actions/core/logger";
 import { readFormXml } from "../forms/readFormXml";
 import { requireQueryParams } from "../routing/requireQueryParams";
 
@@ -29,6 +29,28 @@ export async function loadNewAppealPage(ctx) {
 
     const session = await getSession(ctx);
     if (!session) {
+        consoleLogger({
+            name: "NewAppealLoaderAuthGuard",
+            reasonCode: "NO_SESSION",
+            message: "loadNewAppealPage missing session; redirecting to signin"
+        });
+        return {
+            redirect: {
+                destination: "/auth/signin",
+                permanent: false
+            }
+        };
+    }
+
+    if (!session?.user?.id || !session?.user?.email) {
+        consoleLogger({
+            name: "NewAppealLoaderAuthGuard",
+            reasonCode: "NO_SESSION_USER",
+            message:
+                "loadNewAppealPage missing session user identity; redirecting to signin",
+            hasSessionUserId: !!session?.user?.id,
+            hasSessionUserEmail: !!session?.user?.email
+        });
         return {
             redirect: {
                 destination: "/auth/signin",
@@ -42,17 +64,76 @@ export async function loadNewAppealPage(ctx) {
     const loggedInUserIdent = session.user.id;
     const loggedInUserEmail = session.user.email;
 
-    const [appealTypeData, mandatoryFieldsData, pickListData] =
-        await Promise.all([
+    if (!loggedInUser) {
+        consoleLogger({
+            name: "NewAppealLoaderAuthGuard",
+            reasonCode: "NO_PINSUSER_COOKIE",
+            message:
+                "loadNewAppealPage missing pinsUser cookie identity; redirecting to signin"
+        });
+        return {
+            redirect: {
+                destination: "/auth/signin",
+                permanent: false
+            }
+        };
+    }
+
+    let appealTypeData;
+    let mandatoryFieldsData;
+    let pickListData;
+    let blobProgress;
+    let accountDetails;
+
+    try {
+        [
+            appealTypeData,
+            mandatoryFieldsData,
+            pickListData,
+            blobProgress,
+            accountDetails
+        ] = await Promise.all([
             getAppealsTypesForNewAppeal(),
             getMandatoryFields(query.appealtypes),
-            getPickLists(query.appealtypes)
+            getPickLists(query.appealtypes),
+            getProgressFromBlob(loggedInUserIdent, query.id),
+            getPersonalAccount(loggedInUser)
         ]);
+    } catch (_error) {
+        consoleLogger({
+            name: "NewAppealLoaderDependencyFailure",
+            message:
+                "loadNewAppealPage dependency fetch failed; redirecting to /myportal",
+            appealType: query?.appealtypes,
+            hasCaseId: !!query?.id,
+            error: _error?.message
+        });
+        return {
+            redirect: {
+                destination: "/myportal",
+                permanent: false
+            }
+        };
+    }
 
-    const blobProgress = await getProgressFromBlob(loggedInUserIdent, query.id);
-    const accountDetails = await getPersonalAccount(loggedInUser);
-
-    const { xmlStr } = readFormXml(query.appealtypes);
+    let xmlStr = "";
+    try {
+        xmlStr = readFormXml(query.appealtypes).xmlStr;
+    } catch (_error) {
+        consoleLogger({
+            name: "NewAppealLoaderXmlReadFailure",
+            message:
+                "loadNewAppealPage XML read failed; redirecting to /myportal",
+            appealType: query?.appealtypes,
+            error: _error?.message
+        });
+        return {
+            redirect: {
+                destination: "/myportal",
+                permanent: false
+            }
+        };
+    }
 
     return {
         session,