Merged PR 2315: Auth stabilistatiion and hardening

Related work items: #23020

pages/myportal/dnsapplications.js

@@ -44,7 +44,6 @@ const Home = (props) => {
     let { t, lang } = useTranslation();
 
     const router = useRouter();
-    const { locale } = router;
     const { appealtypes } = router.query;
 
     return (
@@ -142,14 +141,12 @@ export const getServerSideProps = wrapper.getServerSideProps(
         getIP(req);
         console.log("query-", query);
 
-        const { cookies } = req;
-
         res.setHeader(
             "Cache-Control",
             "public, s-maxage=10, stale-while-revalidate=59"
         );
 
-        let loggedInUser = cookies.pinsUser;
+        let loggedInUser = req.cookies.pinsUser;
 
         let thisSession = await getSession(ctx);
 
@@ -163,8 +160,8 @@ export const getServerSideProps = wrapper.getServerSideProps(
             };
         } else {
             let [accountDetails, watchedCases] = await Promise.all([
-                await getPersonalAccount(loggedInUser),
-                await getWatchedCases(loggedInUser)
+                getPersonalAccount(loggedInUser),
+                getWatchedCases(loggedInUser)
             ]);
 
             // searchResultsObj =
@@ -178,9 +175,10 @@ export const getServerSideProps = wrapper.getServerSideProps(
 
             const showMapCheck = process.env.SHOWMAPS || false;
 
-            const [watchedCasesDetails] = await Promise.all([
-                await getDetails(watchedCases, "myWatchedCases")
-            ]);
+            const watchedCasesDetails = await getDetails(
+                watchedCases,
+                "myWatchedCases"
+            );
             const dnsCoords = await getDNSCoords();
             // store.dispatch(setSearchResults(searchResultsObj));
             // store.dispatch(setSearchDetails(searchDetailsObj));
@@ -201,7 +199,7 @@ export const getServerSideProps = wrapper.getServerSideProps(
 const getDetails = (resultsObj, detailsType) => {
     let detailsArr = [];
     resultsObj = resultsObj.value;
-    const detailsObj = resultsObj.map((searchDetail, index) => {
+    const detailsObj = resultsObj.map((searchDetail) => {
         if (searchDetail.pinswg_appealcasetype == null) {
             console.log(
                 detailsType != "myWatchedCases"