Merged PR 2315: Auth stabilistatiion and hardening

Related work items: #23020

pages/myportal/searchresults.js

@@ -77,14 +77,12 @@ const Home = (props) => {
 
 export const getServerSideProps = wrapper.getServerSideProps(
     (store) => async (ctx) => {
-        const { query, req, res } = ctx;
+        const { query, req } = ctx;
         getIP(req);
         console.log("query-", query);
 
         const { cookies } = req;
 
-        let loggedInUserCookie = cookies.pinsUser;
-
         let thisSession = await getSession(ctx);
 
         const showReps = process.env.SHOWREPRESENTATIONS || false;
@@ -100,9 +98,7 @@ export const getServerSideProps = wrapper.getServerSideProps(
                 }
             };
         } else {
-            let [loggedInUser] = await Promise.all([
-                await getPortalLogin(thisSession.user.email)
-            ]);
+            let loggedInUser = await getPortalLogin(thisSession.user.email);
 
             //console.log("sssss", searchResultsObj);
 
@@ -113,8 +109,8 @@ export const getServerSideProps = wrapper.getServerSideProps(
             //console.log("sssss", loggedInUser);
 
             const [accountDetails, watchedCasesDetails] = await Promise.all([
-                await getPersonalAccount(loggedInUser),
-                await getDetails(watchedCases, "myWatchedCases")
+                getPersonalAccount(loggedInUser),
+                getDetails(watchedCases, "myWatchedCases")
             ]);
             store.dispatch(setAccountDetails(accountDetails));
             store.dispatch(setSearch(query.q));
@@ -136,7 +132,7 @@ export const getServerSideProps = wrapper.getServerSideProps(
 const getDetails = (resultsObj, detailsType) => {
     let detailsArr = [];
     resultsObj = resultsObj.value;
-    const detailsObj = resultsObj.map((searchDetail, index) => {
+    const detailsObj = resultsObj.map((searchDetail) => {
         if (searchDetail.pinswg_appealcasetype == null) {
             console.log(
                 detailsType != "myWatchedCases"