TASK22057: phase17 closeout hash/input consistency hardening

This commit is contained in:
2026-03-13 18:43:42 +00:00
parent 36d35f9549
commit daa38d6459
7 changed files with 411 additions and 33 deletions
+19
View File
@@ -549,6 +549,25 @@
- Applied small view-all presentation cleanup and watched-case refresh filtering adjustment.
- Added missing `myportal` namespace mapping in `i18n.js` for `/newappeal/[appealtypes]`.
## Phase 17 closeout status (2026-03-13)
- Working branch created from `origin/SIPS-Development`:
- `TASK22057-phase17-hardening-closeout`
- Completed remaining closeout hardening slice for sensitive file handlers:
- `pages/api/file/generatepdf.js`
- `pages/api/file/generateappealpdf.js`
- `pages/api/file/createappealcompletemessageproxy_api.js`
- Applied consistency-only updates:
- standardized missing/invalid hash 400 negative paths in selected PDF handlers
- standardized required-input 400 guards where route contract requires it
- removed noisy direct logs from touched sensitive handlers
- preserved existing response shapes/signatures
- Added focused behavioural coverage:
- `tests/phase17/service-behaviour.test.cjs` (6/6 passing)
- includes missing/invalid hash negative-path checks and valid-input proxy happy-path contract check
- Broader consistency scan note:
- no additional broad hash/400 consistency gaps were identified in `pages/api/endpoint/**` in this pass.
## Likely next steps
1. Stabilize and simplify breadcrumb/back-link decision logic with focused regression checks.