From dcdda6eb6ea43a6d47171f6e9d4d757d9f2058f5 Mon Sep 17 00:00:00 2001
From: rdbsolutions <rob@rdbsolutions.co.uk>
Date: Wed, 21 Feb 2024 17:19:01 +0000
Subject: [PATCH] misc accessibility fixes

---
 components/case/documents.js                             | 1 -
 components/case/representation/representationElements.js | 6 ++++--
 components/newappeal/createCase.js                       | 2 +-
 components/pdftemplates/statement_pdf.js                 | 5 +----
 components/search/dnssearchresults.js                    | 5 ++---
 components/search/searchresults.js                       | 9 ++++-----
 locales/cy/myrepresentations.json                        | 2 +-
 locales/en/myrepresentations.json                        | 2 +-
 8 files changed, 14 insertions(+), 18 deletions(-)

diff --git a/components/case/documents.js b/components/case/documents.js
index 78c238eb..8b41d60b 100644
--- a/components/case/documents.js
+++ b/components/case/documents.js
@@ -73,7 +73,6 @@ const DocumentDetails = (props) => {
                                     className="govuk-select"
                                     id="showDocumentType"
                                     name="showDocumentType"
-                                    datafield="showDocumentType"
                                 >
                                     <option value="all">
                                         {router.locale == "cy"
diff --git a/components/case/representation/representationElements.js b/components/case/representation/representationElements.js
index c619aaeb..406db598 100644
--- a/components/case/representation/representationElements.js
+++ b/components/case/representation/representationElements.js
@@ -122,6 +122,7 @@ export const RenderRadioListWithText = ({
     ...custom
 }) => {
     const required = (value) => (value ? undefined : "Required");
+    const router = useRouter();
 
     return (
         <>
@@ -197,8 +198,9 @@ export const RenderRadioListWithText = ({
                                                     "_Comments"
                                                 }
                                             >
-                                                Please give further details for
-                                                your this selection
+                                                {router.locale == "en"
+                                                    ? "Please give further details for this selection"
+                                                    : "Rhowch fanylion pellach am y dewis hwn"}
                                             </label>
                                             <Field
                                                 name={
diff --git a/components/newappeal/createCase.js b/components/newappeal/createCase.js
index 838f6fb9..d65ba695 100644
--- a/components/newappeal/createCase.js
+++ b/components/newappeal/createCase.js
@@ -86,7 +86,7 @@ let CreateCase = (props) => {
                             {...input}
                             className="govuk-select govuk-input--error"
                             id="lpatypes"
-                            name={name}
+                            name="lpatypes"
                             //onChange={(e) => props.onChangeSelectLPA(e)}
                         >
                             <option value="" disabled defaultValue>
diff --git a/components/pdftemplates/statement_pdf.js b/components/pdftemplates/statement_pdf.js
index 395487e7..d4ceff1f 100644
--- a/components/pdftemplates/statement_pdf.js
+++ b/components/pdftemplates/statement_pdf.js
@@ -11,10 +11,7 @@ import ReactPDF, {
 import { createElement } from "react";
 import Html from "react-pdf-html";
 import { getFormCollectionByID } from "../../components/utils";
-import useTranslation from "next-translate/useTranslation";
-
 import renderers, { renderBlock } from "react-pdf-html/dist/renderers";
-
 import transLookupCY from "../../locales/cy/myrepresentations.json";
 import transLookupEN from "../../locales/en/myrepresentations.json";
 import { JSONPath as jsonpath } from "jsonpath-plus";
@@ -118,7 +115,7 @@ export const statement_pdf = ({ docProps }) => {
     let datestr = values.pinswg_name.split("-");
     let signedDate = datestr[2] + "/" + datestr[1] + "/" + datestr[0];
     let appealTypeValue = getFormCollectionByID(values.appealType);
-    let { t } = useTranslation();
+
     return (
         <Document>
             <Page size="A4" style={styles.page} wrap>
diff --git a/components/search/dnssearchresults.js b/components/search/dnssearchresults.js
index 782ae552..09d8a7e2 100644
--- a/components/search/dnssearchresults.js
+++ b/components/search/dnssearchresults.js
@@ -308,9 +308,8 @@ const DNSSearchResults = (props) => {
                                     {t("search:searchresults-status-label")}
                                 </button>
                             </dd>
-                            {myportal == true && (
-                                <dd className="govuk-summary-list__key govuk-!-font-size-16 govuk-summary-list__action"></dd>
-                            )}
+
+                            <dd className="govuk-summary-list__key govuk-!-font-size-16 govuk-summary-list__action"></dd>
                         </div>
 
                         {showSpinnerState == true ? (
diff --git a/components/search/searchresults.js b/components/search/searchresults.js
index 2b9a6607..85f1b4b2 100644
--- a/components/search/searchresults.js
+++ b/components/search/searchresults.js
@@ -254,9 +254,8 @@ const SearchResults = (props) => {
                                 {t("search:searchresults-status-label")}
                             </button>
                         </dd>
-                        {myportal == true && (
-                            <dd className="govuk-summary-list__key govuk-!-font-size-16 govuk-summary-list__action"></dd>
-                        )}
+
+                        <dd className="govuk-summary-list__key govuk-!-font-size-16 govuk-summary-list__action"></dd>
                     </div>
                     {showSpinnerState == true ? (
                         <div className="govuk-summary-list__row">
@@ -560,7 +559,7 @@ const SearchResults = (props) => {
                                                         "case:watch-this-case-link"
                                                     )}
                                                 </span>
-                                                <span
+                                                <button
                                                     className="govuk-summary-list__actionLink watchLink"
                                                     onClick={() => {
                                                         confirm(
@@ -589,7 +588,7 @@ const SearchResults = (props) => {
                                                     )}
                                                 >
                                                     <span className="eye"></span>
-                                                </span>
+                                                </button>
                                             </dd>
                                         )}
                                 </div>
diff --git a/locales/cy/myrepresentations.json b/locales/cy/myrepresentations.json
index f45f5eaa..d6f2c39f 100644
--- a/locales/cy/myrepresentations.json
+++ b/locales/cy/myrepresentations.json
@@ -15,7 +15,7 @@
     "questionnaire-publish-policy-label": "Sylwch y gall holl ddogfennau holiadur gael eu cyhoeddi yn unol â'n Polisi Cyhoeddi. Os bydd eich holiadur yn cynnwys unrhyw wybodaeth sensitif neu wybodaeth a allai fod yn ddifenwol, efallai y caiff ei olygu cyn ei gyhoeddi",
     "add-files-label": "Ychwanegwch eich ffeiliau",
     "capacity-para-one": "Mae'r ffurflen hon yn eich galluogi i gyflwyno sylwadau ar achos i Benderfyniadau Cynllunio ac Amgylchedd Cymru.",
-    "capacity-para-two": "Sylwch fod angen gwneud sylwadau gan bartïon â diddordeb o fewn yr amserlen. Mae hwn i'w weld ar y &lsquo;Crynodeb Achos&lsquo; tudalen. Gall sylwadau a gyflwynir ar ôl y dyddiad hwn gael eu hystyried yn annilys.",
+    "capacity-para-two": "Sylwch fod angen gwneud sylwadau gan bartïon â diddordeb o fewn yr amserlen. Mae hwn i'w weld ar y \"Crynodeb Achos\" tudalen. Gall sylwadau a gyflwynir ar ôl y dyddiad hwn gael eu hystyried yn annilys.",
     "capacity-select-your-details": "Eich manylion",
     "capacity-select-what-capacity-label": "Ym mha rinwedd ydych chi am gyflwyno sylwadau ar yr achos hwn?",
     "capacity-options-arr-appellant": "Apelydd",
diff --git a/locales/en/myrepresentations.json b/locales/en/myrepresentations.json
index 34f66a99..e01df468 100644
--- a/locales/en/myrepresentations.json
+++ b/locales/en/myrepresentations.json
@@ -15,7 +15,7 @@
     "questionnaire-publish-policy-label": "Please note that all questionnaire documents may be published in line with our Publishing Policy. Should your questionnaire include any sensitive information or potentially defamatory information, it may be redacted before publishing",
     "add-files-label": "Add your files",
     "capacity-para-one": "This form enables you to submit comments on a case to Planning and Environment Decisions Wales.",
-    "capacity-para-two": "Please note that comments from interested parties need to be made within the timetable. This can be found on the previous &lsquo;Case Summary&lsquo; page. Comments submitted after this date may be considered invalid.",
+    "capacity-para-two": "Please note that comments from interested parties need to be made within the timetable. This can be found on the previous \"Case Summary\" page. Comments submitted after this date may be considered invalid.",
     "capacity-select-your-details": "Your details",
     "capacity-select-what-capacity-label": "In what capacity do you wish to make representations on this case?",
     "capacity-options-arr-appellant": "Appellant",