Merged PR 2240: refactor(newappeal): simplify nested prop boundaries (Slice 7)

refactor(newappeal): simplify nested prop boundaries (Slice 7)

Related work items: #22588

components/newappeal/complete.js

@@ -10,9 +10,13 @@ import { setCurrentSection } from "../../store/appealType/action";
 import { getFormCollectionByID } from "../utils";
 
 let CompleteAppeal = (props) => {
+    const legacyProps = props.props;
+    const legacyFormState = legacyProps.form;
+    const legacyAccountDetails = legacyProps.accountDetails;
+
     useEffect(() => {
         let incidentId = props.appealType.caseReference.incidentid;
-        let updateBody = props.props.form.appealForm.values;
+        let updateBody = legacyFormState.appealForm.values;
 
         let appTypeCollection = getFormCollectionByID(
             props.appealType.appealTypeID
@@ -24,7 +28,7 @@ let CompleteAppeal = (props) => {
 
         Object.assign(updateBody, {
             "pinswg_Appellant@odata.bind":
-                "/contacts(" + props.props.accountDetails.loggedinUserId + ")",
+                "/contacts(" + legacyAccountDetails.loggedinUserId + ")",
             "pinswg_LocalPlanningAuthority@odata.bind":
                 "/accounts(" + props.appealType.appealLPA + ")",
             "pinswg_name": props.appealType.caseReference.ticketnumber,
@@ -44,10 +48,10 @@ let CompleteAppeal = (props) => {
             : "618e0463-b092-4733-a024-bf8a3bbde808";
 
         const reference = "PEDW-COMPLETE" + isWelsh && "-CY";
-        const emailAddress = props.props.accountDetails.loggedinUserEmail;
+        const emailAddress = legacyAccountDetails.loggedinUserEmail;
         const personalisation = {
             "caseReference": props.appealType.caseReference.ticketnumber,
-            "emailAddress": props.props.accountDetails.loggedinUserEmail,
+            "emailAddress": legacyAccountDetails.loggedinUserEmail,
             "linkExpiry": 10 * 60
         };
         sendCompletionEmailEffect(
@@ -68,12 +72,12 @@ let CompleteAppeal = (props) => {
         window.scrollTo({ top: 0, behavior: "smooth" });
     }, [
         props.appealType.caseReference,
-        props.props.form.appealForm.values,
+        legacyFormState.appealForm.values,
         props.appealType.appealLPA,
-        props.props.accountDetails.loggedinUserId,
+        legacyAccountDetails.loggedinUserId,
         props.appealType.appealTypeID,
-        props.props.accountDetails.loggedinUserEmail,
-        props.props.accountDetails.containerID
+        legacyAccountDetails.loggedinUserEmail,
+        legacyAccountDetails.containerID
     ]);
 
     let { t } = useTranslation();