Commit Graph
24 Commits
Author SHA1 Message Date
Robert Bond 0de9268255 Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change)
## Summary

This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.

This refactor was executed in controlled slices with regression validation at each step.

## Scope

Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)

## Behaviour

No intended behavioural changes.

The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity

## Validation

Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity

Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)

## Risk

Low:
- changes are structural only
- no business logic changes
- no contract changes

## Rollback

Safe rollback via reverting this merge commit.

## Notes

This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.

Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
2026-04-13 13:09:12 +00:00
robbond 96946ed205 Extract additional routes in to shared renderer factory 2026-04-09 13:56:17 +01:00
robbond ad0d2bf285 docs(governance): track context docs and add relay rollout controls 2026-03-24 12:26:32 +00:00
robbond 51eb9b5a4f TASK22211: version memory-bank and backfill change-log stream 2026-03-23 12:32:44 +00:00
robbond a67f84a99f update error and response handling 2026-03-23 10:28:19 +00:00
robbond 2950ce788a refactor actions into core modules and grouped services 2026-03-12 07:30:40 +00:00
robbond 7da20386dd config 2026-02-20 11:59:09 +00:00
robbond 3f4bd8d52e partial synch with ph2 updates 2025-11-28 08:45:13 +00:00
robbond cb2ade03b4 update git ignore 2025-07-08 09:08:35 +01:00
robbond 8713317404 Merged PR 1717: merge dev to sips
Related work items: #12956
2025-07-08 08:58:41 +01:00
robbond 46876cdff6 16185 and 16630 language switching 2025-06-13 12:58:38 +01:00
robbond 4fc0917b78 update package lock 2025-05-12 17:33:23 +01:00
robbond 1edf633aae updated git ignore 2025-04-09 13:38:18 +01:00
robbond c874bb4f59 updated authentication for welsh url 2025-04-09 10:24:44 +01:00
robbond 4ae78dec72 remove www text on reps 2025-02-27 13:05:16 +00:00
robbond a362a2c00f clean up debug info, reduce page weight 2024-09-26 10:07:27 +01:00
robbond 88ab1f3fc5 mobile issues in header 2024-08-13 12:02:46 +01:00
robbond 08ddfa386a added save button to save a partial rep before completion 2024-05-08 10:05:11 +01:00
robbond 1049da3787 update path in queue message inc url 2024-03-12 18:10:44 +00:00
robbond f78210c24c update gitignore 2023-09-26 13:40:02 +01:00
robbond be476394c8 added validation methods 2021-07-23 14:32:57 +01:00
robert 5f7a572b91 added in basic api request 2021-07-05 11:43:51 +01:00
robbond b488caa013 Added search and results mocks 2021-06-29 16:35:11 +01:00
robbond c712d41599 initial commit 2021-06-28 16:36:49 +01:00