Commit Graph
165 Commits
Author SHA1 Message Date
Robert Bond e864049bec Merged PR 2449: language helper
Related work items: #23754
2026-07-01 11:29:15 +00:00
Robert Bond ff699735c7 Merged PR 2442: remove lodash dependecies on _.has
Related work items: #23754
2026-06-29 13:08:06 +00:00
Robert Bond d295a507ac Merged PR 2303: updated company name to pinswg_companyname
updated company name to pinswg_companyname

Related work items: #22774
2026-05-11 10:47:39 +00:00
Robert Bond 1a2c3ede3b Merged PR 2295: resolved lint warnings
resolved lint warnings

Related work items: #22873
2026-05-05 17:13:53 +00:00
Robert Bond d2e88b57d8 Merged PR 2288: add in company name for appellant and autofill agent details in new appeal
add in company name for appellant and autofill agent details in new appeal

Related work items: #22842
2026-04-30 16:25:03 +00:00
Robert Bond 421adafca3 Merged PR 2280: fix in place for app error
fix in place for app error

Related work items: #22834
2026-04-28 15:48:32 +00:00
Robert Bond 0de9268255 Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change)
## Summary

This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.

This refactor was executed in controlled slices with regression validation at each step.

## Scope

Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)

## Behaviour

No intended behavioural changes.

The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity

## Validation

Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity

Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)

## Risk

Low:
- changes are structural only
- no business logic changes
- no contract changes

## Rollback

Safe rollback via reverting this merge commit.

## Notes

This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.

Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
2026-04-13 13:09:12 +00:00
robbond 3bc3759a48 welsh downloadable new appeal form 2026-03-30 12:35:41 +01:00
robbond 2c4d645d56 22151 multiple files issue 2026-03-27 11:25:41 +00:00
robbond c64c47ca1f languge check for relevant template language 2026-03-17 10:29:00 +00:00
robbond 7c84344d5d applied downloadable checkbox on submit of new appeal 2026-03-16 13:58:02 +00:00
robbond 344b6efed1 chore(lint): unblock next lint and fix current eslint errors 2026-03-13 06:24:38 +00:00
robbond a0a633a9ea refactor phase 3a components chunk 1 targeted actions imports 2026-03-12 12:13:29 +00:00
robbond e6b0b0763a 21099 update filename validation with # 2026-01-20 15:20:54 +00:00
robbond 83dc4e12e3 refactor appeal for new and resume 2026-01-15 13:21:11 +00:00
robbond 9241fe0b84 updated restriction to disallow partial reps and appeals from being submitted when not docapi 2026-01-15 13:20:07 +00:00
robbond dfaa54a6cf updated start date validation to be dependant on value of dateofapplication 2026-01-06 12:47:56 +00:00
robbond 103c548e32 added scrolltop 2025-07-08 09:08:13 +01:00
robbond 89f1691c8f 16580 contact fields for owners and tenants 2025-06-11 18:26:14 +01:00
robbond a80fa87ea2 refactor 2025-06-11 13:05:18 +01:00
robbond cf0c05ff6a removed comments 2025-04-16 14:55:06 +01:00
robbond 35f19bd975 removed comments 2025-04-16 14:48:15 +01:00
robbond d882e65071 uodated queries to sort deep recursion 2025-04-16 08:44:45 +01:00
robbond 87f0dcd811 changes sandbox: {} to eval: true, caused errors in evaluated queries 2025-04-15 17:25:14 +01:00
robbond 05f791e6a8 update jsonpath for csp fix 2025-04-15 12:59:27 +01:00
robbond 608348910f rep defect 46 2025-02-07 12:45:30 +00:00
robbond bedaa79281 rep defect 42, questionnaire defect 67, enf defect 16 2025-02-03 17:04:05 +00:00
robbond 6dded01501 reps defect 43 - also handles not submitting reps when date passed 2025-01-30 14:12:15 +00:00
robbond cf7654127b uat defect 61 lang pref for agent 2025-01-22 10:00:22 +00:00
robbond 32a3542f79 rep defect 42,questioinnaire defect 67, enf defect 16 2025-01-21 16:04:52 +00:00
robbond 232fd4685d uat defect 131 - link in new tab 2025-01-14 16:58:47 +00:00
robbond 9ffbe49777 uat defect 115 2025-01-14 10:57:09 +00:00
robbond 61e74a5da8 uat defect 124 amend 2025-01-11 08:22:33 +00:00
robbond 8b175b114d uat defect 124 2025-01-11 08:14:14 +00:00
robbond 8e6296e4b1 uat defect 120 2025-01-05 09:24:22 +00:00
robbond b6147645b2 hide owner and tenants if empty on check and pdf 2024-12-19 09:41:15 +00:00
robbond ead00dda76 validation message translations is required 2024-12-16 11:48:57 +00:00
robbond 7ec0607d6c path to getbloblistproxy fails csr policy and uncommented saving of appeal progess data 2024-12-12 09:43:12 +00:00
robbond beb5d6f809 file upload fix... limit to 210mb updates file list from storage account 2024-12-11 11:25:06 +00:00
robbond dcb6171dc1 multiple file upload issues capped at 210mb for now 2024-12-10 15:09:04 +00:00
robbond 19310b8145 welsh changes 2024-12-05 16:34:48 +00:00
robbond b668f323fe fix for new appeal and reps updates 2024-12-04 19:30:18 +00:00
robbond 499a1e9527 if agent dont change to appellant on submit appeal 2024-12-02 18:50:55 +00:00
robbond 7c95f679ba max 5 owners or tenants in field arry 2024-12-02 18:49:15 +00:00
robbond f9310d655b defect 82 removed colons 2024-12-02 17:06:59 +00:00
robbond f37290f489 emoji checker on text and multiline 2024-12-02 15:56:18 +00:00
robbond b98a310edc appeal pdf fixes and owners 2024-11-28 12:53:50 +00:00
robbond b423bb0cea updatd documents needed list 2024-11-28 06:30:24 +00:00
robbond 7b6862c350 updated validation for cost applciation 2024-11-27 11:13:31 +00:00
robbond 85f323d580 uat fixes 2024-11-27 11:00:12 +00:00