 Robert Bond
|
0de9268255
|
Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change)
## Summary
This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.
This refactor was executed in controlled slices with regression validation at each step.
## Scope
Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)
## Behaviour
No intended behavioural changes.
The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity
## Validation
Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity
Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)
## Risk
Low:
- changes are structural only
- no business logic changes
- no contract changes
## Rollback
Safe rollback via reverting this merge commit.
## Notes
This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.
Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
|
2026-04-13 13:09:12 +00:00 |
|
 robbond
|
d3f4dda8af
|
refactor(breadcrumbs): extract representation route-state renderer group
|
2026-04-09 15:16:01 +01:00 |
|
|
robbond
|
cebd47bf1c
|
refactor(breadcrumbs): map step-back route branches into renderer group
|
2026-04-09 15:03:19 +01:00 |
|
|
robbond
|
0b905f9374
|
refactor(breadcrumbs): extract callback route renderers into mapped groups
|
2026-04-09 14:57:47 +01:00 |
|
|
robbond
|
0cd78e6f46
|
22541 harden breadcrumb mapped route resolver against invalid entries
|
2026-04-09 14:45:12 +01:00 |
|
|
robbond
|
2a84056a76
|
22541 extract new appeal breadcrumb branch into mapped renderer group
|
2026-04-09 14:39:30 +01:00 |
|
|
robbond
|
17795f20c7
|
22541 extract deterministic case breadcrumb branches into factory maps
|
2026-04-09 14:33:54 +01:00 |
|
|
robbond
|
8edd23d621
|
22541 compose mapped breadcrumb groups in factory and add null fallback guard
|
2026-04-09 14:30:03 +01:00 |
|
|
robbond
|
96946ed205
|
Extract additional routes in to shared renderer factory
|
2026-04-09 13:56:17 +01:00 |
|
|
robbond
|
c264830934
|
Extract case detail breadcrumb routes into shared renderer factory
|
2026-04-09 13:16:56 +01:00 |
|
|
robbond
|
062cd23463
|
Refactor breadcrumbs to use factory-based route renderers
|
2026-04-09 12:08:36 +01:00 |
|
|
robbond
|
5f6dde782a
|
22541 extract breadcrumb route-map helpers and add precedence guard tests
|
2026-04-09 10:25:47 +01:00 |
|
|
robbond
|
f447aa19ea
|
22541 add bundled case breadcrumb state resolver
|
2026-04-09 09:28:54 +01:00 |
|
|
robbond
|
59d3ed287c
|
22541 expand breadcrumb route-state helpers for label and dns path reuse
|
2026-04-09 09:26:19 +01:00 |
|
|
robbond
|
1c06ef1639
|
22541 extract breadcrumb route-state helper and align phase22 auth locale test
|
2026-04-09 09:23:22 +01:00 |
|
|
robbond
|
c4ad9ab7a2
|
refactor(actions): complete priority-1 consumer import migration pass
|
2026-03-12 13:26:48 +00:00 |
|
|
robbond
|
83dc4e12e3
|
refactor appeal for new and resume
|
2026-01-15 13:21:11 +00:00 |
|