Commit Graph
29 Commits
Author SHA1 Message Date
Robert Bond 1a2c3ede3b Merged PR 2295: resolved lint warnings
resolved lint warnings

Related work items: #22873
2026-05-05 17:13:53 +00:00
Robert Bond d2e88b57d8 Merged PR 2288: add in company name for appellant and autofill agent details in new appeal
add in company name for appellant and autofill agent details in new appeal

Related work items: #22842
2026-04-30 16:25:03 +00:00
Robert Bond 0de9268255 Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change)
## Summary

This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.

This refactor was executed in controlled slices with regression validation at each step.

## Scope

Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)

## Behaviour

No intended behavioural changes.

The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity

## Validation

Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity

Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)

## Risk

Low:
- changes are structural only
- no business logic changes
- no contract changes

## Rollback

Safe rollback via reverting this merge commit.

## Notes

This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.

Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
2026-04-13 13:09:12 +00:00
robbond cf7654127b uat defect 61 lang pref for agent 2025-01-22 10:00:22 +00:00
robbond ead00dda76 validation message translations is required 2024-12-16 11:48:57 +00:00
robbond b668f323fe fix for new appeal and reps updates 2024-12-04 19:30:18 +00:00
robbond f37290f489 emoji checker on text and multiline 2024-12-02 15:56:18 +00:00
robbond 85f323d580 uat fixes 2024-11-27 11:00:12 +00:00
robbond 8f84ae8d8a uat fixes 2024-11-26 09:18:53 +00:00
robbond 795dc5a39d copy changes from review 2024-08-09 13:14:54 +01:00
robbond be99db0774 improved error loggin and updated imports to fix build failure 2024-06-19 15:06:28 +01:00
robbond b0e2bb6e14 remove unused imports 2024-06-19 06:32:38 +01:00
robbond 300a45ee0f console log tidying 2024-06-05 19:51:43 +01:00
robbond 33d3ab0fda added scroll top to next step 2024-05-07 09:46:38 +01:00
robbond e2edee35c6 content amends for create appeal 2024-03-26 11:36:35 +00:00
robbond 4d037ffeb8 10489 submission fix 2024-02-27 17:41:28 +00:00
robbond 114f57aa5d Accessibility amends for new appeal 2024-02-19 16:53:58 +00:00
robbond 60ac61b23e update submissions card with lpa ref 2024-02-06 09:50:55 +00:00
robbond 89c38fe4c9 added agent details to new appeal pdf 2024-01-23 13:14:52 +00:00
robbond 5f82c59abb rich text field and pdf create for appeal 2024-01-16 14:23:11 +00:00
robbond 34c3e06ee3 changed order of language pref welsh first 2023-08-08 15:50:37 +01:00
robbond 6be6a02101 cleared build warnings and format console message 2022-10-18 11:52:55 +01:00
robbond 7e03dcb266 moved field component up to stop rerender 2022-06-21 07:34:22 +01:00
robbond b3ce573c9c welsh trans for validation message 2022-06-14 18:21:47 +01:00
robbond cb9995da75 added hcas diagnostic choice 2022-06-14 17:08:11 +01:00
robbond 9d90b7f0a8 check form updates 2022-06-07 14:36:47 +01:00
robbond f2e71c0b54 cleared debug, updated new appeal add about you 2022-05-31 10:15:03 +01:00
robbond d63d87aa3e build fix 2022-04-07 08:11:40 +01:00
robbond 093cba5d70 added form ordering and validation for s78 2022-04-06 16:52:22 +01:00