robbond/pedwfrontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,066 Commits 6 Branches 3 Tags
79e6dfade96cf8011f4b3940de104eefd623197f
Commit Graph
701 Commits
Author SHA1 Message Date
Robert Bond e864049bec Merged PR 2449: language helper 
Related work items: #23754
 2026-07-01 11:29:15 +00:00
Robert Bond ff699735c7 Merged PR 2442: remove lodash dependecies on _.has 
Related work items: #23754
 2026-06-29 13:08:06 +00:00
Robert Bond 94b19f9697 Merged PR 2432: Add myportal API grouping facade read slice 
Add myportal API grouping facade read slice

Related work items: #23754
 2026-06-25 09:37:01 +00:00
Robert Bond a1b89d19b8 Merged PR 2431: Add case details API grouping facade 
Add case details API grouping facade

Related work items: #23754
 2026-06-25 09:22:12 +00:00
Robert Bond a266fa5428 Merged PR 2429: Add public search API grouping facade slice 
Add public search API grouping facade slice

Related work items: #23754
 2026-06-25 08:48:43 +00:00
Robert Bond 33dcb6b863 Merged PR 2428: Add documents API grouping facade slice 
Add documents API grouping facade slice

Related work items: #23754
 2026-06-25 08:24:58 +00:00
Robert Bond 153f0d679e Merged PR 2427: update api facade 
Related work items: #23754
 2026-06-25 08:11:14 +00:00
Robert Bond 5483c4cdf2 Merged PR 2426: added var to summary map and welsh translatioins 
added var to summary map and welsh translatioins

Related work items: #23879
 2026-06-24 17:10:22 +00:00
Robert Bond c98bbfc321 Merged PR 2424: varibale for dmw mapping version 
varibale for dmw mapping version

Related work items: #23879
 2026-06-24 14:43:08 +00:00
Robert Bond 6d0bc35612 Merged PR 2420: added welsh translations of api endpoints 
added welsh translations of api endpoints

Related work items: #23879
 2026-06-23 10:38:24 +00:00
Robert Bond d7bb1acb10 Merged PR 2414: welsh version of contact us and heading for rep heading for IP rep type 
welsh version of contact us and heading for rep heading for IP rep type

Related work items: #23484, #23910
 2026-06-22 12:44:36 +00:00
Robert Bond 475aa965b4 Merged PR 2395: helpers for dashboard domain layer 
Related work items: #23754
 2026-06-17 16:06:09 +00:00
Robert Bond ca244e5de1 Merged PR 2392: updated project types for new sub grid 
updated project types for new sub grid

Related work items: #23752
 2026-06-16 17:44:04 +00:00
Robert Bond 3efaafdb72 Merged PR 2388: added updated copy for contact us 
added updated copy for contact us

Related work items: #23482, #23483
 2026-06-16 08:25:05 +00:00
Robert Bond 628b2b71fd Merged PR 2385: update unsubscribe 
update unsubscribe

Related work items: #23796
 2026-06-11 13:04:21 +00:00
Robert Bond 7b1faf0bac Merged PR 2382: missing import 
missing import

Related work items: #23780
 2026-06-10 12:41:04 +00:00
Robert Bond c6e42fc314 Merged PR 2381: ROW case stage updates 
Related work items: #23564, #23779, #23780
 2026-06-10 10:12:11 +00:00
Robert Bond 7e47340326 Merged PR 2377: added enlarge map view on dnsapplication list 
added enlarge map view on dnsapplication list

Related work items: #23774
 2026-06-09 10:04:32 +00:00
Robert Bond 9595ad86df Merged PR 2374: addeding domain layer extrraction 
# Summary

This PR introduces a **Case Lifecycle Domain Boundary** to centralize lifecycle decision logic and reduce coupling within the appeals application.

The work is **behaviour-preserving** and introduces no intentional changes to business rules, CRM integrations, translations, dashboards, API routes, or user-facing functionality.

## What was added

New lifecycle boundary:

```text
lib/domain/case-lifecycle/
```

Key responsibilities extracted:

- Specialist process normalization
- Appeal type mapping
- Specialist process stage override mapping
- Stage case-type resolution
- Stage catalogue lookup
- Closed-case status recognition
- Lifecycle stage index resolution
- Lifecycle stage status assignment

## Behaviour preserved

Characterization tests were added before each extraction to preserve:

- Appeal type mapping and aliases
- Specialist process handling
- Lifecycle stage progression
- Closed-case handling
- Status assignment (`complete`, `in-progress`, `not-started`)
- Existing ROW behaviour
- Existing `statuscode` lifecycle semantics

Closed-case recognition remains unchanged for:

```text
1000
5
6
846040013
846040059
846040060
```

## Documentation

Added:

```text
lib/domain/case-lifecycle/README.md
```

Documenting:

- Boundary ownership
- Non-goals
- Lifecycle invariants
- Known architectural constraints
- Future extraction roadmap

## Testing

Added lifecycle characterization coverage for:

- Stage wrapper behaviour
- Specialist process normalization
- Appeal type mapping
- Specialist process stage mapping
- Stage case-type resolution
- Stage catalogue lookup
- Progress behaviour
- Closed-case status handling
- Stage index resolution
- Stage status assignment

## Validation

- Lifecycle characterization tests passed
- `npm run lint` passed with no errors

## Out of Scope

No changes to:

- Stage catalogue ownership
- Representation eligibility
- Dashboard calculations
- CRM/OData queries
- API routes
- Redux state
- EN/CY translations
- Event visibility logic

## Risk

**Low risk**

The refactor was delivered through small, characterization-first slices with no functional changes intended.

Related work items: #23527
 2026-06-08 09:34:30 +00:00
Robert Bond d0cae0fff1 Merged PR 2368: case stage ROW updates and case closed variants and adv search fix 
Related work items: #23551, #23555, #23559
 2026-06-03 12:44:59 +00:00
Robert Bond 18a05d4be8 Merged PR 2357: dashboards in admin for appeals and lpa 
dashboards in admin for appeals and lpa

Related work items: #23527
 2026-05-29 16:35:27 +00:00
Robert Bond b71a93076b Merged PR 2352: adjusted query to only show published 
adjusted query to only show published

Related work items: #23447
 2026-05-28 11:02:18 +00:00
Robert Bond 3f2b8807e7 Merged PR 2351: fix csp by making it server side 
Related work items: #23447
 2026-05-28 10:41:11 +00:00
Robert Bond 24cd7000f7 Merged PR 2350: added in count on case status dropdown 
added in count on case status dropdown

Related work items: #23447
 2026-05-28 09:02:30 +00:00
Robert Bond b6bd543527 Merged PR 2329: welsh link for events 
welsh link for events

Related work items: #23054
 2026-05-18 08:50:58 +00:00
Robert Bond c2ae6964f9 Merged PR 2318: auth stabilisation: extract shared myportal auth guard helper 
auth stabilisation: extract shared myportal auth guard helper

ntroduces a small shared SSR helper (resolveMyPortalAuthContext) to standardize common myportal auth/session guards (session presence, session user identity, and pinsUser cookie) with preserved reason-coded diagnostics and signin redirect behavior. Migrates exactly two loaders (pages/myportal/searchresults.js, pages/myportal/addresssearchresults.js) to use the helper while keeping loader-specific UPSTREAM_FAILURE and CONTACT_LOOKUP_FAILED logic unchanged.

Related work items: #23020
 2026-05-14 10:38:45 +00:00
Robert Bond 4fb62a6773 Merged PR 2317: Auth stabilisation: add reason-coded guards to MyPortal loaders 
Adds incremental auth/session hardening across myportal loader paths (loadMyPortalAppealPage, searchresults, addresssearchresults) with explicit guard ordering and reason-coded diagnostics for missing session, missing session identity, missing cookie identity, contact/account lookup failures, and upstream dependency failures. Includes targeted Phase22 loader guard tests and keeps redirect behaviour policy unchanged.

Related work items: #23020
 2026-05-14 10:27:12 +00:00
Robert Bond d0b2fd077a Merged PR 2315: Auth stabilistatiion and hardening 
Related work items: #23020
 2026-05-14 08:55:49 +00:00
Robert Bond d295a507ac Merged PR 2303: updated company name to pinswg_companyname 
updated company name to pinswg_companyname

Related work items: #22774
 2026-05-11 10:47:39 +00:00
Robert Bond 12a28a4be0 Merged PR 2296: added in statuscode and summary description 
added in statuscode and summary description

Related work items: #22612, #22616
 2026-05-07 10:20:28 +00:00
Robert Bond 1a2c3ede3b Merged PR 2295: resolved lint warnings 
resolved lint warnings

Related work items: #22873
 2026-05-05 17:13:53 +00:00
Robert Bond 0ff2d69ba6 Merged PR 2290: add guard rail to check for locale and ensure verify request is language spec... 
add guard rail to check for locale and ensure verify request is language specific

Related work items: #22303
 2026-05-05 08:25:17 +00:00
Robert Bond d2e88b57d8 Merged PR 2288: add in company name for appellant and autofill agent details in new appeal 
add in company name for appellant and autofill agent details in new appeal

Related work items: #22842
 2026-04-30 16:25:03 +00:00
Robert Bond b596374c3c Merged PR 2286: allowed LPAs to make statements 
allowed LPAs to make statements

Related work items: #22848
 2026-04-30 09:15:53 +00:00
Robert Bond 9140476a2a Merged PR 2285: tweak to live link 
tweak to live link

Related work items: #22423
 2026-04-29 17:03:50 +00:00
Robert Bond baf5b1838d Merged PR 2283: Data driven status pages from CRM 
Related work items: #22805
 2026-04-29 15:29:54 +00:00
Robert Bond 1fd192b870 Merged PR 2282: replaced deadlineextensiuondate 
replaced deadlineextensiuondate

Related work items: #22783
 2026-04-29 08:02:29 +00:00
Robert Bond a25ab433a6 Merged PR 2279: passed in case customer email in search and update rep logic to stop non owne... 
passed in case customer email in search and update rep logic to stop non owners rasing reps on other owners cases

Related work items: #22095
 2026-04-28 12:00:12 +00:00
Robert Bond b2945790b1 Merged PR 2274: case deadline and watch stream on results 
case deadline and wat

Related work items: #22423, #22783
 2026-04-27 13:07:46 +00:00
Robert Bond 138f03912b Merged PR 2273: check for existing record and not insert if exists 
check for existing record and not insert if exists

Related work items: #22441
 2026-04-24 15:56:54 +00:00
Robert Bond f367f3342c Merged PR 2271: typo on videos and update portal sumamry fro removed fields 
Related work items: #22698, #22813
 2026-04-24 13:10:20 +00:00
Robert Bond 7a14b7e8c9 Merged PR 2267: added ai guidance overlay 
added ai guidance overlay

Related work items: #21744
 2026-04-22 13:28:05 +00:00
Robert Bond b0004381ed Merged PR 2266: update media tabs display and query 
update media tabs display and query

Related work items: #22698
 2026-04-22 11:38:04 +00:00
Robert Bond 20782db916 Merged PR 2264: updatd createinvolvent call 
updatd createinvolvent call

Related work items: #22441
 2026-04-22 08:15:59 +00:00
Robert Bond f34ac3ba11 Merged PR 2263: createinvolvement updates contactinvolvement table 
createinvolvement updates contactinvolvement table

Related work items: #22441
 2026-04-21 16:16:31 +00:00
Robert Bond 5bf885933d Merged PR 2262: shows primary lpa and then lists additional lps below on the portal summary tab 
shows primary lpa and then lists additional lps below on the portal summary tab

Related work items: #22699
 2026-04-21 08:39:37 +00:00
Robert Bond 37a81522d5 Merged PR 2260: refactor(representations): complete slice-based refactor of representations flow 
## Representations Refactor — Behaviour-Preserving Structural Improvements

This PR delivers a full refactor of the representations flow, improving structure, readability, and maintainability while preserving all existing behaviour.

The work was completed using a controlled, slice-based approach with strict guardrails and regression validation at each step. No changes have been made to user journeys, payloads, routing, or EN/CY behaviour.

The result is a cleaner, more maintainable codebase with reduced coupling and clearer separation of concerns, ready for future enhancements without increased risk.

---

## What Was Done

The refactor was delivered incrementally across the following slices:

- **R1** — Representation entry logic extraction
- **R2** — Page loader separation (SSR/data orchestration)
- **R3** — Journey step resolution extraction
- **R4** — Flow shell decomposition
- **R5** — Representation elements normalisation
- **R6** — Data/service layer cleanup
- **R7** — Summary rendering proof slice
- **R8** — Submission/finalisation boundary isolation
- **R9** — Summary rollout (Batch 1)

Each slice:
- was isolated to a single concern
- followed strict guardrails
- was validated before merge

Full detail is available in:
`context/representations-refactor-tracker.md`

---

## Key Improvements

- Reduced coupling across the representations journey
- Separated data loading, orchestration, and rendering concerns
- Simplified complex conditional logic into testable helpers
- Standardised summary rendering using shared primitives (`SummaryCard`, `SummaryRow`)
- Isolated submission/finalisation sequencing into explicit boundaries
- Improved overall readability and maintainability

---

## Behaviour Preservation

This refactor does **not** change:

- User journeys (APP / IP / Agent / LPA)
- Route and query behaviour
- Payload contracts and API interactions
- Redux state shape and usage
- Validation rules and messaging
- EN/CY behaviour
- File upload / PDF / email sequencing
- Linked-case logic

All changes are structural only.

---

## Validation

### Automated

- `npm run lint` — passed (warnings only, no new errors)
- `npm run test:reps` — passed (7/7)

### Manual

Validated end-to-end across:

- APP
- IP
- Agent
- LPA

Including:

- representation creation
- editing/resuming representations
- submission flow
- confirmation/completion behaviour
- summary rendering across case types
- EN/CY parity

---

## Risk Management

The refactor targeted several high-risk areas:

- Case summary entry logic
- Representation submission/finalisation sequencing
- Dual-mode entry (new vs existing representation)

Risk was controlled through:

- small, incremental slices
- one branch per slice
- regression validation per slice
- strict behaviour-preservation guardrails
- controlled rollout for summary rendering changes

---

## Reviewer Guidance

Suggested areas to focus on:

- End-to-end representation journey (create → submit → complete)
- S...
 2026-04-20 13:09:07 +00:00
Robert Bond c8b08a04a6 Merged PR 2250: fixed typo 
Related work items: #22632
 2026-04-16 10:47:54 +00:00
Robert Bond bb4c3ee054 Merged PR 2247: added health endpoint to check pre prod container startup issues 
added health endpoint to check pre prod container startup issues

Related work items: #22624
 2026-04-15 09:52:15 +00:00
Robert Bond 15c35d201e Merged PR 2244: added condition to fix log in journey in welsh if no account in crm 
added condition to fix log in journey in welsh if no account in crm

Related work items: #22081, #22303
 2026-04-13 15:54:51 +00:00