Commit Graph
35 Commits
Author SHA1 Message Date
Robert Bond 5483c4cdf2 Merged PR 2426: added var to summary map and welsh translatioins
added var to summary map and welsh translatioins

Related work items: #23879
2026-06-24 17:10:22 +00:00
Robert Bond 9595ad86df Merged PR 2374: addeding domain layer extrraction
# Summary

This PR introduces a **Case Lifecycle Domain Boundary** to centralize lifecycle decision logic and reduce coupling within the appeals application.

The work is **behaviour-preserving** and introduces no intentional changes to business rules, CRM integrations, translations, dashboards, API routes, or user-facing functionality.

## What was added

New lifecycle boundary:

```text
lib/domain/case-lifecycle/
```

Key responsibilities extracted:

- Specialist process normalization
- Appeal type mapping
- Specialist process stage override mapping
- Stage case-type resolution
- Stage catalogue lookup
- Closed-case status recognition
- Lifecycle stage index resolution
- Lifecycle stage status assignment

## Behaviour preserved

Characterization tests were added before each extraction to preserve:

- Appeal type mapping and aliases
- Specialist process handling
- Lifecycle stage progression
- Closed-case handling
- Status assignment (`complete`, `in-progress`, `not-started`)
- Existing ROW behaviour
- Existing `statuscode` lifecycle semantics

Closed-case recognition remains unchanged for:

```text
1000
5
6
846040013
846040059
846040060
```

## Documentation

Added:

```text
lib/domain/case-lifecycle/README.md
```

Documenting:

- Boundary ownership
- Non-goals
- Lifecycle invariants
- Known architectural constraints
- Future extraction roadmap

## Testing

Added lifecycle characterization coverage for:

- Stage wrapper behaviour
- Specialist process normalization
- Appeal type mapping
- Specialist process stage mapping
- Stage case-type resolution
- Stage catalogue lookup
- Progress behaviour
- Closed-case status handling
- Stage index resolution
- Stage status assignment

## Validation

- Lifecycle characterization tests passed
- `npm run lint` passed with no errors

## Out of Scope

No changes to:

- Stage catalogue ownership
- Representation eligibility
- Dashboard calculations
- CRM/OData queries
- API routes
- Redux state
- EN/CY translations
- Event visibility logic

## Risk

**Low risk**

The refactor was delivered through small, characterization-first slices with no functional changes intended.

Related work items: #23527
2026-06-08 09:34:30 +00:00
Robert Bond d0cae0fff1 Merged PR 2368: case stage ROW updates and case closed variants and adv search fix
Related work items: #23551, #23555, #23559
2026-06-03 12:44:59 +00:00
Robert Bond d0b2fd077a Merged PR 2315: Auth stabilistatiion and hardening
Related work items: #23020
2026-05-14 08:55:49 +00:00
Robert Bond baf5b1838d Merged PR 2283: Data driven status pages from CRM
Related work items: #22805
2026-04-29 15:29:54 +00:00
Robert Bond b0004381ed Merged PR 2266: update media tabs display and query
update media tabs display and query

Related work items: #22698
2026-04-22 11:38:04 +00:00
robbond eebcfffd5e refactor phase 3a pages-newappeal-and-case targeted actions imports 2026-03-12 09:43:47 +00:00
robbond 5013b967f3 reinstate sips rep button logic 2026-02-20 07:40:27 +00:00
robbond 53540911cc 21254 youtube media player 2026-02-04 11:22:11 +00:00
robbond 92ceacb57b Merge branch 'Development' into SIPS-Development 2025-08-20 12:11:55 +01:00
robbond 95d5164b2f updated right click actions 2025-08-18 18:24:42 +01:00
robbond f696b20671 Merge branch '17728-show-reps-open-on-dnsapplications-list-page' of https://welshgovernment.visualstudio.com/PEDW%20-%20Planning%20Casework/_git/FrontEnd into 17728-show-reps-open-on-dnsapplications-list-page 2025-08-11 07:49:14 +01:00
robbond 8895d5a328 included ticketnumber 2025-08-11 07:35:49 +01:00
bevanl3 f9831b9aa4 fix missing case info when signed out 2025-08-04 16:15:55 +01:00
robbond ae5c0b4e39 14115 SIPs events on summary page 2025-02-19 15:00:25 +00:00
robbond d187907802 added fixes to reduce error when calling module details and filtering of docs 2024-11-06 17:34:30 +00:00
robbond 2612b5e743 finalised copy changes as per gel review 2024-10-31 09:48:38 +00:00
robbond 8239d9ff77 added in info banner for case summary 2024-10-07 09:51:10 +01:00
robbond f6f69a6305 hide document links if scheduled docapi downtime set 2024-08-27 13:15:19 +01:00
robbond c73cf2a013 added service account header removed duplicate sign in button 2024-08-12 11:09:59 +01:00
robbond b0e2bb6e14 remove unused imports 2024-06-19 06:32:38 +01:00
robbond 2a6cd32452 console log tidying 2024-06-05 19:50:56 +01:00
robbond c947995e7b reps defects 2024-06-03 11:57:11 +01:00
robbond 2d906fd360 updated breadcrumb link on case details page 2024-04-22 17:50:50 +01:00
robbond b6f40bea45 create ui for address search and results 2024-04-22 13:15:28 +01:00
robbond 7014323161 direct link to case page by ticketnumber 2024-04-09 15:04:48 +01:00
robbond a836c667b8 update footer props with ticketnumber 2024-04-09 15:03:33 +01:00
robbond 87019693e2 linked watched cases for all personnas 2024-02-02 12:30:18 +00:00
robbond 3e83332d28 updated watched cases with language and confirm 2024-01-29 15:11:23 +00:00
robbond 96387db56e hide reps button & add rich text for reps 2022-10-12 12:23:26 +01:00
robbond 11334e2366 removed references to doc history 2022-03-04 10:31:03 +00:00
robbond f347a0d73b Added service stage status and delete functions 2022-01-25 10:09:11 +00:00
robbond 9d54b0cd2d updated cookie manger added cookie policy 2021-11-11 10:51:04 +00:00
robbond db49898e91 mapping fields for case type 2021-10-26 12:56:21 +01:00
robbond 346cefd1bb pagination for documents seo head meta refactor 2021-10-22 13:23:38 +01:00