robbond/pedwfrontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,022 Commits 6 Branches 3 Tags
e5ada29cdb5c2df03fd868e38dd2bb643b46d11e
Commit Graph
64 Commits
Author SHA1 Message Date
Robert Bond 421adafca3 Merged PR 2280: fix in place for app error 
fix in place for app error

Related work items: #22834
 2026-04-28 15:48:32 +00:00
Robert Bond 0de9268255 Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change) 
## Summary

This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.

This refactor was executed in controlled slices with regression validation at each step.

## Scope

Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)

## Behaviour

No intended behavioural changes.

The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity

## Validation

Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity

Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)

## Risk

Low:
- changes are structural only
- no business logic changes
- no contract changes

## Rollback

Safe rollback via reverting this merge commit.

## Notes

This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.

Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
 2026-04-13 13:09:12 +00:00
robbond a0a633a9ea refactor phase 3a components chunk 1 targeted actions imports 2026-03-12 12:13:29 +00:00
robbond dfaa54a6cf updated start date validation to be dependant on value of dateofapplication 2026-01-06 12:47:56 +00:00
robbond cf0c05ff6a removed comments 2025-04-16 14:55:06 +01:00
robbond 35f19bd975 removed comments 2025-04-16 14:48:15 +01:00
robbond 608348910f rep defect 46 2025-02-07 12:45:30 +00:00
robbond 32a3542f79 rep defect 42,questioinnaire defect 67, enf defect 16 2025-01-21 16:04:52 +00:00
robbond 8b175b114d uat defect 124 2025-01-11 08:14:14 +00:00
robbond 7ec0607d6c path to getbloblistproxy fails csr policy and uncommented saving of appeal progess data 2024-12-12 09:43:12 +00:00
robbond beb5d6f809 file upload fix... limit to 210mb updates file list from storage account 2024-12-11 11:25:06 +00:00
robbond dcb6171dc1 multiple file upload issues capped at 210mb for now 2024-12-10 15:09:04 +00:00
robbond 19310b8145 welsh changes 2024-12-05 16:34:48 +00:00
robbond b423bb0cea updatd documents needed list 2024-11-28 06:30:24 +00:00
robbond 7b6862c350 updated validation for cost applciation 2024-11-27 11:13:31 +00:00
robbond 85f323d580 uat fixes 2024-11-27 11:00:12 +00:00
robbond dc71d16a1f when click change linik values persisted 2024-10-21 15:39:28 +01:00
robbond 80f499c072 breacrumb change & form styling 2024-08-12 17:20:06 +01:00
robbond b0e2bb6e14 remove unused imports 2024-06-19 06:32:38 +01:00
robbond ab54fdd8d8 fix for new appeal 2024-05-29 11:10:59 +01:00
robbond c546ea6c04 escape spaces and chars for rep filename 2024-05-24 14:17:35 +01:00
robbond 6bf933b2f1 updated file name prefixes 2024-05-21 14:03:24 +01:00
robbond cb27f80e7f update language translations placeholders 2024-04-11 11:26:07 +01:00
robbond 802bb3c9f7 copy amends 2024-03-27 19:51:30 +00:00
robbond a973f94995 updated url for email link 2024-03-25 10:15:38 +00:00
robbond 4d037ffeb8 10489 submission fix 2024-02-27 17:41:28 +00:00
robbond 2af463fbe9 update jsonpath library 2024-02-08 14:28:40 +00:00
robbond 89c38fe4c9 added agent details to new appeal pdf 2024-01-23 13:14:52 +00:00
robbond 01f768c624 finalised new appeal pdf to show selected dropdowns 2024-01-19 11:57:14 +00:00
robbond 5f82c59abb rich text field and pdf create for appeal 2024-01-16 14:23:11 +00:00
robbond ef1f773022 updated 2023-11-08 13:20:43 +00:00
robbond 275258562e updated welsh translations 2023-05-23 10:38:03 +01:00
robbond 6fe3fc51a6 sendemail function for gov notify 2022-11-17 13:16:57 +00:00
robbond 6be6a02101 cleared build warnings and format console message 2022-10-18 11:52:55 +01:00
robbond 71a2ef5b73 remove invalid props reference 2022-10-04 13:41:23 +01:00
robbond 7cd7ab78aa Saving progress spinner and language updates 2022-10-04 10:24:49 +01:00
robbond 745b51839a decopled crm for new appeals - all made on storage 2022-09-28 10:13:36 +01:00
robbond d907070ca9 delet blob wip 2022-09-12 15:54:55 +01:00
robbond c66883b4c5 awaiting submissions from storage acc 2022-09-05 16:46:30 +01:00
robbond 862a953aae updated storage account stuff to take auth id 2022-08-26 15:19:34 +01:00
robbond ee110bd8a7 new appeal progress pattern 2022-07-19 11:54:00 +01:00
robbond be9f86b6b2 added hashing on api calls 2022-07-12 12:49:26 +01:00
robbond f23ad2a300 upload fies to storage account for appeal 2022-07-07 17:06:56 +01:00
robbond 9d90b7f0a8 check form updates 2022-06-07 14:36:47 +01:00
robbond f2e71c0b54 cleared debug, updated new appeal add about you 2022-05-31 10:15:03 +01:00
robbond b99512066b edit a partial completed appeal 2022-05-05 11:04:05 +01:00
robbond d63d87aa3e build fix 2022-04-07 08:11:40 +01:00
robbond 093cba5d70 added form ordering and validation for s78 2022-04-06 16:52:22 +01:00
robbond 5ea7681f77 document upload form 2022-02-03 15:13:00 +00:00
robert.bond@test.gov.wales b12b5ef64b create incident record in new appeal 2021-09-09 12:29:18 +01:00