robbond/pedwfrontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,022 Commits 6 Branches 3 Tags
e5ada29cdb5c2df03fd868e38dd2bb643b46d11e
Commit Graph
41 Commits
Author SHA1 Message Date
Robert Bond 1a2c3ede3b Merged PR 2295: resolved lint warnings 
resolved lint warnings

Related work items: #22873
 2026-05-05 17:13:53 +00:00
Robert Bond 0de9268255 Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change) 
## Summary

This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.

This refactor was executed in controlled slices with regression validation at each step.

## Scope

Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)

## Behaviour

No intended behavioural changes.

The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity

## Validation

Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity

Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)

## Risk

Low:
- changes are structural only
- no business logic changes
- no contract changes

## Rollback

Safe rollback via reverting this merge commit.

## Notes

This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.

Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
 2026-04-13 13:09:12 +00:00
robbond c64c47ca1f languge check for relevant template language 2026-03-17 10:29:00 +00:00
robbond a0a633a9ea refactor phase 3a components chunk 1 targeted actions imports 2026-03-12 12:13:29 +00:00
robbond 103c548e32 added scrolltop 2025-07-08 09:08:13 +01:00
robbond f9310d655b defect 82 removed colons 2024-12-02 17:06:59 +00:00
robbond 8f84ae8d8a uat fixes 2024-11-26 09:18:53 +00:00
robbond b0e2bb6e14 remove unused imports 2024-06-19 06:32:38 +01:00
robbond 2b9c160aee duplicate contacts catch and handle and welsh 2024-06-11 16:45:41 +01:00
robbond 300a45ee0f console log tidying 2024-06-05 19:51:43 +01:00
robbond 0f3d20ca80 adjusted ordering of sequence to complete 2024-05-02 10:37:28 +01:00
robbond 7976ac9bfb removed call to update case in crm and error logging 2024-04-30 14:37:41 +01:00
robbond 51f2a74b9b preamble text and other copy changes 2024-04-24 17:24:35 +01:00
robbond 802bb3c9f7 copy amends 2024-03-27 19:51:30 +00:00
robbond 15f4f10a10 appelacomplete tag on completion 2024-03-14 13:14:24 +00:00
robbond 1049da3787 update path in queue message inc url 2024-03-12 18:10:44 +00:00
robbond c929aaa493 fixed wrong params passed to queue message 2024-03-11 08:04:53 +00:00
robbond f434fcf4f8 added in double quotes for single in query 2024-03-07 09:45:50 +00:00
robbond ef1f773022 updated 2023-11-08 13:20:43 +00:00
robbond d3bba6c620 added in message queue for applications and reps 2023-01-19 17:25:16 +00:00
robbond 6fe3fc51a6 sendemail function for gov notify 2022-11-17 13:16:57 +00:00
robbond 7115aab927 build fixes 2022-09-07 11:23:30 +01:00
robbond c66883b4c5 awaiting submissions from storage acc 2022-09-05 16:46:30 +01:00
robbond 9d90b7f0a8 check form updates 2022-06-07 14:36:47 +01:00
robbond 093cba5d70 added form ordering and validation for s78 2022-04-06 16:52:22 +01:00
robbond f7dd728696 document link disable 2022-02-16 07:17:20 +00:00
robbond f347a0d73b Added service stage status and delete functions 2022-01-25 10:09:11 +00:00
robbond d96c072bfe added in basic auth from env variable 2021-11-12 12:14:17 +00:00
robbond b790228454 update create appeal and pinsuser cookie 2021-11-02 11:40:11 +00:00
robbond c2ac1b1a1b added dns query included results and details 2021-09-21 12:03:29 +01:00
robert.bond@test.gov.wales a9a8670691 updated query for my cases and long appealtypes 2021-09-20 10:07:32 +01:00
robert.bond@test.gov.wales c96a72f124 my cases portal module by loggedin user 2021-09-17 16:37:06 +01:00
robert.bond@test.gov.wales 6ad60b990b update proxy for get - update appeal record data 2021-09-15 16:43:17 +01:00
robbond bb38c6d001 fixed some build issues stopping deployment 2021-09-14 15:05:11 +01:00
robert.bond@test.gov.wales 1a1ad02fcf added proxy updting case to avoid cors and be SSR 2021-09-14 14:36:26 +01:00
robert.bond@test.gov.wales b7815c112e appeal update case 2021-09-14 12:23:43 +01:00
robert.bond@test.gov.wales 1208848d82 updating form to show case ref 2021-09-14 07:58:27 +01:00
robert.bond@test.gov.wales b12b5ef64b create incident record in new appeal 2021-09-09 12:29:18 +01:00
robert.bond@test.gov.wales 2825ab5a7d forms to include FE facing only 2021-09-08 12:34:40 +01:00
robbond 4c31728322 add methods and store for case reference 2021-07-20 11:26:25 +01:00
robbond 7711d32ab8 added check answer summary & complete appeal step 2021-07-16 10:02:25 +01:00