robbond/pedwfrontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,078 Commits 6 Branches 3 Tags
ec046944c0fc991ccbc4673c2a592dddece13708
Commit Graph
49 Commits
Author SHA1 Message Date
Robert Bond e864049bec Merged PR 2449: language helper 
Related work items: #23754
 2026-07-01 11:29:15 +00:00
Robert Bond 0de9268255 Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change) 
## Summary

This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.

This refactor was executed in controlled slices with regression validation at each step.

## Scope

Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)

## Behaviour

No intended behavioural changes.

The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity

## Validation

Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity

Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)

## Risk

Low:
- changes are structural only
- no business logic changes
- no contract changes

## Rollback

Safe rollback via reverting this merge commit.

## Notes

This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.

Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
 2026-04-13 13:09:12 +00:00
robbond 3bc3759a48 welsh downloadable new appeal form 2026-03-30 12:35:41 +01:00
robbond 7c84344d5d applied downloadable checkbox on submit of new appeal 2026-03-16 13:58:02 +00:00
robbond 344b6efed1 chore(lint): unblock next lint and fix current eslint errors 2026-03-13 06:24:38 +00:00
robbond a0a633a9ea refactor phase 3a components chunk 1 targeted actions imports 2026-03-12 12:13:29 +00:00
robbond 9241fe0b84 updated restriction to disallow partial reps and appeals from being submitted when not docapi 2026-01-15 13:20:07 +00:00
robbond d882e65071 uodated queries to sort deep recursion 2025-04-16 08:44:45 +01:00
robbond 87f0dcd811 changes sandbox: {} to eval: true, caused errors in evaluated queries 2025-04-15 17:25:14 +01:00
robbond 05f791e6a8 update jsonpath for csp fix 2025-04-15 12:59:27 +01:00
robbond bedaa79281 rep defect 42, questionnaire defect 67, enf defect 16 2025-02-03 17:04:05 +00:00
robbond 6dded01501 reps defect 43 - also handles not submitting reps when date passed 2025-01-30 14:12:15 +00:00
robbond 232fd4685d uat defect 131 - link in new tab 2025-01-14 16:58:47 +00:00
robbond 61e74a5da8 uat defect 124 amend 2025-01-11 08:22:33 +00:00
robbond 8b175b114d uat defect 124 2025-01-11 08:14:14 +00:00
robbond 8e6296e4b1 uat defect 120 2025-01-05 09:24:22 +00:00
robbond beb5d6f809 file upload fix... limit to 210mb updates file list from storage account 2024-12-11 11:25:06 +00:00
robbond b668f323fe fix for new appeal and reps updates 2024-12-04 19:30:18 +00:00
robbond 499a1e9527 if agent dont change to appellant on submit appeal 2024-12-02 18:50:55 +00:00
robbond 85f323d580 uat fixes 2024-11-27 11:00:12 +00:00
robbond d901b18ed4 updated filelist obj to check else default to empty array 2024-11-07 14:05:58 +00:00
robbond dc71d16a1f when click change linik values persisted 2024-10-21 15:39:28 +01:00
robbond b0e2bb6e14 remove unused imports 2024-06-19 06:32:38 +01:00
robbond c546ea6c04 escape spaces and chars for rep filename 2024-05-24 14:17:35 +01:00
robbond 6bf933b2f1 updated file name prefixes 2024-05-21 14:03:24 +01:00
robbond 4735993ae5 update state order 2024-05-03 12:32:25 +01:00
robbond 46582d761c fixes for rep complete queue 2024-05-02 16:19:46 +01:00
robbond 0f3d20ca80 adjusted ordering of sequence to complete 2024-05-02 10:37:28 +01:00
robbond 923ed0c47d changed order of so pdf doesnt get orphaned 2024-04-30 14:02:25 +01:00
robbond 802bb3c9f7 copy amends 2024-03-27 19:51:30 +00:00
robbond dc933087d2 added tenant fieldarray and date ranges 2024-03-20 10:56:42 +00:00
robbond c929aaa493 fixed wrong params passed to queue message 2024-03-11 08:04:53 +00:00
robbond e99a0263af added key to top three row for appeal sunbmission card 2024-03-05 10:48:25 +00:00
robbond 4d037ffeb8 10489 submission fix 2024-02-27 17:41:28 +00:00
robbond e7afa582ff view all updates for reps 2023-11-08 09:03:34 +00:00
robbond 1f669a5efe reps pdf upload directory restructure 2023-10-04 14:28:56 +01:00
robbond 6fe3fc51a6 sendemail function for gov notify 2022-11-17 13:16:57 +00:00
robbond f8ab5c1528 files object display 2022-07-19 11:52:50 +01:00
robbond be9f86b6b2 added hashing on api calls 2022-07-12 12:49:26 +01:00
robbond f23ad2a300 upload fies to storage account for appeal 2022-07-07 17:06:56 +01:00
robbond 9d90b7f0a8 check form updates 2022-06-07 14:36:47 +01:00
robbond f7dd728696 document link disable 2022-02-16 07:17:20 +00:00
robbond 873a7730f1 added translation lookups for appeal forms 2021-10-07 07:30:46 +01:00
robbond bb38c6d001 fixed some build issues stopping deployment 2021-09-14 15:05:11 +01:00
robert.bond@test.gov.wales 2825ab5a7d forms to include FE facing only 2021-09-08 12:34:40 +01:00
robbond 777df3f907 mobile fixes 2021-07-28 15:29:20 +01:00
robbond be476394c8 added validation methods 2021-07-23 14:32:57 +01:00
robbond 1e81f1c97e passing a ref api through form and update progress 2021-07-20 16:46:14 +01:00
robbond 7711d32ab8 added check answer summary & complete appeal step 2021-07-16 10:02:25 +01:00