 Robert Bond
|
0de9268255
|
Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change)
## Summary
This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.
This refactor was executed in controlled slices with regression validation at each step.
## Scope
Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)
## Behaviour
No intended behavioural changes.
The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity
## Validation
Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity
Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)
## Risk
Low:
- changes are structural only
- no business logic changes
- no contract changes
## Rollback
Safe rollback via reverting this merge commit.
## Notes
This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.
Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
|
2026-04-13 13:09:12 +00:00 |
|
 robbond
|
e6b0b0763a
|
21099 update filename validation with #
|
2026-01-20 15:20:54 +00:00 |
|
|
robbond
|
d882e65071
|
uodated queries to sort deep recursion
|
2025-04-16 08:44:45 +01:00 |
|
|
robbond
|
05f791e6a8
|
update jsonpath for csp fix
|
2025-04-15 12:59:27 +01:00 |
|
|
robbond
|
dcb6171dc1
|
multiple file upload issues capped at 210mb for now
|
2024-12-10 15:09:04 +00:00 |
|
|
robbond
|
7c95f679ba
|
max 5 owners or tenants in field arry
|
2024-12-02 18:49:15 +00:00 |
|
|
robbond
|
b0e2bb6e14
|
remove unused imports
|
2024-06-19 06:32:38 +01:00 |
|
|
robbond
|
300a45ee0f
|
console log tidying
|
2024-06-05 19:51:43 +01:00 |
|
|
robbond
|
5a411dc290
|
sent pdf to stream not a file
|
2024-04-30 11:27:09 +01:00 |
|
|
robbond
|
802bb3c9f7
|
copy amends
|
2024-03-27 19:51:30 +00:00 |
|
|
robbond
|
2af463fbe9
|
update jsonpath library
|
2024-02-08 14:28:40 +00:00 |
|
|
robbond
|
5f82c59abb
|
rich text field and pdf create for appeal
|
2024-01-16 14:23:11 +00:00 |
|
|
robbond
|
f23ad2a300
|
upload fies to storage account for appeal
|
2022-07-07 17:06:56 +01:00 |
|
|
robbond
|
eb5d03a068
|
filename changes to include case ref and cat code
|
2022-06-21 12:09:03 +01:00 |
|
|
robbond
|
f2e71c0b54
|
cleared debug, updated new appeal add about you
|
2022-05-31 10:15:03 +01:00 |
|
|
robbond
|
093cba5d70
|
added form ordering and validation for s78
|
2022-04-06 16:52:22 +01:00 |
|
|
robbond
|
5ea7681f77
|
document upload form
|
2022-02-03 15:13:00 +00:00 |
|
|
robert.bond@test.gov.wales
|
2825ab5a7d
|
forms to include FE facing only
|
2021-09-08 12:34:40 +01:00 |
|
|
robert.bond@test.gov.wales
|
8e8797418a
|
added crm driven form via oauth
|
2021-09-07 12:46:59 +01:00 |
|
|
robbond
|
be476394c8
|
added validation methods
|
2021-07-23 14:32:57 +01:00 |
|
|
robbond
|
4c31728322
|
add methods and store for case reference
|
2021-07-20 11:26:25 +01:00 |
|
|
robbond
|
a555276c86
|
added redux store for form elements
|
2021-07-12 14:44:08 +01:00 |
|
|
robbond
|
83441496c7
|
added in lookup mocks
|
2021-07-09 11:48:51 +01:00 |
|
|
robbond
|
878940a6d5
|
initial dynamic forms
|
2021-07-08 16:22:12 +01:00 |
|