Commit Graph
53 Commits
Author SHA1 Message Date
Robert Bond 95486f0164 Merged PR 2476: added check for inactive case deadlines
added check for inactive case deadlines

Related work items: #24297
2026-07-15 12:41:10 +00:00
Robert Bond ff699735c7 Merged PR 2442: remove lodash dependecies on _.has
Related work items: #23754
2026-06-29 13:08:06 +00:00
Robert Bond 37a81522d5 Merged PR 2260: refactor(representations): complete slice-based refactor of representations flow
## Representations Refactor — Behaviour-Preserving Structural Improvements

This PR delivers a full refactor of the representations flow, improving structure, readability, and maintainability while preserving all existing behaviour.

The work was completed using a controlled, slice-based approach with strict guardrails and regression validation at each step. No changes have been made to user journeys, payloads, routing, or EN/CY behaviour.

The result is a cleaner, more maintainable codebase with reduced coupling and clearer separation of concerns, ready for future enhancements without increased risk.

---

## What Was Done

The refactor was delivered incrementally across the following slices:

- **R1** — Representation entry logic extraction
- **R2** — Page loader separation (SSR/data orchestration)
- **R3** — Journey step resolution extraction
- **R4** — Flow shell decomposition
- **R5** — Representation elements normalisation
- **R6** — Data/service layer cleanup
- **R7** — Summary rendering proof slice
- **R8** — Submission/finalisation boundary isolation
- **R9** — Summary rollout (Batch 1)

Each slice:
- was isolated to a single concern
- followed strict guardrails
- was validated before merge

Full detail is available in:
`context/representations-refactor-tracker.md`

---

## Key Improvements

- Reduced coupling across the representations journey
- Separated data loading, orchestration, and rendering concerns
- Simplified complex conditional logic into testable helpers
- Standardised summary rendering using shared primitives (`SummaryCard`, `SummaryRow`)
- Isolated submission/finalisation sequencing into explicit boundaries
- Improved overall readability and maintainability

---

## Behaviour Preservation

This refactor does **not** change:

- User journeys (APP / IP / Agent / LPA)
- Route and query behaviour
- Payload contracts and API interactions
- Redux state shape and usage
- Validation rules and messaging
- EN/CY behaviour
- File upload / PDF / email sequencing
- Linked-case logic

All changes are structural only.

---

## Validation

### Automated

- `npm run lint` — passed (warnings only, no new errors)
- `npm run test:reps` — passed (7/7)

### Manual

Validated end-to-end across:

- APP
- IP
- Agent
- LPA

Including:

- representation creation
- editing/resuming representations
- submission flow
- confirmation/completion behaviour
- summary rendering across case types
- EN/CY parity

---

## Risk Management

The refactor targeted several high-risk areas:

- Case summary entry logic
- Representation submission/finalisation sequencing
- Dual-mode entry (new vs existing representation)

Risk was controlled through:

- small, incremental slices
- one branch per slice
- regression validation per slice
- strict behaviour-preservation guardrails
- controlled rollout for summary rendering changes

---

## Reviewer Guidance

Suggested areas to focus on:

- End-to-end representation journey (create → submit → complete)
- S...
2026-04-20 13:09:07 +00:00
robbond 1f5be7c9a2 pass in locale to questionnaire for welsh version 2026-04-08 16:50:47 +01:00
robbond 7c84344d5d applied downloadable checkbox on submit of new appeal 2026-03-16 13:58:02 +00:00
robbond 071fcc0dab updated copy on representation complete submit 2026-03-16 12:07:39 +00:00
robbond 344b6efed1 chore(lint): unblock next lint and fix current eslint errors 2026-03-13 06:24:38 +00:00
robbond a0a633a9ea refactor phase 3a components chunk 1 targeted actions imports 2026-03-12 12:13:29 +00:00
robbond 2c6d110d9b chekc box to download questionnaire 2026-03-09 12:13:24 +00:00
robbond 9241fe0b84 updated restriction to disallow partial reps and appeals from being submitted when not docapi 2026-01-15 13:20:07 +00:00
robbond eae42c3622 16435 logic to disable continue button so cant submit empty rep 2025-04-28 17:14:59 +01:00
robbond a33018d225 16003 Sips Documents, 16010 Role baes reps for sips 2025-04-28 13:53:25 +01:00
robbond 608348910f rep defect 46 2025-02-07 12:45:30 +00:00
robbond bedaa79281 rep defect 42, questionnaire defect 67, enf defect 16 2025-02-03 17:04:05 +00:00
robbond 6dded01501 reps defect 43 - also handles not submitting reps when date passed 2025-01-30 14:12:15 +00:00
robbond 28aec45270 enf defect 17 - removed leftover enf type from questionnaire selection 2025-01-17 16:38:02 +00:00
robbond e539b7054b fix to delay moving on til large pdf completed 2025-01-16 14:06:56 +00:00
robbond 49418becf2 uat defect 131 link in new tab 2025-01-15 09:22:23 +00:00
robbond d0075d6112 questionnaire defect 48 continued 2025-01-14 18:31:36 +00:00
robbond 72e1bfb3ad questionnaire defect 48 2025-01-14 18:18:17 +00:00
robbond b0cafb58be two digit day month on reps doc 2025-01-07 11:23:53 +00:00
robbond 29d8090630 questionnaire defect 21, rep defect 30,11 2025-01-07 06:56:06 +00:00
robbond b133dca25a rep defect 13, 8, 20 2025-01-02 13:10:09 +00:00
robbond c204aeb43b reps defect 10 2025-01-02 12:31:30 +00:00
robbond 97cfeb562a upodated rep file upload 2024-12-18 12:39:17 +00:00
robbond b668f323fe fix for new appeal and reps updates 2024-12-04 19:30:18 +00:00
robbond 49d39e052e questionnaire for callins and uploads 2024-12-03 18:27:51 +00:00
robbond fd4784902b check questionnaires fix and update enforcement check 2024-11-19 19:10:07 +00:00
robbond 4bf10d97db hooks fixes and ordering of events 2024-11-16 07:45:38 +00:00
robbond a1524c5018 added caseinvolvement api for rep 2024-10-16 12:41:37 +01:00
robbond 9e345631f6 Corrected link text 2024-10-07 10:09:54 +01:00
robbond b0e2bb6e14 remove unused imports 2024-06-19 06:32:38 +01:00
robbond f8a2d44443 welsh lang updates 2024-06-10 10:36:27 +01:00
robbond 87672a14b9 uploading files to reps 2024-06-05 19:52:31 +01:00
robbond 5001fbcbfe updated view all to set missing current view state 2024-06-05 12:21:39 +01:00
robbond c947995e7b reps defects 2024-06-03 11:57:11 +01:00
robbond f8b7d22802 show submitted reps on dashboard 2024-05-28 18:44:52 +01:00
robbond 59907fed0a removed hello debug text 2024-05-23 13:18:07 +01:00
robbond 37233b4c1a removes hello by expanding appeal types 2024-05-23 09:47:26 +01:00
robbond 56fbb3fdc0 fixed page flow from submission of questionnaire 2024-05-22 10:41:29 +01:00
robbond 0e3df85fdc applied reps documents naming conventions 2024-05-14 19:06:20 +01:00
robbond 46582d761c fixes for rep complete queue 2024-05-02 16:19:46 +01:00
robbond b7a643a6b1 cleaned up rep functionality 2024-01-24 14:19:36 +00:00
robbond 1477ed74e4 welsh versions of questionnaire 2023-10-31 14:12:12 +00:00
robbond 0c98bcd831 rep pdf questionnaire variants 2023-10-17 09:07:18 +01:00
robbond 1f669a5efe reps pdf upload directory restructure 2023-10-04 14:28:56 +01:00
robbond 2ce248fba8 update pdf templates with attched docs 2023-09-26 13:39:23 +01:00
robbond 41847b3433 create pdf reps for lpa 2023-09-26 09:12:57 +01:00
robbond d3bba6c620 added in message queue for applications and reps 2023-01-19 17:25:16 +00:00
robbond ee4d00a500 reps trigger for logged out & upload storage acc 2023-01-05 14:26:08 +00:00