Commit Graph
43 Commits
Author SHA1 Message Date
Robert Bond e864049bec Merged PR 2449: language helper
Related work items: #23754
2026-07-01 11:29:15 +00:00
Robert Bond ff699735c7 Merged PR 2442: remove lodash dependecies on _.has
Related work items: #23754
2026-06-29 13:08:06 +00:00
Robert Bond 0de9268255 Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change)
## Summary

This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.

This refactor was executed in controlled slices with regression validation at each step.

## Scope

Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)

## Behaviour

No intended behavioural changes.

The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity

## Validation

Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity

Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)

## Risk

Low:
- changes are structural only
- no business logic changes
- no contract changes

## Rollback

Safe rollback via reverting this merge commit.

## Notes

This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.

Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
2026-04-13 13:09:12 +00:00
robbond a0a633a9ea refactor phase 3a components chunk 1 targeted actions imports 2026-03-12 12:13:29 +00:00
robbond a80fa87ea2 refactor 2025-06-11 13:05:18 +01:00
robbond d882e65071 uodated queries to sort deep recursion 2025-04-16 08:44:45 +01:00
robbond 87f0dcd811 changes sandbox: {} to eval: true, caused errors in evaluated queries 2025-04-15 17:25:14 +01:00
robbond 05f791e6a8 update jsonpath for csp fix 2025-04-15 12:59:27 +01:00
robbond 88ab1f3fc5 mobile issues in header 2024-08-13 12:02:46 +01:00
robbond be99db0774 improved error loggin and updated imports to fix build failure 2024-06-19 15:06:28 +01:00
robbond b0e2bb6e14 remove unused imports 2024-06-19 06:32:38 +01:00
robbond 300a45ee0f console log tidying 2024-06-05 19:51:43 +01:00
robbond 51f2a74b9b preamble text and other copy changes 2024-04-24 17:24:35 +01:00
robbond e2edee35c6 content amends for create appeal 2024-03-26 11:36:35 +00:00
robbond 17a1f1f414 10486 double click on dropdown 2024-02-27 11:39:00 +00:00
robbond dcdda6eb6e misc accessibility fixes 2024-02-21 17:19:01 +00:00
robbond 114f57aa5d Accessibility amends for new appeal 2024-02-19 16:53:58 +00:00
robbond 2af463fbe9 update jsonpath library 2024-02-08 14:28:40 +00:00
robbond 71a2ef5b73 remove invalid props reference 2022-10-04 13:41:23 +01:00
robbond 745b51839a decopled crm for new appeals - all made on storage 2022-09-28 10:13:36 +01:00
robbond c66883b4c5 awaiting submissions from storage acc 2022-09-05 16:46:30 +01:00
robbond 58415b82c6 debug logging 2022-07-19 11:53:34 +01:00
robbond 45e11c5713 logic for has or cas 2022-06-15 14:54:59 +01:00
robbond b3ce573c9c welsh trans for validation message 2022-06-14 18:21:47 +01:00
robbond cb9995da75 added hcas diagnostic choice 2022-06-14 17:08:11 +01:00
robbond b588927e20 added changes 2022-06-14 11:39:06 +01:00
robbond f2e71c0b54 cleared debug, updated new appeal add about you 2022-05-31 10:15:03 +01:00
robbond cba9446837 misc updates for filter and languages 2022-05-17 09:56:42 +01:00
robbond 5ea7681f77 document upload form 2022-02-03 15:13:00 +00:00
robbond 2f91be126c componentised timeout applied to logged in pages 2022-01-26 10:38:21 +00:00
robbond f347a0d73b Added service stage status and delete functions 2022-01-25 10:09:11 +00:00
robbond b790228454 update create appeal and pinsuser cookie 2021-11-02 11:40:11 +00:00
robbond 873a7730f1 added translation lookups for appeal forms 2021-10-07 07:30:46 +01:00
robbond c061650fe4 updated translations for lpas 2021-10-01 11:08:24 +01:00
robert.bond@test.gov.wales c96a72f124 my cases portal module by loggedin user 2021-09-17 16:37:06 +01:00
robert.bond@test.gov.wales b12b5ef64b create incident record in new appeal 2021-09-09 12:29:18 +01:00
robert.bond@test.gov.wales 8e8797418a added crm driven form via oauth 2021-09-07 12:46:59 +01:00
robbond b3fe6bf5f5 base flow for representations 2021-08-09 10:16:54 +01:00
robbond 2b14eaaf1f add mock api calls for modules viewall component 2021-07-29 14:46:09 +01:00
robbond 777df3f907 mobile fixes 2021-07-28 15:29:20 +01:00
robbond be476394c8 added validation methods 2021-07-23 14:32:57 +01:00
robbond 4c31728322 add methods and store for case reference 2021-07-20 11:26:25 +01:00
robbond de84da00c2 added back missing files 2021-07-19 21:49:14 +01:00