Robert Bond
0de9268255
Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change)
## Summary
This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.
This refactor was executed in controlled slices with regression validation at each step.
## Scope
Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)
## Behaviour
No intended behavioural changes.
The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity
## Validation
Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity
Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)
## Risk
Low:
- changes are structural only
- no business logic changes
- no contract changes
## Rollback
Safe rollback via reverting this merge commit.
## Notes
This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.
Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
2026-04-13 13:09:12 +00:00
..
2026-04-08 12:17:28 +01:00
2026-03-17 09:22:31 +00:00
2026-04-09 09:26:19 +01:00
2024-09-05 12:25:43 +01:00
2024-06-19 06:32:38 +01:00
2026-04-08 10:00:01 +01:00
2024-11-29 07:44:17 +00:00
2026-03-18 14:11:37 +00:00
2026-03-13 06:24:38 +00:00
2026-04-09 16:34:41 +01:00
2026-04-13 13:09:12 +00:00
2026-03-30 12:35:41 +01:00
2026-03-27 13:04:26 +00:00
2024-06-19 06:32:38 +01:00
2025-04-09 10:24:44 +01:00
2025-04-14 18:00:30 +01:00
2026-03-13 06:24:38 +00:00
2024-06-19 06:32:38 +01:00
2024-06-19 06:32:38 +01:00
2024-06-19 06:32:38 +01:00
2024-10-31 09:48:38 +00:00
2024-06-19 06:32:38 +01:00
2026-04-09 16:26:44 +01:00
2026-02-04 11:19:35 +00:00
2024-06-19 06:32:38 +01:00
2024-06-19 06:32:38 +01:00
2024-09-05 12:25:43 +01:00
2024-06-19 06:32:38 +01:00
2024-06-19 06:32:38 +01:00
2025-11-28 08:45:13 +00:00
2024-06-19 06:32:38 +01:00
2026-01-22 12:18:03 +00:00
2026-04-08 12:17:28 +01:00
2024-06-19 06:32:38 +01:00
2026-02-04 11:19:35 +00:00
2026-03-23 17:53:19 +00:00
2024-06-19 06:32:38 +01:00
2024-06-19 06:32:38 +01:00
2021-11-29 17:35:52 +00:00
2026-01-15 13:20:07 +00:00
2025-03-21 17:40:11 +00:00
2024-06-19 06:32:38 +01:00
2026-02-04 11:19:35 +00:00
2021-07-07 12:53:07 +01:00
2024-06-19 06:32:38 +01:00
2024-06-19 06:32:38 +01:00