fix(ci): correct rsync deploy path and define smoke check base URL

Reviewed-on: http://gitea.lan:3000/robbond/pleskSaas/pulls/42

Dockerfile

@@ -1,23 +1,23 @@
-FROM cgr.dev/chainguard/node:20-dev AS deps
+FROM node:20-bookworm-slim AS deps
 WORKDIR /app
 
 COPY package.json package-lock.json ./
 RUN npm ci
 
-FROM cgr.dev/chainguard/node:20-dev AS builder
+FROM node:20-bookworm-slim AS builder
 WORKDIR /app
 
 COPY --from=deps /app/node_modules ./node_modules
 COPY . .
 RUN npm run build
 
-FROM cgr.dev/chainguard/node:20-dev AS prod-deps
+FROM node:20-bookworm-slim AS prod-deps
 WORKDIR /app
 
 COPY package.json package-lock.json ./
 RUN npm ci --omit=dev
 
-FROM cgr.dev/chainguard/node:20 AS runner
+FROM node:20-bookworm-slim AS runner
 WORKDIR /app
 
 ENV NODE_ENV=production

Jenkinsfile

@@ -7,6 +7,12 @@ pipeline {
     REGISTRY_IMAGE = "plesk-agency-portal"
     IMAGE_LATEST = "${REGISTRY_IMAGE}:latest"
     IMAGE_BUILD = "${REGISTRY_IMAGE}:build-${BUILD_NUMBER}"
+    DEPLOY_SSH_CREDENTIAL_ID = "${env.DEPLOY_SSH_CREDENTIAL_ID ?: 'plesk-agency-deploy-key'}"
+    APP_HOST = "${env.APP_HOST ?: '192.168.68.89'}"
+    APP_USER = "${env.APP_USER ?: 'deploy'}"
+    DEPLOY_PATH = "${env.DEPLOY_PATH ?: '/opt/plesk-agency-portal'}"
+    APP_BASE_URL = "${env.APP_BASE_URL ?: 'http://192.168.68.89:3000'}"
+
   }
 
   stages {
@@ -66,40 +72,51 @@ pipeline {
       }
     }
 
-    stage('Deploy') {
+stage('Deploy') {
   steps {
-        script {
-          if (!env.DEPLOY_SSH_CREDENTIAL_ID) {
-            error 'DEPLOY_SSH_CREDENTIAL_ID is required'
-          }
-        }
-        sshagent(credentials: ["${env.DEPLOY_SSH_CREDENTIAL_ID}"]) {
+    withCredentials([sshUserPrivateKey(
+      credentialsId: "${env.DEPLOY_SSH_CREDENTIAL_ID}",
+      keyFileVariable: 'SSH_KEY'
+    )]) {
       sh '''
-            set -euo pipefail
-            : "${DEPLOY_SSH_HOST:?Missing DEPLOY_SSH_HOST}"
-            : "${DEPLOY_SSH_USER:?Missing DEPLOY_SSH_USER}"
-            : "${DEPLOY_PATH:?Missing DEPLOY_PATH}"
+bash -eo pipefail << 'EOF'
+set -euo pipefail
 
-            rsync -az \
+ssh -i "$SSH_KEY" "$APP_USER@$APP_HOST" "mkdir -p $DEPLOY_PATH/scripts"
+
+rsync -az \
+  -e "ssh -i $SSH_KEY" \
   docker-compose.prod.yml \
-              scripts/deploy-prod.sh \
-              scripts/smoke-check.sh \
-              scripts/rollback-prod.sh \
-              ${DEPLOY_SSH_USER}@${DEPLOY_SSH_HOST}:${DEPLOY_PATH}/
+  "$APP_USER@$APP_HOST:$DEPLOY_PATH/"
 
-            docker save ${IMAGE_LATEST} ${IMAGE_BUILD} \
-              | ssh ${DEPLOY_SSH_USER}@${DEPLOY_SSH_HOST} 'docker load'
+rsync -az \
+  -e "ssh -i $SSH_KEY" \
+  scripts/ \
+  "$APP_USER@$APP_HOST:$DEPLOY_PATH/scripts/"
 
-            ssh ${DEPLOY_SSH_USER}@${DEPLOY_SSH_HOST} \
-              "chmod +x ${DEPLOY_PATH}/deploy-prod.sh ${DEPLOY_PATH}/smoke-check.sh ${DEPLOY_PATH}/rollback-prod.sh && APP_IMAGE='${IMAGE_BUILD}' DEPLOY_PATH='${DEPLOY_PATH}' ${DEPLOY_PATH}/deploy-prod.sh"
+docker save ${IMAGE_LATEST} ${IMAGE_BUILD} \
+  | ssh -i "$SSH_KEY" "$APP_USER@$APP_HOST" 'docker load'
+
+ssh -i "$SSH_KEY" "$APP_USER@$APP_HOST" \
+  "cd $DEPLOY_PATH && chmod +x ./scripts/deploy-prod.sh ./scripts/smoke-check.sh ./scripts/rollback-prod.sh"
+
+ssh -i "$SSH_KEY" "$APP_USER@$APP_HOST" \
+  "cd $DEPLOY_PATH && ./scripts/deploy-prod.sh"
+EOF
       '''
     }
   }
-    }
+}
 
     stage('Smoke check') {
       steps {
-        sh 'chmod +x scripts/smoke-check.sh && scripts/smoke-check.sh ${APP_BASE_URL}'
+        sh '''
+bash -eo pipefail << EOF
+set -euo pipefail
+chmod +x scripts/smoke-check.sh
+scripts/smoke-check.sh "${APP_BASE_URL}"
+EOF
+'''
       }
     }
   }