fix: make graph-backed questions authoritative

2026-08-03 09:13:52 +01:00
parent ef04b9e494
commit db994d7764
4 changed files with 285 additions and 31 deletions
@@ -5,6 +5,7 @@ import {
  classifyObservationRelationship,
  COMPARABILITY_REASONING_NODE_ID,
  formulateQuestion,
+  formulateTieResolutionQuestion,
 } from "./question-formulator.js";
 import {
  graphUpdateSchema,
@@ -1623,6 +1624,97 @@ function findNodeById(graph, nodeId) {
  return (graph.nodes || []).find((node) => node.id === nodeId) || null;
 }

+export function determineGraphBackedQuestion({ situationGraph }) {
+  const graphSnapshot = cloneJsonSafe(situationGraph);
+  let updatedSituationGraph = cloneJsonSafe(situationGraph);
+  let deterministicSelection = selectActiveUnknownCandidate(
+    updatedSituationGraph,
+    updatedSituationGraph.resolvedNodeIds || [],
+  );
+
+  const decompositionResult = runDeterministicDecomposition({
+    graphSnapshot,
+    proposalSnapshot: {
+      addedNodes: [],
+      updatedNodes: [],
+      addedEdges: [],
+      removedEdgeIds: [],
+      resolvedUnknownNodeIds: [],
+      affectedNodeIds: [],
+      selectedQuestion: null,
+    },
+    updatedSituationGraph,
+    reasoningResolution: { reasoningStateOverride: {} },
+    deterministicSelection,
+  });
+
+  if (!decompositionResult.success) {
+    return decompositionResult;
+  }
+
+  updatedSituationGraph = decompositionResult.updatedSituationGraph;
+  updatedSituationGraph.reasoningState = buildReasoningState(
+    updatedSituationGraph,
+  );
+  deterministicSelection = selectActiveUnknownCandidate(
+    updatedSituationGraph,
+    updatedSituationGraph.resolvedNodeIds || [],
+  );
+  updatedSituationGraph.activeUnknownNodeId =
+    deterministicSelection?.status === "selected"
+      ? deterministicSelection.nodeId
+      : null;
+  updatedSituationGraph.currentSummary = describeGraph(updatedSituationGraph);
+
+  const selectedNode =
+    deterministicSelection?.status === "selected"
+      ? findNodeById(updatedSituationGraph, deterministicSelection.nodeId)
+      : null;
+  const formulatedQuestion = selectedNode
+    ? formulateQuestion({
+        node: selectedNode,
+        graph: updatedSituationGraph,
+        context: { selectionState: deterministicSelection },
+      })
+    : null;
+
+  return {
+    success: true,
+    updatedSituationGraph,
+    deterministicSelection,
+    selectedQuestion:
+      deterministicSelection?.status === "ambiguous"
+        ? {
+            id: "q_tie_resolution",
+            ...formulateTieResolutionQuestion({ graph: updatedSituationGraph }),
+            nodeId: null,
+            tiedCandidateIds: deterministicSelection.tiedCandidateIds,
+          }
+        : deterministicSelection?.status === "selected" && formulatedQuestion
+          ? {
+              nodeId: deterministicSelection.nodeId,
+              question:
+                formulatedQuestion.question || deterministicSelection.question,
+              reason: formulatedQuestion.reason,
+              strategy: formulatedQuestion.strategy,
+              investigationStrategy: formulatedQuestion.investigationStrategy,
+              questionComplexity: formulatedQuestion.questionComplexity,
+              plainLanguageNormalisations:
+                formulatedQuestion.plainLanguageNormalisations,
+            }
+          : null,
+    atomicityAssessment: decompositionResult.atomicityAssessment,
+    decompositionPerformed:
+      decompositionResult.decompositionAttempted &&
+      decompositionResult.decompositionAccepted,
+    decompositionAttempted: decompositionResult.decompositionAttempted,
+    selectedUnknownBefore: decompositionResult.selectedUnknownBefore,
+    selectedUnknownAfter: deterministicSelection?.nodeId ?? null,
+    questionComplexityAssessment:
+      formulatedQuestion?.questionComplexity ?? null,
+  };
+}
+
 function runDeterministicDecomposition({
  graphSnapshot,
  proposalSnapshot,