robbond/pedwfrontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,995 Commits 6 Branches 3 Tags
0ff2d69ba60bb56bee7da7b70a54a726056535e8
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Robert Bond 0ff2d69ba6 Merged PR 2290: add guard rail to check for locale and ensure verify request is language spec... 
add guard rail to check for locale and ensure verify request is language specific

Related work items: #22303
 2026-05-05 08:25:17 +00:00
Robert Bond d2e88b57d8 Merged PR 2288: add in company name for appellant and autofill agent details in new appeal 
add in company name for appellant and autofill agent details in new appeal

Related work items: #22842
 2026-04-30 16:25:03 +00:00
Robert Bond b596374c3c Merged PR 2286: allowed LPAs to make statements 
allowed LPAs to make statements

Related work items: #22848
 2026-04-30 09:15:53 +00:00
Robert Bond 9140476a2a Merged PR 2285: tweak to live link 
tweak to live link

Related work items: #22423
 2026-04-29 17:03:50 +00:00
Robert Bond baf5b1838d Merged PR 2283: Data driven status pages from CRM 
Related work items: #22805
 2026-04-29 15:29:54 +00:00
Robert Bond 1fd192b870 Merged PR 2282: replaced deadlineextensiuondate 
replaced deadlineextensiuondate

Related work items: #22783
 2026-04-29 08:02:29 +00:00
Robert Bond 8b187742af Merged PR 2281: update logic for reps arr take isAppellant from capacity selection not type o... 
update logic for reps arr take isAppellant from capacity selection not type of involvement

Related work items: #22835
 2026-04-28 16:07:35 +00:00
Robert Bond 421adafca3 Merged PR 2280: fix in place for app error 
fix in place for app error

Related work items: #22834
 2026-04-28 15:48:32 +00:00
Robert Bond a25ab433a6 Merged PR 2279: passed in case customer email in search and update rep logic to stop non owne... 
passed in case customer email in search and update rep logic to stop non owners rasing reps on other owners cases

Related work items: #22095
 2026-04-28 12:00:12 +00:00
Robert Bond 843e6adee6 Merged PR 2278: mocked design for status tab 
mocked design for status tab

Related work items: #22805
 2026-04-28 09:36:48 +00:00
Robert Bond b2945790b1 Merged PR 2274: case deadline and watch stream on results 
case deadline and wat

Related work items: #22423, #22783
 2026-04-27 13:07:46 +00:00
Robert Bond 138f03912b Merged PR 2273: check for existing record and not insert if exists 
check for existing record and not insert if exists

Related work items: #22441
 2026-04-24 15:56:54 +00:00
Robert Bond d406d97ddf Merged PR 2272: final comments added and update _IP_ precendence to be lower 
final comments added and update _IP_ precendence to be lower

Related work items: #22573, #22661
 2026-04-24 14:44:24 +00:00
Robert Bond f367f3342c Merged PR 2271: typo on videos and update portal sumamry fro removed fields 
Related work items: #22698, #22813
 2026-04-24 13:10:20 +00:00
Robert Bond d604d4f264 Merged PR 2269: added link for streaming events 
added link for streaming events

Related work items: #22423
 2026-04-23 14:34:08 +00:00
Robert Bond 43e37dc844 Merged PR 2268: adjusted styling tto center vertically dynamically 
adjusted styling tto center vertically dynamically

Related work items: #22659
 2026-04-23 04:59:06 +00:00
Robert Bond 7a14b7e8c9 Merged PR 2267: added ai guidance overlay 
added ai guidance overlay

Related work items: #21744
 2026-04-22 13:28:05 +00:00
Robert Bond b0004381ed Merged PR 2266: update media tabs display and query 
update media tabs display and query

Related work items: #22698
 2026-04-22 11:38:04 +00:00
Robert Bond 20782db916 Merged PR 2264: updatd createinvolvent call 
updatd createinvolvent call

Related work items: #22441
 2026-04-22 08:15:59 +00:00
Robert Bond f34ac3ba11 Merged PR 2263: createinvolvement updates contactinvolvement table 
createinvolvement updates contactinvolvement table

Related work items: #22441
 2026-04-21 16:16:31 +00:00
Robert Bond 5bf885933d Merged PR 2262: shows primary lpa and then lists additional lps below on the portal summary tab 
shows primary lpa and then lists additional lps below on the portal summary tab

Related work items: #22699
 2026-04-21 08:39:37 +00:00
Robert Bond 05d83822f2 Merged PR 2261: added in text and ui redesign for rep type selection 
added in text and ui redesign for rep type selection

Related work items: #22574
 2026-04-21 04:59:01 +00:00
Robert Bond 37a81522d5 Merged PR 2260: refactor(representations): complete slice-based refactor of representations flow 
## Representations Refactor — Behaviour-Preserving Structural Improvements

This PR delivers a full refactor of the representations flow, improving structure, readability, and maintainability while preserving all existing behaviour.

The work was completed using a controlled, slice-based approach with strict guardrails and regression validation at each step. No changes have been made to user journeys, payloads, routing, or EN/CY behaviour.

The result is a cleaner, more maintainable codebase with reduced coupling and clearer separation of concerns, ready for future enhancements without increased risk.

---

## What Was Done

The refactor was delivered incrementally across the following slices:

- **R1** — Representation entry logic extraction
- **R2** — Page loader separation (SSR/data orchestration)
- **R3** — Journey step resolution extraction
- **R4** — Flow shell decomposition
- **R5** — Representation elements normalisation
- **R6** — Data/service layer cleanup
- **R7** — Summary rendering proof slice
- **R8** — Submission/finalisation boundary isolation
- **R9** — Summary rollout (Batch 1)

Each slice:
- was isolated to a single concern
- followed strict guardrails
- was validated before merge

Full detail is available in:
`context/representations-refactor-tracker.md`

---

## Key Improvements

- Reduced coupling across the representations journey
- Separated data loading, orchestration, and rendering concerns
- Simplified complex conditional logic into testable helpers
- Standardised summary rendering using shared primitives (`SummaryCard`, `SummaryRow`)
- Isolated submission/finalisation sequencing into explicit boundaries
- Improved overall readability and maintainability

---

## Behaviour Preservation

This refactor does **not** change:

- User journeys (APP / IP / Agent / LPA)
- Route and query behaviour
- Payload contracts and API interactions
- Redux state shape and usage
- Validation rules and messaging
- EN/CY behaviour
- File upload / PDF / email sequencing
- Linked-case logic

All changes are structural only.

---

## Validation

### Automated

- `npm run lint` — passed (warnings only, no new errors)
- `npm run test:reps` — passed (7/7)

### Manual

Validated end-to-end across:

- APP
- IP
- Agent
- LPA

Including:

- representation creation
- editing/resuming representations
- submission flow
- confirmation/completion behaviour
- summary rendering across case types
- EN/CY parity

---

## Risk Management

The refactor targeted several high-risk areas:

- Case summary entry logic
- Representation submission/finalisation sequencing
- Dual-mode entry (new vs existing representation)

Risk was controlled through:

- small, incremental slices
- one branch per slice
- regression validation per slice
- strict behaviour-preservation guardrails
- controlled rollout for summary rendering changes

---

## Reviewer Guidance

Suggested areas to focus on:

- End-to-end representation journey (create → submit → complete)
- S...
 2026-04-20 13:09:07 +00:00
Robert Bond c8b08a04a6 Merged PR 2250: fixed typo 
Related work items: #22632
 2026-04-16 10:47:54 +00:00
Robert Bond bb4c3ee054 Merged PR 2247: added health endpoint to check pre prod container startup issues 
added health endpoint to check pre prod container startup issues

Related work items: #22624
 2026-04-15 09:52:15 +00:00
Robert Bond 15c35d201e Merged PR 2244: added condition to fix log in journey in welsh if no account in crm 
added condition to fix log in journey in welsh if no account in crm

Related work items: #22081, #22303
 2026-04-13 15:54:51 +00:00
Robert Bond 0de9268255 Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change) 
## Summary

This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.

This refactor was executed in controlled slices with regression validation at each step.

## Scope

Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)

## Behaviour

No intended behavioural changes.

The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity

## Validation

Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity

Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)

## Risk

Low:
- changes are structural only
- no business logic changes
- no contract changes

## Rollback

Safe rollback via reverting this merge commit.

## Notes

This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.

Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
 2026-04-13 13:09:12 +00:00
Robert Bond bd3d311cfb Merged PR 2231: refactor breadcrumb 
Related work items: #22541
 2026-04-09 15:36:06 +00:00
Robert Bond 3cea83b7e1 Merged PR 2230: pass in locale to questionnaire for welsh version 
pass in locale to questionnaire for welsh version

Related work items: #22534
 2026-04-08 15:51:37 +00:00
Robert Bond 87af9a2c4c Merged PR 2228: refactoring fix and fix for language dependant login and download questionnaire 
Related work items: #22303, #22344, #22500
 2026-04-08 11:20:59 +00:00
Robert Bond 02512ec403 Merged PR 2227: batch uploads on frontend 
batch uploads on frontend

Related work items: #22422
 2026-04-02 15:11:05 +00:00
Robert Bond da7e694120 Merged PR 2225: added fallback of 5 if no env var declared 
added fallback of 5 if no env var declared

Related work items: #22422
 2026-04-02 14:29:51 +00:00
Robert Bond 638b51e55d Merged PR 2224: batch count from env var 
batch count from env var

Related work items: #22422
 2026-04-02 14:26:01 +00:00
Robert Bond bd13886222 Merged PR 2222: batch uploaded files in blocks of 10 at a time 
batch uploaded files in blocks of 10 at a time

Related work items: #22422
 2026-04-02 14:07:20 +00:00
Robert Bond fd76dfe9bc Merged PR 2215: update ldp query 
update ldp query

Related work items: #21992
 2026-04-02 09:03:21 +00:00
Robert Bond 82b99ae44f Merged PR 2210: Rep raising and pdf for welsh 
Related work items: #22095, #22305
 2026-03-30 11:46:22 +00:00
Robert Bond 461ca7dc02 Merged PR 2209: sprint 16 bug fixes 
Related work items: #22079, #22151, #22304
 2026-03-27 13:10:49 +00:00
Robert Bond 6f8bbd0131 Merged PR 2208: update and clean azurestorage.js 
Related work items: #22326
 2026-03-26 11:42:42 +00:00
Robert Bond 35ff16b2b2 Merged PR 2207: updated refactoring docs 
docs: add current-state context pack and actionable sequence-b prompts

Related work items: #22242
 2026-03-25 13:21:02 +00:00
Robert Bond e238ec079f Merged PR 2206: split out actions to services and clients 
Related work items: #22260
 2026-03-25 12:16:40 +00:00
Robert Bond 5e51c2eb97 Merged PR 2205: addin timeouts and retries for stability 
Related work items: #22242
 2026-03-24 18:19:01 +00:00
Robert Bond 0faf79945f Merged PR 2204: update hardening docs 
Related work items: #22239
 2026-03-24 12:45:53 +00:00
Robert Bond 2ac2f51fc3 Merged PR 2203: Api hardening 
Related work items: #22236
 2026-03-24 12:06:02 +00:00
Robert Bond 1b7d9da32c Merged PR 2202: relay GET completion + notify logging fix 
Related work items: #22229
 2026-03-24 11:32:13 +00:00
Robert Bond dea127912f Merged PR 2201: update file endpoints 
Related work items: #22224
 2026-03-24 06:30:29 +00:00
Robert Bond 78cac2cbb9 Merged PR 2198: update apis 
Related work items: #22211
 2026-03-23 12:38:30 +00:00
Robert Bond 2caae7b458 Merged PR 2197: update endpoint api slice 
Related work items: #22168
 2026-03-23 10:45:31 +00:00
Robert Bond 54820324f5 Merged PR 2188: mocku pand welsh login flow 
Related work items: #22079, #22081
 2026-03-18 14:12:43 +00:00
Robert Bond 860291e1e6 Merged PR 2185: address parts now do and and not fail if more than one is added 
address parts now do and and not fail if more than one is added

Related work items: #22093
 2026-03-18 10:41:36 +00:00
Robert Bond 22b70f9081 Merged PR 2184: update apis with helpers 
Related work items: #22109
 2026-03-17 16:39:31 +00:00
Robert Bond 864da9fe23 Merged PR 2183: stanadardised response contract test 
Related work items: #22104
 2026-03-17 14:11:54 +00:00
Robert Bond f6c5e7183c Merged PR 2182: update apis with standardised response helpers 
Related work items: #22102
 2026-03-17 13:38:06 +00:00
Robert Bond 7d06bc7bfa Merged PR 2181: updated query and display logic for post determination fields 
updated query and display logic for post determination fields

Related work items: #21710
 2026-03-17 12:01:30 +00:00
Robert Bond bda0af9e5c Merged PR 2178: removed app if not an app in capacity 
removed app if not an app in capacity

Related work items: #22095
 2026-03-17 11:16:42 +00:00
Robert Bond 51f89320de Merged PR 2177: languge check for relevant template language 
languge check for relevant template language

Related work items: #21979
 2026-03-17 10:29:58 +00:00
Robert Bond fcd51b41bd Merged PR 2176: update formatting 
update formatting

Related work items: #22012
 2026-03-17 09:24:41 +00:00
Robert Bond 1e690608fb Merged PR 2172: applied downloadable checkbox on submit of new appeal 
applied downloadable checkbox on submit of new appeal

Related work items: #22062
 2026-03-16 13:58:54 +00:00
Robert Bond 72eafd0a8e Merged PR 2170: updated copy on representation complete submit 
updated copy on representation complete submit

Related work items: #21095, #21979
 2026-03-16 12:08:49 +00:00
Robert Bond e9b2753fd9 Merged PR 2169: Api hardening 
Related work items: #22057
 2026-03-16 11:17:53 +00:00
Robert Bond 36d35f9549 Merged PR 2168: update client side api calls with hardened hash 
Related work items: #22028
 2026-03-13 17:59:32 +00:00
Robert Bond 0ca6cd94cc Merged PR 2167: APi hardening 
Related work items: #22019
 2026-03-13 14:24:39 +00:00
Robert Bond 51269db849 Merged PR 2166: hardening for sensitive hash-guarded APIs 
TASK22017: phase 8 hardening for sensitive hash-guarded APIs

Related work items: #22017
 2026-03-13 11:43:17 +00:00
Robert Bond f28b25cc24 Merged PR 2165: TASK21988a: Phase 7 search SSR fix and service behaviour expansion 
TASK21988a: Phase 7 search SSR fix and service behaviour expansion

Related work items: #21998
 2026-03-13 11:01:10 +00:00
Robert Bond 3abebc8093 Merged PR 2164: test(actions): phase 6 add parity and behavioural service hardening checks 
test(actions): phase 6 add parity and behavioural service hardening checks

Related work items: #21998
 2026-03-13 10:16:46 +00:00
Robert Bond a35f2990c6 Merged PR 2163: split actions to individual services 
Related work items: #21997
 2026-03-13 07:42:22 +00:00
Robert Bond 1d1baec43b Merged PR 2162: refactor actions 
Related work items: #21996
 2026-03-13 05:51:45 +00:00
Robert Bond 0bd6e12877 Merged PR 2159: adjusted logic to cater for viewl all path and dnsapplications 
adjusted logic to cater for viewl all path and dnsapplications

Related work items: #21942, #21943, #21971
 2026-03-11 10:42:44 +00:00
Robert Bond 9c483ec655 Merged PR 2158: fixed breacrumb and label 
fixed breacrumb and label

Related work items: #18688, #21942, #21943
 2026-03-10 18:06:46 +00:00
Robert Bond 93d02697a2 Merged PR 2157: correctly go back to the previous page search results 
correctly go back to the previous page search results

Related work items: #18688, #21942, #21943
 2026-03-10 10:33:13 +00:00
Robert Bond e6c25d7ef5 Merged PR 2154: notify check for new case ref tempate and pref lang 
notify check for new case ref tempate and pref lang

Related work items: #21722, #21726
 2026-03-09 14:11:29 +00:00
Robert Bond de5ee86cde Merged PR 2153: fix for pdf formatting and hyperlinks 
fix for pdf formatting and hyperlinks

Related work items: #21897, #21898
 2026-03-09 13:13:04 +00:00
Robert Bond 95c1492fe0 Merged PR 2152: check box to download questionnaire 
chekc box to download questionnaire

Related work items: #17556
 2026-03-09 12:14:14 +00:00
Robert Bond e2c79d6b0f Merged PR 2134: regex update to include apostrophe 
regex update to include apostrophe

Related work items: #21099
 2026-02-27 09:42:32 +00:00
Robert Bond db184984ca Merged PR 2133: removed the help section on registration 
removed the help section on registration

Related work items: #21093
 2026-02-27 09:04:54 +00:00
Robert Bond 92eb0c5a15 Merged PR 2132: included emdash in doc upload validation 
included emdash in doc upload validation

Related work items: #21099
 2026-02-26 13:05:10 +00:00
Robert Bond b39ed0fd8c Merged PR 2123: updated to allow new appeals to work post ph merge 
updated to allow new appeals to work post ph merge

Related work items: #17555
 2026-02-23 12:47:20 +00:00
Robert Bond 43c692a959 Merged PR 2121: missing case ref failing sip reps pdf 
missing case ref failing sip reps pdf

Related work items: #21254
 2026-02-20 16:17:22 +00:00
Robert Bond 292a280f50 Merged PR 2120: update to cater for tickenumber not title 
had been done on ph2 needed updating for sips

Related work items: #21254
 2026-02-20 12:00:14 +00:00
Robert Bond c438a62553 Merged PR 2115: reinstate sips rep button logic 
reinstate sips rep button logic

Related work items: #21254
 2026-02-20 07:44:14 +00:00
Robert Bond 85b0a7e4c4 Merged PR 2112: pass mediaobj to case pages 
Related work items: #21254
 2026-02-19 14:14:42 +00:00
Robert Bond 38a948e9a0 Merged PR 2070: media tab and player 
Related work items: #21254, #21255, #21256
 2026-02-04 11:23:21 +00:00
Robert Bond 5c6ee2fedd Merged PR 2064: update language delimeter to >>> 
Related work items: #21187
 2026-01-27 12:01:12 +00:00
Robert Bond 3569bce8d1 Merged PR 2060: added in link and label in english and welsh 
added in link and label in english and welsh

Related work items: #21091
 2026-01-22 12:19:28 +00:00
Robert Bond a65ed04ad7 Merged PR 2055: 21099 api serverside validation check 
21099 api serverside validation check

Related work items: #21099
 2026-01-21 13:18:35 +00:00
Robert Bond e0392b108c Merged PR 2051: Update filename validation 
Related work items: #21099, #21154
 2026-01-20 15:22:40 +00:00
Robert Bond b9434e07a3 Merged PR 2038: 18791 remove further details 
Related work items: #21097, #21098
 2026-01-19 13:17:43 +00:00
Robert Bond 088c93e2cf Merged PR 2034: updates to new appeal 
restricts completion of an appeal or rep if no docapi....stop it failing if already started.

Related work items: #17559
 2026-01-15 13:23:55 +00:00
Robert Bond 94861846aa Merged PR 2026: added searching by LPA application ref and criteria highlighting 
added searching by LPA application ref and criteria highlighting

Related work items: #18544
 2026-01-09 13:38:36 +00:00
Robert Bond 062f64d157 Merged PR 2024: Update validation for decision date 
Related work items: #17559
 2026-01-08 12:52:08 +00:00
Robert Bond 6978114ce0 Merged PR 2017: merge latest ph2 to sips 
Related work items: #20553
 2025-12-02 14:17:22 +00:00
Robert Bond 140d615310 Merged PR 2016: part 2 ph2 update 
part 2 ph2 update

Related work items: #20553
 2025-11-28 13:30:31 +00:00
Robert Bond ab1df81745 Merged PR 2009: partial synch with ph2 updates 
partial synch with ph2 updates

Related work items: #20553
 2025-11-28 08:50:01 +00:00
Robert Bond ff394882a5 Merged PR 1999: fixed ui misaligned button and wrong text 
fixed ui misaligned button and wrong text

Related work items: #20166
 2025-11-18 08:04:38 +00:00
Robert Bond c622cb2f74 Merged PR 1987: docoffline dependant appeals and reps 
docoffline dependant appeals and reps

Related work items: #20166
 2025-11-10 08:57:48 +00:00
Robert Bond eebe30a232 Merged PR 1957: Fixes for d365 
Related work items: #19548, #19887, #19889
 2025-10-28 11:26:42 +00:00
Robert Bond 8be971f0b9 Merged PR 1905: Download throttling 
Related work items: #19431
 2025-10-01 08:28:16 +00:00
Robert Bond c5d3792048 Merged PR 1870: Fix downloading reps links 
updated download and delete links to encode with correct hash values

Related work items: #18901
 2025-09-11 09:55:16 +00:00
Robert Bond dc14e6c9af Merged PR 1869: ph 2 merge to sips 
Related work items: #18559
 2025-09-10 09:22:28 +00:00
Robert Bond 16010f177a Merged PR 1847: doc link fix for unpublished docs and cases 
doc link fix for unpublished docs and cases

Related work items: #18559
 2025-09-01 08:48:23 +00:00
Robert Bond 2c3c3f1cdf Merged PR 1846: Admin tabs 
Related work items: #18559
 2025-08-29 07:59:12 +00:00