robbond/pedwfrontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,994 Commits 6 Branches 3 Tags
7713fc37243fdd7fb037ebe017ba210c95d6ec53
Commit Graph
1994 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Robert Bond 7713fc3724 Merged PR 2256: refactor(representations): preserve Welsh conditional validation and summary... 
refactor(representations): preserve Welsh conditional validation and summary parity

Related work items: #22441
 2026-04-17 12:44:23 +00:00
Robert Bond 33f31ad3c8 Merged PR 2255: refactor(representations): extract deterministic data-resolution helpers for... 
refactor(representations): extract deterministic data-resolution helpers for representation flow (Slice R6, behaviour-preserving)

Related work items: #22441
 2026-04-17 10:07:52 +00:00
Robert Bond 8e21ec1dd7 Merged PR 2254: refactor(representations): normalise shared type-selector and action-row frag... 
refactor(representations): normalise shared type-selector and action-row fragments in main representation variants (Slice R5, behaviour-preserving)

Related work items: #22441
 2026-04-17 09:22:36 +00:00
Robert Bond d05e54c020 Merged PR 2252: refactor(representations): extract journey step-resolution helpers (Slice R3,... 
refactor(representations): extract journey step-resolution helpers (Slice R3, behaviour-preserving)

Related work items: #22441
 2026-04-17 06:45:21 +00:00
Robert Bond a43eb76e3a Merged PR 2251: refactor(representations): separate representation page SSR loaders into lib/... 
refactor(representations): separate representation page SSR loaders into lib/representation/pageLoaders (Slice R2, behaviour-preserving)

Related work items: #22441
 2026-04-17 05:30:38 +00:00
robbond 011be977a2 Merge branch 'SIPS-Development' of https://welshgovernment.visualstudio.com/PEDW%20-%20Planning%20Casework/_git/FrontEnd into refactor 2026-04-16 12:35:44 +01:00
Robert Bond c8b08a04a6 Merged PR 2250: fixed typo 
Related work items: #22632
 2026-04-16 10:47:54 +00:00
Robert Bond bb4c3ee054 Merged PR 2247: added health endpoint to check pre prod container startup issues 
added health endpoint to check pre prod container startup issues

Related work items: #22624
 2026-04-15 09:52:15 +00:00
robbond e3614dba7b Merge branch 'refactor' of https://welshgovernment.visualstudio.com/PEDW%20-%20Planning%20Casework/_git/FrontEnd into refactor 2026-04-15 10:31:59 +01:00
Robert Bond ecd6075c3a Merged PR 2246: refactor reps first slice 
Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590, #22591
 2026-04-15 09:28:50 +00:00
Robert Bond 15c35d201e Merged PR 2244: added condition to fix log in journey in welsh if no account in crm 
added condition to fix log in journey in welsh if no account in crm

Related work items: #22081, #22303
 2026-04-13 15:54:51 +00:00
Robert Bond 0de9268255 Merged PR 2242: Refactor: New Appeal flow structural cleanup (Slices 1–8, no behaviour change) 
## Summary

This PR merges the completed new-appeal refactor stream (Slices 1–8) into SIPS-Development.

This refactor was executed in controlled slices with regression validation at each step.

## Scope

Structural and readability improvements only:
- XML/form derivation extraction
- payload and file helper extraction
- side-effect facade introduction
- BuildSection and BuildCheckSection decomposition
- BuildCheckRow formatter map refactor
- nested prop boundary cleanup
- start-flow cleanup (CreateCase / AboutYou)

## Behaviour

No intended behavioural changes.

The following were explicitly preserved:
- S78 journey behaviour
- payload shapes and field names/ids
- HASCAS mapping logic
- appellant/agent branching
- validation rules and messages
- redirect/query parameters (`lpa`, `apt`, `id`)
- navigation and side-effect sequencing
- EN/CY output parity

## Validation

Full regression has been performed on:
- start flow (CreateCase / AboutYou)
- save and resume flows
- file upload handling
- check answers rendering
- submit/finalisation sequence
- confirmation flow
- CRM insertion path
- EN/CY parity

Additional checks:
- docsOffline branch behaviour
- completion and partial-save email paths
- negative-path validation scenarios
- lint (warnings baseline unchanged)

## Risk

Low:
- changes are structural only
- no business logic changes
- no contract changes

## Rollback

Safe rollback via reverting this merge commit.

## Notes

This refactor reduces coupling and prepares the new-appeal flow for future appeal-type expansion.

Related work items: #22570, #22576, #22577, #22583, #22586, #22587, #22588, #22590
 2026-04-13 13:09:12 +00:00
Robert Bond f3a05db323 Merged PR 2241: refactor(newappeal): simplify start flow readability (Slice 8) 
refactor(newappeal): simplify start flow readability (Slice 8)

Related work items: #22590
 2026-04-13 12:55:58 +00:00
Robert Bond ffcccf8981 Merged PR 2240: refactor(newappeal): simplify nested prop boundaries (Slice 7) 
refactor(newappeal): simplify nested prop boundaries (Slice 7)

Related work items: #22588
 2026-04-13 12:25:45 +00:00
Robert Bond 783786b9eb Merged PR 2239: refactor(newappeal): replace BuildCheckRow formatter chain with map (Slice 6) 
refactor(newappeal): replace BuildCheckRow formatter chain with map (Slice 6)

Related work items: #22587
 2026-04-13 11:53:45 +00:00
Robert Bond 20eea5b128 Merged PR 2238: refactor(newappeal): extract BuildCheckSection presentation components (Slice 5) 
refactor(newappeal): extract BuildCheckSection presentation components (Slice 5)

Related work items: #22586
 2026-04-13 10:59:27 +00:00
Robert Bond 869264b7fa Merged PR 2237: refactor(newappeal): extract BuildSection presentation components (Slice 4) 
refactor(newappeal): extract BuildSection presentation components (Slice 4)

Related work items: #22583
 2026-04-13 10:15:56 +00:00
Robert Bond d0f667ffbb Merged PR 2236: refactor(newappeal): add side-effect facade wrappers (Slice 3) 
refactor(newappeal): add side-effect facade wrappers (Slice 3)

Related work items: #22583
 2026-04-13 09:31:14 +00:00
robbond f8b7f4fffd refactor(newappeal): add side-effect facade wrappers (Slice 3) 2026-04-13 10:26:35 +01:00
Robert Bond 21f511c34b Merged PR 2235: refactor(newappeal): extract file merge and dedupe helpers (Slice 2b) 
refactor(newappeal): extract file merge and dedupe helpers (Slice 2b)

Related work items: #22577
 2026-04-13 09:11:49 +00:00
robbond 7c4ce131bf refactor(newappeal): extract file merge and dedupe helpers (Slice 2b) 2026-04-13 10:07:58 +01:00
Robert Bond ddbf2116f5 Merged PR 2234: refactor(newappeal): extract payload cleanup helpers (Slice 2a) 
refactor(newappeal): extract payload cleanup helpers (Slice 2a)

- extracted boolean normalization

- extracted null key removal

- extracted internal key stripping

- no behaviour change

Related work items: #22576
 2026-04-13 08:31:23 +00:00
robbond 5233f62d59 refactor(newappeal): extract payload cleanup helpers (Slice 2a) 
- extracted boolean normalization

- extracted null key removal

- extracted internal key stripping

- no behaviour change
 2026-04-10 16:37:42 +01:00
Robert Bond 5f78a881c5 Merged PR 2232: xml form derivation 
Related work items: #22570
 2026-04-10 14:37:02 +00:00
robbond 7f7d4daa8f docs(refactor): update refactor tracker status 2026-04-10 15:34:06 +01:00
robbond e9d4b65a3d chore(refactor): commit current refactor branch updates and slice1 xml/form derivation extraction 2026-04-10 09:39:28 +01:00
Robert Bond bd3d311cfb Merged PR 2231: refactor breadcrumb 
Related work items: #22541
 2026-04-09 15:36:06 +00:00
robbond ee2751a642 catch fix in view all 2026-04-09 16:34:41 +01:00
robbond ac74782030 fix(breadcrumbs): restore static and viewall label crumb resolution 2026-04-09 16:26:44 +01:00
robbond 7d195ad906 refactor(breadcrumbs): remove stale /newappeal inline no-op branch 2026-04-09 15:22:36 +01:00
robbond 61254e3942 test(breadcrumbs): cover missing representation route map fallback 2026-04-09 15:19:40 +01:00
robbond 97cde880c0 docs(breadcrumbs): record map precedence and callback invariants 2026-04-09 15:17:44 +01:00
robbond d3f4dda8af refactor(breadcrumbs): extract representation route-state renderer group 2026-04-09 15:16:01 +01:00
robbond 7a60e64a84 test(breadcrumbs): assert strict null on non-exact route map lookups 2026-04-09 15:06:41 +01:00
robbond cebd47bf1c refactor(breadcrumbs): map step-back route branches into renderer group 2026-04-09 15:03:19 +01:00
robbond 0b905f9374 refactor(breadcrumbs): extract callback route renderers into mapped groups 2026-04-09 14:57:47 +01:00
robbond 0cd78e6f46 22541 harden breadcrumb mapped route resolver against invalid entries 2026-04-09 14:45:12 +01:00
robbond 2a84056a76 22541 extract new appeal breadcrumb branch into mapped renderer group 2026-04-09 14:39:30 +01:00
robbond 17795f20c7 22541 extract deterministic case breadcrumb branches into factory maps 2026-04-09 14:33:54 +01:00
robbond 8edd23d621 22541 compose mapped breadcrumb groups in factory and add null fallback guard 2026-04-09 14:30:03 +01:00
robbond 96946ed205 Extract additional routes in to shared renderer factory 2026-04-09 13:56:17 +01:00
robbond c264830934 Extract case detail breadcrumb routes into shared renderer factory 2026-04-09 13:16:56 +01:00
robbond 062cd23463 Refactor breadcrumbs to use factory-based route renderers 2026-04-09 12:08:36 +01:00
robbond 5f6dde782a 22541 extract breadcrumb route-map helpers and add precedence guard tests 2026-04-09 10:25:47 +01:00
robbond 78d62c541f 22541 consolidate breadcrumb mapped route maps into grouped constants 2026-04-09 10:21:09 +01:00
robbond ee3f3eae74 22541 map myportal results pair routes through unified breadcrumb resolver 2026-04-09 10:16:45 +01:00
robbond 786f906ab8 22541 unify breadcrumb mapped-route resolver and widen route-map coverage 2026-04-09 10:02:02 +01:00
robbond 04dc8fd2b9 22541 extract simple link-text breadcrumb route map and add structure tests 2026-04-09 09:58:22 +01:00
robbond c464fbf13b 22541 introduce simple route renderer map for static breadcrumb branches 2026-04-09 09:54:49 +01:00
robbond a8ef55c65a 22541 extract grouped breadcrumb pair helpers for myportal and dns routes 2026-04-09 09:52:42 +01:00